perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related

There were over 150 places in *::Notify() functions that did some
dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the
base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast
operations come with quite some cost, so avoid if possible. Specifically
for ScFormulaCell::Notify() that created a bottleneck in scenarios where
cells were notified that already handled a previous notification. In
mass operations doing the dynamic_cast before it could be decided
whether having to act on it or not this made 2/3 of all time spent in
the Notify() call.

To get rid of that rename/move SfxSimpleHint to SfxHint and let classes
derive from SfxHint instead of SfxSimpleHint. This comes only with a
slight cost that an additional sal_uInt32 is transported in such hints,
initialized to 0, but this is neglectable compared to the huge gain.

For the rare cases where a Notify() actually expects both, an SfxHint
(formerly SfxSimpleHint) and a derived hint, this changed order of the
dynamic_cast involved so the simple SfxHint::GetId() is handled last.
Modules using such combinations can further optimize by treating the
simple SfxHint::GetId() first once verified that none of the other
derived hints use an ID not equal to zero respectively none of the ID
values the simple hint uses.

Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce
Reviewed-on: https://gerrit.libreoffice.org/29205
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

2 files changed, 52 insertions, 56 deletions

diff --git a/basctl/inc/pch/precompiled_basctl.hxx b/basctl/inc/pch/precompiled_basctl.hxx
index 6cb86b18461e..ace1ace83800 100644
--- a/basctl/inc/pch/precompiled_basctl.hxx
+++ b/basctl/inc/pch/precompiled_basctl.hxx
@@ -418,7 +418,6 @@
 #include <svl/languageoptions.hxx>
 #include <svl/lstner.hxx>
 #include <svl/poolitem.hxx>
-#include <svl/smplhint.hxx>
 #include <svl/srchitem.hxx>
 #include <svl/stritem.hxx>
 #include <svl/style.hxx>
diff --git a/basctl/source/basicide/basidesh.cxx b/basctl/source/basicide/basidesh.cxx
index 75a75c04c072..e919ebe43ab2 100644
--- a/basctl/source/basicide/basidesh.cxx
+++ b/basctl/source/basicide/basidesh.cxx
@@ -480,71 +480,68 @@ void Shell::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
 {
     if (GetShell())
     {
-        if (SfxSimpleHint const* pSimpleHint = dynamic_cast<SfxSimpleHint const*>(&rHint))
+        switch (rHint.GetId())
         {
-            switch (pSimpleHint->GetId())
-            {
-                case SFX_HINT_DYING:
+            case SFX_HINT_DYING:
                 {
                     EndListening( rBC, true /* log off all */ );
                     aObjectCatalog->UpdateEntries();
                 }
-                break;
-            }
+            break;
+        }
 
-            if (SbxHint const* pSbxHint = dynamic_cast<SbxHint const*>(&rHint))
+        if (SbxHint const* pSbxHint = dynamic_cast<SbxHint const*>(&rHint))
+        {
+            const sal_uInt32 nHintId = pSbxHint->GetId();
+            if (    ( nHintId == SBX_HINT_BASICSTART ) ||
+                    ( nHintId == SBX_HINT_BASICSTOP ) )
             {
-                const sal_uInt32 nHintId = pSbxHint->GetId();
-                if (    ( nHintId == SBX_HINT_BASICSTART ) ||
-                        ( nHintId == SBX_HINT_BASICSTOP ) )
+                if (SfxBindings* pBindings = GetBindingsPtr())
                 {
-                    if (SfxBindings* pBindings = GetBindingsPtr())
-                    {
-                        pBindings->Invalidate( SID_BASICRUN );
-                        pBindings->Update( SID_BASICRUN );
-                        pBindings->Invalidate( SID_BASICCOMPILE );
-                        pBindings->Update( SID_BASICCOMPILE );
-                        pBindings->Invalidate( SID_BASICSTEPOVER );
-                        pBindings->Update( SID_BASICSTEPOVER );
-                        pBindings->Invalidate( SID_BASICSTEPINTO );
-                        pBindings->Update( SID_BASICSTEPINTO );
-                        pBindings->Invalidate( SID_BASICSTEPOUT );
-                        pBindings->Update( SID_BASICSTEPOUT );
-                        pBindings->Invalidate( SID_BASICSTOP );
-                        pBindings->Update( SID_BASICSTOP );
-                        pBindings->Invalidate( SID_BASICIDE_TOGGLEBRKPNT );
-                        pBindings->Update( SID_BASICIDE_TOGGLEBRKPNT );
-                        pBindings->Invalidate( SID_BASICIDE_MANAGEBRKPNTS );
-                        pBindings->Update( SID_BASICIDE_MANAGEBRKPNTS );
-                        pBindings->Invalidate( SID_BASICIDE_MODULEDLG );
-                        pBindings->Update( SID_BASICIDE_MODULEDLG );
-                        pBindings->Invalidate( SID_BASICLOAD );
-                        pBindings->Update( SID_BASICLOAD );
-                    }
+                    pBindings->Invalidate( SID_BASICRUN );
+                    pBindings->Update( SID_BASICRUN );
+                    pBindings->Invalidate( SID_BASICCOMPILE );
+                    pBindings->Update( SID_BASICCOMPILE );
+                    pBindings->Invalidate( SID_BASICSTEPOVER );
+                    pBindings->Update( SID_BASICSTEPOVER );
+                    pBindings->Invalidate( SID_BASICSTEPINTO );
+                    pBindings->Update( SID_BASICSTEPINTO );
+                    pBindings->Invalidate( SID_BASICSTEPOUT );
+                    pBindings->Update( SID_BASICSTEPOUT );
+                    pBindings->Invalidate( SID_BASICSTOP );
+                    pBindings->Update( SID_BASICSTOP );
+                    pBindings->Invalidate( SID_BASICIDE_TOGGLEBRKPNT );
+                    pBindings->Update( SID_BASICIDE_TOGGLEBRKPNT );
+                    pBindings->Invalidate( SID_BASICIDE_MANAGEBRKPNTS );
+                    pBindings->Update( SID_BASICIDE_MANAGEBRKPNTS );
+                    pBindings->Invalidate( SID_BASICIDE_MODULEDLG );
+                    pBindings->Update( SID_BASICIDE_MODULEDLG );
+                    pBindings->Invalidate( SID_BASICLOAD );
+                    pBindings->Update( SID_BASICLOAD );
+                }
 
-                    if ( nHintId == SBX_HINT_BASICSTOP )
-                    {
-                        // not only at error/break or explicit stoppage,
-                        // if the update is turned off due to a programming bug
-                        BasicStopped();
-                        if (pLayout)
-                            pLayout->UpdateDebug(true); // clear...
-                        if( m_pCurLocalizationMgr )
-                            m_pCurLocalizationMgr->handleBasicStopped();
-                    }
-                    else if( m_pCurLocalizationMgr )
-                    {
-                        m_pCurLocalizationMgr->handleBasicStarted();
-                    }
+                if ( nHintId == SBX_HINT_BASICSTOP )
+                {
+                    // not only at error/break or explicit stoppage,
+                    // if the update is turned off due to a programming bug
+                    BasicStopped();
+                    if (pLayout)
+                        pLayout->UpdateDebug(true); // clear...
+                    if( m_pCurLocalizationMgr )
+                        m_pCurLocalizationMgr->handleBasicStopped();
+                }
+                else if( m_pCurLocalizationMgr )
+                {
+                    m_pCurLocalizationMgr->handleBasicStarted();
+                }
 
-                    for (WindowTableIt it = aWindowTable.begin(); it != aWindowTable.end(); ++it)
-                    {
-                        BaseWindow* pWin = it->second;
-                        if ( nHintId == SBX_HINT_BASICSTART )
-                            pWin->BasicStarted();
-                        else
-                            pWin->BasicStopped();
-                    }
+                for (WindowTableIt it = aWindowTable.begin(); it != aWindowTable.end(); ++it)
+                {
+                    BaseWindow* pWin = it->second;
+                    if ( nHintId == SBX_HINT_BASICSTART )
+                        pWin->BasicStarted();
+                    else
+                        pWin->BasicStopped();
                 }
             }
         }