summaryrefslogtreecommitdiff
path: root/basctl
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2015-08-12 15:09:22 +0200
committerNoel Grandin <noel@peralex.com>2015-08-14 10:52:46 +0200
commit9045d0bf35c9b4d5f6d8f791017124341abf8d4f (patch)
tree04c28c25dbabe5a9b1e2bb137abedcbdea6e31d9 /basctl
parent6d4f97b05b1bfe5aae395134b2dc35805c23b8c4 (diff)
loplugin: defaultparams
Change-Id: I89796134a0cce33279ba7f02492857a656e8aee3
Diffstat (limited to 'basctl')
-rw-r--r--basctl/source/basicide/basicbox.cxx4
-rw-r--r--basctl/source/basicide/baside2.cxx6
-rw-r--r--basctl/source/basicide/baside2b.cxx20
-rw-r--r--basctl/source/basicide/basides1.cxx4
-rw-r--r--basctl/source/basicide/basidesh.cxx6
-rw-r--r--basctl/source/basicide/bastype2.cxx2
-rw-r--r--basctl/source/basicide/bastypes.cxx4
-rw-r--r--basctl/source/basicide/brkdlg.cxx4
-rw-r--r--basctl/source/basicide/moduldl2.cxx2
-rw-r--r--basctl/source/dlged/dlged.cxx6
-rw-r--r--basctl/source/dlged/dlgedfunc.cxx6
-rw-r--r--basctl/source/dlged/dlgedobj.cxx20
12 files changed, 42 insertions, 42 deletions
diff --git a/basctl/source/basicide/basicbox.cxx b/basctl/source/basicide/basicbox.cxx
index 4e3982f0eecb..4bb502f8ba5e 100644
--- a/basctl/source/basicide/basicbox.cxx
+++ b/basctl/source/basicide/basicbox.cxx
@@ -202,7 +202,7 @@ void LibBox::FillBox()
ClearBox();
// create list box entries
- sal_Int32 nPos = InsertEntry( OUString( IDEResId( RID_STR_ALL ) ), LISTBOX_APPEND );
+ sal_Int32 nPos = InsertEntry( OUString( IDEResId( RID_STR_ALL ) ) );
SetEntryData( nPos, new LibEntry( ScriptDocument::getApplicationScriptDocument(), LIBRARY_LOCATION_UNKNOWN, OUString() ) );
InsertEntries( ScriptDocument::getApplicationScriptDocument(), LIBRARY_LOCATION_USER );
InsertEntries( ScriptDocument::getApplicationScriptDocument(), LIBRARY_LOCATION_SHARE );
@@ -241,7 +241,7 @@ void LibBox::InsertEntries( const ScriptDocument& rDocument, LibraryLocation eLo
{
OUString aName( rDocument.getTitle( eLocation ) );
OUString aEntryText( CreateMgrAndLibStr( aName, aLibName ) );
- sal_Int32 nPos = InsertEntry( aEntryText, LISTBOX_APPEND );
+ sal_Int32 nPos = InsertEntry( aEntryText );
SetEntryData( nPos, new LibEntry( rDocument, eLocation, aLibName ) );
}
}
diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index dbdc329475f6..88a2d64fb451 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -750,7 +750,7 @@ void ModulWindow::EditMacro( const OUString& rMacroName )
long nNewStartY = (long)nStart * (long)pView->GetTextEngine()->GetCharHeight();
nNewStartY = std::min( nNewStartY, nMaxY );
pView->Scroll( 0, -(nNewStartY-nOldStartY) );
- pView->ShowCursor( false, true );
+ pView->ShowCursor( false );
GetEditVScrollBar().SetThumbPos( pView->GetStartDocPos().Y() );
}
pView->SetSelection( aSel );
@@ -802,7 +802,7 @@ void ModulWindow::UpdateData()
sal_Int32 ModulWindow::countPages( Printer* pPrinter )
{
- return FormatAndPrint( pPrinter, -1 );
+ return FormatAndPrint( pPrinter );
}
void ModulWindow::printPage( sal_Int32 nPage, Printer* pPrinter )
@@ -1168,7 +1168,7 @@ void ModulWindow::DoScroll( ScrollBar* pCurScrollBar )
// don't scroll with the value but rather use the Thumb-Pos for the VisArea:
long nDiff = GetEditView()->GetStartDocPos().X() - pCurScrollBar->GetThumbPos();
GetEditView()->Scroll( nDiff, 0 );
- GetEditView()->ShowCursor( false, true );
+ GetEditView()->ShowCursor( false );
pCurScrollBar->SetThumbPos( GetEditView()->GetStartDocPos().X() );
}
diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx
index 0a4277ff128a..f19f827f4263 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -1004,7 +1004,7 @@ void EditorWindow::CreateEditEngine()
pEditEngine->SetUpdateMode(true);
rModulWindow.Update(); // has only been invalidated at UpdateMode = true
- pEditView->ShowCursor(true, true);
+ pEditView->ShowCursor(true);
StartListening(*pEditEngine);
@@ -1205,7 +1205,7 @@ void EditorWindow::ImpDoHighlight( sal_uLong nLine )
{
OUString aLine( pEditEngine->GetText( nLine ) );
bool const bWasModified = pEditEngine->IsModified();
- pEditEngine->RemoveAttribs( nLine, true );
+ pEditEngine->RemoveAttribs( nLine );
std::vector<HighlightPortion> aPortions;
aHighlighter.getHighlightPortions( aLine, aPortions );
@@ -1213,7 +1213,7 @@ void EditorWindow::ImpDoHighlight( sal_uLong nLine )
i != aPortions.end(); ++i)
{
Color const aColor = rModulWindow.GetLayout().GetSyntaxColor(i->tokenType);
- pEditEngine->SetAttrib(TextAttribFontColor(aColor), nLine, i->nBegin, i->nEnd, true);
+ pEditEngine->SetAttrib(TextAttribFontColor(aColor), nLine, i->nBegin, i->nEnd);
}
pEditEngine->SetModified(bWasModified);
@@ -1303,7 +1303,7 @@ IMPL_LINK_NOARG_TYPED(EditorWindow, SyntaxTimerHdl, Idle *, void)
// #i45572#
if ( pEditView )
- pEditView->ShowCursor( false, true );
+ pEditView->ShowCursor( false );
pEditEngine->SetModified( bWasModified );
@@ -1754,7 +1754,7 @@ void WatchWindow::AddWatch( const OUString& rVName )
SvTreeListEntry* pNewEntry = aTreeListBox->InsertEntry( aWatchStr_, 0, true, TREELIST_APPEND );
pNewEntry->SetUserData( pWatchItem );
- aTreeListBox->Select(pNewEntry, true);
+ aTreeListBox->Select(pNewEntry);
aTreeListBox->MakeVisible(pNewEntry);
aRemoveWatchButton->Enable();
@@ -2065,7 +2065,7 @@ IMPL_LINK(ComplexEditorWindow, ScrollHdl, ScrollBar *, pCurScrollBar )
aEdtWindow->GetEditView()->Scroll( 0, nDiff );
aBrkWindow->DoScroll( 0, nDiff );
aLineNumberWindow->DoScroll(0, nDiff);
- aEdtWindow->GetEditView()->ShowCursor(false, true);
+ aEdtWindow->GetEditView()->ShowCursor(false);
pCurScrollBar->SetThumbPos( aEdtWindow->GetEditView()->GetStartDocPos().Y() );
}
@@ -2675,14 +2675,14 @@ void CodeCompleteListBox::InsertSelectedEntry()
if( !GetSelectEntry().isEmpty() )
{//if the user selected something
- GetParentEditView()->InsertText( GetSelectEntry(), false );
+ GetParentEditView()->InsertText( GetSelectEntry() );
}
}
else
{
if( !GetSelectEntry().isEmpty() )
{//if the user selected something
- GetParentEditView()->InsertText( GetSelectEntry(), false );
+ GetParentEditView()->InsertText( GetSelectEntry() );
}
}
HideAndRestoreFocus();
@@ -2763,7 +2763,7 @@ void CodeCompleteListBox::KeyInput( const KeyEvent& rKeyEvt )
GetParentEditView()->SetSelection( aTextSelection );
GetParentEditView()->DeleteSelected();
- GetParentEditView()->InsertText( GetSelectEntry(), false );
+ GetParentEditView()->InsertText( GetSelectEntry() );
}
}
break;
@@ -2860,7 +2860,7 @@ void CodeCompleteWindow::ResizeAndPositionListBox()
if( pListBox->GetEntryCount() >= 1 )
{// if there is at least one element inside
// calculate basic position: under the current line
- Rectangle aRect = static_cast<TextEngine*>(pParent->GetEditEngine())->PaMtoEditCursor( pParent->GetEditView()->GetSelection().GetEnd() , false );
+ Rectangle aRect = static_cast<TextEngine*>(pParent->GetEditEngine())->PaMtoEditCursor( pParent->GetEditView()->GetSelection().GetEnd() );
long nViewYOffset = pParent->GetEditView()->GetStartDocPos().Y();
Point aPos = aRect.BottomRight();// this variable will be used later (if needed)
aPos.Y() = (aPos.Y() - nViewYOffset) + nBasePad;
diff --git a/basctl/source/basicide/basides1.cxx b/basctl/source/basicide/basides1.cxx
index 1b8962ee206e..bcaa2a976a79 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -461,7 +461,7 @@ void Shell::ExecuteGlobal( SfxRequest& rReq )
{
// adjust old value...
if (SfxBindings* pBindings = GetBindingsPtr())
- pBindings->Invalidate(SID_BASICIDE_LIBSELECTOR, true, false);
+ pBindings->Invalidate(SID_BASICIDE_LIBSELECTOR, true);
}
}
else if ( nSlot == SID_BASICIDE_LIBREMOVED )
@@ -639,7 +639,7 @@ void Shell::ExecuteGlobal( SfxRequest& rReq )
long nNewY = nLine * pTextEngine->GetCharHeight() - nVisHeight / 2;
nNewY = ::std::min( nNewY, nMaxY );
pTextView->Scroll( 0, -( nNewY - nOldY ) );
- pTextView->ShowCursor( false, true );
+ pTextView->ShowCursor( false );
pModWin->GetEditVScrollBar().SetThumbPos( pTextView->GetStartDocPos().Y() );
}
sal_uInt16 nCol1 = 0, nCol2 = 0;
diff --git a/basctl/source/basicide/basidesh.cxx b/basctl/source/basicide/basidesh.cxx
index 834979a8cba4..a0c26a0f5a25 100644
--- a/basctl/source/basicide/basidesh.cxx
+++ b/basctl/source/basicide/basidesh.cxx
@@ -110,7 +110,7 @@ public:
{
OUString sModuleName;
if( mpShell && ( Event.Accessor >>= sModuleName ) )
- mpShell->FindBasWin( mpShell->m_aCurDocument, mpShell->m_aCurLibName, sModuleName, true, false );
+ mpShell->FindBasWin( mpShell->m_aCurDocument, mpShell->m_aCurLibName, sModuleName, true );
}
virtual void SAL_CALL elementReplaced( const container::ContainerEvent& ) throw( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE { }
virtual void SAL_CALL elementRemoved( const container::ContainerEvent& Event ) throw( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE
@@ -120,7 +120,7 @@ public:
{
VclPtr<ModulWindow> pWin = mpShell->FindBasWin(mpShell->m_aCurDocument, mpShell->m_aCurLibName, sModuleName, false, true);
if( pWin )
- mpShell->RemoveWindow( pWin, true, true );
+ mpShell->RemoveWindow( pWin, true );
}
}
@@ -345,7 +345,7 @@ void Shell::onDocumentClosed( const ScriptDocument& _rDocument )
void Shell::onDocumentTitleChanged( const ScriptDocument& /*_rDocument*/ )
{
if (SfxBindings* pBindings = GetBindingsPtr())
- pBindings->Invalidate( SID_BASICIDE_LIBSELECTOR, true, false );
+ pBindings->Invalidate( SID_BASICIDE_LIBSELECTOR, true );
SetMDITitle();
}
diff --git a/basctl/source/basicide/bastype2.cxx b/basctl/source/basicide/bastype2.cxx
index de255910e212..eeee9c3ad5a2 100644
--- a/basctl/source/basicide/bastype2.cxx
+++ b/basctl/source/basicide/bastype2.cxx
@@ -807,7 +807,7 @@ void TreeListBox::GetRootEntryBitmaps( const ScriptDocument& rDocument, Image& r
if ( !sFactoryURL.isEmpty() )
{
- rImage = SvFileInformationManager::GetFileImage( INetURLObject( sFactoryURL ), false );
+ rImage = SvFileInformationManager::GetFileImage( INetURLObject( sFactoryURL ) );
}
else
{
diff --git a/basctl/source/basicide/bastypes.cxx b/basctl/source/basicide/bastypes.cxx
index a30deba60ca7..72e45addbaf3 100644
--- a/basctl/source/basicide/bastypes.cxx
+++ b/basctl/source/basicide/bastypes.cxx
@@ -363,7 +363,7 @@ void DockingWindow::EndDocking( const Rectangle& rRect, bool bFloatMode )
::DockingWindow::EndDocking( rRect, bFloatMode );
else
{
- SetFloatingMode(false);
+ SetFloatingMode();
DockThis();
}
}
@@ -466,7 +466,7 @@ IMPL_LINK( ExtendedEdit, EditAccHdl, Accelerator *, pAcc )
TabBar::TabBar( vcl::Window* pParent ) :
::TabBar( pParent, WinBits( WB_3DLOOK | WB_SCROLL | WB_BORDER | WB_SIZEABLE | WB_DRAG ) )
{
- EnableEditMode(true);
+ EnableEditMode();
SetHelpId( HID_BASICIDE_TABBAR );
}
diff --git a/basctl/source/basicide/brkdlg.cxx b/basctl/source/basicide/brkdlg.cxx
index 4c50b69160d7..084d15eb8f51 100644
--- a/basctl/source/basicide/brkdlg.cxx
+++ b/basctl/source/basicide/brkdlg.cxx
@@ -81,7 +81,7 @@ BreakPointDialog::BreakPointDialog( vcl::Window* pParent, BreakPointList& rBrkPn
{
BreakPoint* pBrk = m_aModifiedBreakPointList.at( i );
OUString aEntryStr( "# " + OUString::number(pBrk->nLine) );
- m_pComboBox->InsertEntry( aEntryStr, COMBOBOX_APPEND );
+ m_pComboBox->InsertEntry( aEntryStr );
}
m_pComboBox->SetUpdateMode(true);
@@ -210,7 +210,7 @@ IMPL_LINK( BreakPointDialog, ButtonHdl, Button *, pButton )
pBrk->nStopAfter = (size_t) m_pNumericField->GetValue();
m_aModifiedBreakPointList.InsertSorted( pBrk );
OUString aEntryStr( "# " + OUString::number(pBrk->nLine) );
- m_pComboBox->InsertEntry( aEntryStr, COMBOBOX_APPEND );
+ m_pComboBox->InsertEntry( aEntryStr );
if (SfxDispatcher* pDispatcher = GetDispatcher())
pDispatcher->Execute( SID_BASICIDE_BRKPNTSCHANGED );
}
diff --git a/basctl/source/basicide/moduldl2.cxx b/basctl/source/basicide/moduldl2.cxx
index ae4d83dd9531..ad49d7ab737e 100644
--- a/basctl/source/basicide/moduldl2.cxx
+++ b/basctl/source/basicide/moduldl2.cxx
@@ -1403,7 +1403,7 @@ void LibPage::FillListBox()
void LibPage::InsertListBoxEntry( const ScriptDocument& rDocument, LibraryLocation eLocation )
{
OUString aEntryText( rDocument.getTitle( eLocation ) );
- sal_uInt16 nPos = m_pBasicsBox->InsertEntry( aEntryText, LISTBOX_APPEND );
+ sal_uInt16 nPos = m_pBasicsBox->InsertEntry( aEntryText );
m_pBasicsBox->SetEntryData( nPos, new DocumentEntry(rDocument, eLocation) );
}
diff --git a/basctl/source/dlged/dlged.cxx b/basctl/source/dlged/dlged.cxx
index 56c42c930f94..47f244417cef 100644
--- a/basctl/source/dlged/dlged.cxx
+++ b/basctl/source/dlged/dlged.cxx
@@ -237,7 +237,7 @@ DlgEditor::DlgEditor (
pDlgEdView->SetGridVisible( bGridVisible );
pDlgEdView->SetDragStripes(false);
- pDlgEdView->SetDesignMode(true);
+ pDlgEdView->SetDesignMode();
::comphelper::disposeComponent( m_xControlContainer );
@@ -523,7 +523,7 @@ void DlgEditor::Paint(vcl::RenderContext& rRenderContext, const Rectangle& rRect
pDlgEdForm->SetSnapRect( Rectangle( aPos, aSize ) );
pDlgEdForm->EndListening(false);
pDlgEdForm->SetPropsFromRect();
- pDlgEdForm->GetDlgEditor().SetDialogModelChanged(true);
+ pDlgEdForm->GetDlgEditor().SetDialogModelChanged();
pDlgEdForm->StartListening();
// set position and size of controls
@@ -991,7 +991,7 @@ void DlgEditor::Paste()
pDlgEdView->MarkListHasChanged();
// dialog model changed
- SetDialogModelChanged(true);
+ SetDialogModelChanged();
}
}
}
diff --git a/basctl/source/dlged/dlgedfunc.cxx b/basctl/source/dlged/dlgedfunc.cxx
index 7e31ae7c9f32..3ebe2f8ee91d 100644
--- a/basctl/source/dlged/dlgedfunc.cxx
+++ b/basctl/source/dlged/dlgedfunc.cxx
@@ -278,7 +278,7 @@ bool DlgEdFunc::KeyInput( const KeyEvent& rKEvt )
// switch snapping off
if ( !bWasNoSnap )
- const_cast<SdrDragStat&>(rDragStat).SetNoSnap(true);
+ const_cast<SdrDragStat&>(rDragStat).SetNoSnap();
if ( bWasSnapEnabled )
rView.SetSnapEnabled(false);
@@ -334,12 +334,12 @@ bool DlgEdFunc::KeyInput( const KeyEvent& rKEvt )
DlgEdFuncInsert::DlgEdFuncInsert (DlgEditor& rParent_) :
DlgEdFunc(rParent_)
{
- rParent.GetView().SetCreateMode(true);
+ rParent.GetView().SetCreateMode();
}
DlgEdFuncInsert::~DlgEdFuncInsert()
{
- rParent.GetView().SetEditMode( true );
+ rParent.GetView().SetEditMode();
}
bool DlgEdFuncInsert::MouseButtonDown( const MouseEvent& rMEvt )
diff --git a/basctl/source/dlged/dlgedobj.cxx b/basctl/source/dlged/dlgedobj.cxx
index 5aae79bd061d..f43879cc469e 100644
--- a/basctl/source/dlged/dlgedobj.cxx
+++ b/basctl/source/dlged/dlgedobj.cxx
@@ -940,7 +940,7 @@ void DlgEdObj::NbcMove( const Size& rSize )
StartListening();
// dialog model changed
- GetDlgEdForm()->GetDlgEditor().SetDialogModelChanged(true);
+ GetDlgEdForm()->GetDlgEditor().SetDialogModelChanged();
}
void DlgEdObj::NbcResize(const Point& rRef, const Fraction& xFract, const Fraction& yFract)
@@ -957,7 +957,7 @@ void DlgEdObj::NbcResize(const Point& rRef, const Fraction& xFract, const Fracti
StartListening();
// dialog model changed
- GetDlgEdForm()->GetDlgEditor().SetDialogModelChanged(true);
+ GetDlgEdForm()->GetDlgEditor().SetDialogModelChanged();
}
bool DlgEdObj::EndCreate(SdrDragStat& rStat, SdrCreateCmd eCmd)
@@ -1049,7 +1049,7 @@ void DlgEdObj::SetDefaults()
}
// dialog model changed
- pDlgEdForm->GetDlgEditor().SetDialogModelChanged(true);
+ pDlgEdForm->GetDlgEditor().SetDialogModelChanged();
}
}
@@ -1138,7 +1138,7 @@ void SAL_CALL DlgEdObj::_propertyChange( const css::beans::PropertyChangeEvent&
return;
// dialog model changed
- rDlgEditor.SetDialogModelChanged(true);
+ rDlgEditor.SetDialogModelChanged();
// update position and size
if ( evt.PropertyName == DLGED_PROP_POSITIONX || evt.PropertyName == DLGED_PROP_POSITIONY ||
@@ -1185,7 +1185,7 @@ void SAL_CALL DlgEdObj::_elementInserted(const css::container::ContainerEvent& )
if (isListening())
{
// dialog model changed
- GetDialogEditor().SetDialogModelChanged(true);
+ GetDialogEditor().SetDialogModelChanged();
}
}
@@ -1194,7 +1194,7 @@ void SAL_CALL DlgEdObj::_elementReplaced(const css::container::ContainerEvent& )
if (isListening())
{
// dialog model changed
- GetDialogEditor().SetDialogModelChanged(true);
+ GetDialogEditor().SetDialogModelChanged();
}
}
@@ -1203,7 +1203,7 @@ void SAL_CALL DlgEdObj::_elementRemoved(const css::container::ContainerEvent& )
if (isListening())
{
// dialog model changed
- GetDialogEditor().SetDialogModelChanged(true);
+ GetDialogEditor().SetDialogModelChanged();
}
}
@@ -1600,7 +1600,7 @@ void DlgEdForm::NbcMove( const Size& rSize )
}
// dialog model changed
- GetDlgEditor().SetDialogModelChanged(true);
+ GetDlgEditor().SetDialogModelChanged();
}
void DlgEdForm::NbcResize(const Point& rRef, const Fraction& xFract, const Fraction& yFract)
@@ -1622,7 +1622,7 @@ void DlgEdForm::NbcResize(const Point& rRef, const Fraction& xFract, const Fract
}
// dialog model changed
- GetDlgEditor().SetDialogModelChanged(true);
+ GetDlgEditor().SetDialogModelChanged();
}
bool DlgEdForm::EndCreate(SdrDragStat& rStat, SdrCreateCmd eCmd)
@@ -1636,7 +1636,7 @@ bool DlgEdForm::EndCreate(SdrDragStat& rStat, SdrCreateCmd eCmd)
SetPropsFromRect();
// dialog model changed
- GetDlgEditor().SetDialogModelChanged(true);
+ GetDlgEditor().SetDialogModelChanged();
// start listening
StartListening();