diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-16 15:23:12 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-17 08:25:47 +0200 |
| commit | ccb2a1f650bc505f8a4f1abebf8ce4f9396562a8 (patch) | |
| tree | 2ee2fd4f300ae95cf23bade1f242e02f9b276c07 /basctl | |
| parent | da5c3a1ee43dd1a07cbd1b8005488bf05432593d (diff) | |
clang-tidy readability-redundant-smartptr-get
redundant get() call on smart pointer
Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd
Reviewed-on: https://gerrit.libreoffice.org/61837
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basctl')
| -rw-r--r-- | basctl/source/basicide/basides1.cxx | 4 | ||||
| -rw-r--r-- | basctl/source/basicide/scriptdocument.cxx | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/basctl/source/basicide/basides1.cxx b/basctl/source/basicide/basides1.cxx index 9cef7bdd41ec..007269ec71ad 100644 --- a/basctl/source/basicide/basides1.cxx +++ b/basctl/source/basicide/basides1.cxx @@ -631,14 +631,14 @@ void Shell::ExecuteGlobal( SfxRequest& rReq ) } const SfxUnoAnyItem* pDocModelItem = rReq.GetArg<SfxUnoAnyItem>(SID_BASICIDE_ARG_DOCUMENT_MODEL); - if ( !pDocument.get() && pDocModelItem ) + if (!pDocument && pDocModelItem) { uno::Reference< frame::XModel > xModel( pDocModelItem->GetValue(), UNO_QUERY ); if ( xModel.is() ) pDocument.reset( new ScriptDocument( xModel ) ); } - if ( !pDocument.get() ) + if (!pDocument) break; const SfxStringItem* pLibNameItem = rReq.GetArg<SfxStringItem>(SID_BASICIDE_ARG_LIBNAME); diff --git a/basctl/source/basicide/scriptdocument.cxx b/basctl/source/basicide/scriptdocument.cxx index 9a2a040a3a5d..ac990c66890d 100644 --- a/basctl/source/basicide/scriptdocument.cxx +++ b/basctl/source/basicide/scriptdocument.cxx @@ -302,7 +302,7 @@ namespace basctl m_xDocModify.clear(); m_xScriptAccess.clear(); - if ( m_pDocListener.get() ) + if (m_pDocListener) m_pDocListener->dispose(); } |