loplugin:constantparam

Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5

9 files changed, 23 insertions, 24 deletions

diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx
index 996579a34aa8..513f03236623 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -191,7 +191,7 @@ public:
     void            SetMarkerPos( sal_uInt16 nLine, bool bErrorMarker = false );
     void            SetNoMarker ();
 
-    void            DoScroll( long nHorzScroll, long nVertScroll );
+    void            DoScroll( long nVertScroll );
     long&           GetCurYOffset()         { return nCurYOffset; }
     BreakPointList& GetBreakPoints()        { return aBreakPointList; }
 };
diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx
index 73354e175569..68f2767e359e 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -1075,9 +1075,9 @@ void EditorWindow::Notify( SfxBroadcaster& /*rBC*/, const SfxHint& rHint )
                 rModulWindow.GetHScrollBar()->SetThumbPos( pEditView->GetStartDocPos().X() );
             rModulWindow.GetEditVScrollBar().SetThumbPos( pEditView->GetStartDocPos().Y() );
             rModulWindow.GetBreakPointWindow().DoScroll
-                ( 0, rModulWindow.GetBreakPointWindow().GetCurYOffset() - pEditView->GetStartDocPos().Y() );
+                ( rModulWindow.GetBreakPointWindow().GetCurYOffset() - pEditView->GetStartDocPos().Y() );
             rModulWindow.GetLineNumberWindow().DoScroll
-                ( 0, rModulWindow.GetLineNumberWindow().GetCurYOffset() - pEditView->GetStartDocPos().Y() );
+                ( rModulWindow.GetLineNumberWindow().GetCurYOffset() - pEditView->GetStartDocPos().Y() );
         }
         else if( rTextHint.GetId() == TEXT_HINT_TEXTHEIGHTCHANGED )
         {
@@ -1416,10 +1416,10 @@ void BreakPointWindow::ShowMarker(vcl::RenderContext& rRenderContext)
     rRenderContext.DrawImage(aPos, aMarker);
 }
 
-void BreakPointWindow::DoScroll( long nHorzScroll, long nVertScroll )
+void BreakPointWindow::DoScroll( long nVertScroll )
 {
     nCurYOffset -= nVertScroll;
-    Window::Scroll( nHorzScroll, nVertScroll );
+    Window::Scroll( 0, nVertScroll );
 }
 
 void BreakPointWindow::SetMarkerPos( sal_uInt16 nLine, bool bError )
@@ -2040,8 +2040,8 @@ IMPL_LINK_TYPED(ComplexEditorWindow, ScrollHdl, ScrollBar *, pCurScrollBar, void
         DBG_ASSERT( pCurScrollBar == aEWVScrollBar.get(), "Wer scrollt hier ?" );
         long nDiff = aEdtWindow->GetEditView()->GetStartDocPos().Y() - pCurScrollBar->GetThumbPos();
         aEdtWindow->GetEditView()->Scroll( 0, nDiff );
-        aBrkWindow->DoScroll( 0, nDiff );
-        aLineNumberWindow->DoScroll(0, nDiff);
+        aBrkWindow->DoScroll( nDiff );
+        aLineNumberWindow->DoScroll( nDiff );
         aEdtWindow->GetEditView()->ShowCursor(false);
         pCurScrollBar->SetThumbPos( aEdtWindow->GetEditView()->GetStartDocPos().Y() );
     }
diff --git a/basctl/source/basicide/baside3.cxx b/basctl/source/basicide/baside3.cxx
index af1421648ff3..a8b08986ddc8 100644
--- a/basctl/source/basicide/baside3.cxx
+++ b/basctl/source/basicide/baside3.cxx
@@ -80,7 +80,7 @@ DialogWindow::DialogWindow(DialogWindowLayout* pParent, ScriptDocument const& rD
                                             : Reference<frame::XModel>(), xDialogModel))
     ,pUndoMgr(new SfxUndoManager)
 {
-    InitSettings( true );
+    InitSettings();
 
     pEditor->GetModel().SetNotifyUndoActionHdl(
         LINK(this, DialogWindow, NotifyUndoActionHdl)
@@ -1325,14 +1325,14 @@ void DialogWindow::DataChanged( const DataChangedEvent& rDCEvt )
 {
     if( (rDCEvt.GetType()==DataChangedEventType::SETTINGS) && (rDCEvt.GetFlags() & AllSettingsFlags::STYLE) )
     {
-        InitSettings( true );
+        InitSettings();
         Invalidate();
     }
     else
         BaseWindow::DataChanged( rDCEvt );
 }
 
-void DialogWindow::InitSettings(bool bBackground)
+void DialogWindow::InitSettings()
 {
     // FIXME RenderContext
     const StyleSettings& rStyleSettings = GetSettings().GetStyleSettings();
@@ -1343,8 +1343,7 @@ void DialogWindow::InitSettings(bool bBackground)
     SetTextColor( rStyleSettings.GetFieldTextColor() );
     SetTextFillColor();
 
-    if( bBackground )
-        SetBackground( rStyleSettings.GetFieldColor() );
+    SetBackground( rStyleSettings.GetFieldColor() );
 }
 
 css::uno::Reference< css::accessibility::XAccessible > DialogWindow::CreateAccessible()
diff --git a/basctl/source/basicide/linenumberwindow.cxx b/basctl/source/basicide/linenumberwindow.cxx
index 298f4d02bf6a..2030c8734d02 100644
--- a/basctl/source/basicide/linenumberwindow.cxx
+++ b/basctl/source/basicide/linenumberwindow.cxx
@@ -99,10 +99,10 @@ void LineNumberWindow::DataChanged(DataChangedEvent const & rDCEvt)
     }
 }
 
-void LineNumberWindow::DoScroll(long nHorzScroll, long nVertScroll)
+void LineNumberWindow::DoScroll(long nVertScroll)
 {
     m_nCurYOffset -= nVertScroll;
-    Window::Scroll(nHorzScroll, nVertScroll);
+    Window::Scroll(0, nVertScroll);
 }
 
 
diff --git a/basctl/source/basicide/linenumberwindow.hxx b/basctl/source/basicide/linenumberwindow.hxx
index 3c1bd61acd95..0e7673c5a1e4 100644
--- a/basctl/source/basicide/linenumberwindow.hxx
+++ b/basctl/source/basicide/linenumberwindow.hxx
@@ -33,7 +33,7 @@ public:
     virtual ~LineNumberWindow();
     virtual void dispose() override;
 
-    void DoScroll( long nHorzScroll, long nVertScroll );
+    void DoScroll( long nVertScroll );
 
     bool SyncYOffset();
     long& GetCurYOffset() { return m_nCurYOffset;}
diff --git a/basctl/source/basicide/moduldl2.cxx b/basctl/source/basicide/moduldl2.cxx
index 64e45e22f6cf..2fcb303561f4 100644
--- a/basctl/source/basicide/moduldl2.cxx
+++ b/basctl/source/basicide/moduldl2.cxx
@@ -633,7 +633,7 @@ IMPL_LINK_TYPED( LibPage, ButtonHdl, Button *, pButton, void )
         if (SfxDispatcher* pDispatcher = GetDispatcher())
             pDispatcher->Execute( SID_BASICIDE_LIBSELECTED,
                                     SfxCallMode::ASYNCHRON, &aDocItem, &aLibNameItem, 0 );
-        EndTabDialog( 1 );
+        EndTabDialog();
         return;
     }
     else if (pButton == m_pNewLibButton)
@@ -1369,11 +1369,11 @@ void LibPage::DeleteCurrent()
     }
 }
 
-void LibPage::EndTabDialog( sal_uInt16 nRet )
+void LibPage::EndTabDialog()
 {
     DBG_ASSERT( pTabDlg, "TabDlg nicht gesetzt!" );
     if ( pTabDlg )
-        pTabDlg->EndDialog( nRet );
+        pTabDlg->EndDialog( 1 );
 }
 
 void LibPage::FillListBox()
diff --git a/basctl/source/basicide/moduldlg.cxx b/basctl/source/basicide/moduldlg.cxx
index 1285300f9ac5..c63e885c85de 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -739,7 +739,7 @@ IMPL_LINK_TYPED( ObjectPage, ButtonHdl, Button *, pButton, void )
                 pDispatcher->Execute( SID_BASICIDE_LIBSELECTED, SfxCallMode::ASYNCHRON, &aDocItem, &aLibNameItem, 0 );
             }
         }
-        EndTabDialog( 1 );
+        EndTabDialog();
     }
     else if (pButton == m_pNewModButton)
         NewModule();
@@ -919,11 +919,11 @@ void ObjectPage::DeleteCurrent()
 }
 
 
-void ObjectPage::EndTabDialog( sal_uInt16 nRet )
+void ObjectPage::EndTabDialog()
 {
     DBG_ASSERT( pTabDlg, "TabDlg nicht gesetzt!" );
     if ( pTabDlg )
-        pTabDlg->EndDialog( nRet );
+        pTabDlg->EndDialog( 1 );
 }
 
 LibDialog::LibDialog( vcl::Window* pParent )
diff --git a/basctl/source/basicide/moduldlg.hxx b/basctl/source/basicide/moduldlg.hxx
index 958509b80ed7..d3cc32b74012 100644
--- a/basctl/source/basicide/moduldlg.hxx
+++ b/basctl/source/basicide/moduldlg.hxx
@@ -197,7 +197,7 @@ protected:
     void                DeleteCurrent();
     void                NewModule();
     void                NewDialog();
-    void                EndTabDialog( sal_uInt16 nRet );
+    void                EndTabDialog();
 
     VclPtr<TabDialog>          pTabDlg;
 
@@ -242,7 +242,7 @@ protected:
     void                Export();
     void                ExportAsPackage( const OUString& aLibName );
     void                ExportAsBasic( const OUString& aLibName );
-    void                EndTabDialog( sal_uInt16 nRet );
+    void                EndTabDialog();
     void                FillListBox();
     void                InsertListBoxEntry( const ScriptDocument& rDocument, LibraryLocation eLocation );
     void                SetCurLib();
diff --git a/basctl/source/inc/baside3.hxx b/basctl/source/inc/baside3.hxx
index e6696d4a7f81..64b34fc62a44 100644
--- a/basctl/source/inc/baside3.hxx
+++ b/basctl/source/inc/baside3.hxx
@@ -77,7 +77,7 @@ protected:
     virtual void        DoInit() override;
     virtual void        DoScroll( ScrollBar* pCurScrollBar ) override;
     virtual void        DataChanged( const DataChangedEvent& rDCEvt ) override;
-    void                InitSettings(bool bBackground);
+    void                InitSettings();
 
 public:
     DialogWindow (DialogWindowLayout* pParent, ScriptDocument const& rDocument, const OUString& aLibName, const OUString& aName, css::uno::Reference<css::container::XNameContainer> const& xDialogModel);