loplugin:expandablemethodds in basctl..chart2

Change-Id: I96f565a974fe3e316ae2ab04f8731b8bbfb87993
Reviewed-on: https://gerrit.libreoffice.org/29998
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 3 insertions, 23 deletions

diff --git a/basctl/source/basicide/breakpoint.cxx b/basctl/source/basicide/breakpoint.cxx
index b3e6a70e1617..3396a198a772 100644
--- a/basctl/source/basicide/breakpoint.cxx
+++ b/basctl/source/basicide/breakpoint.cxx
@@ -49,10 +49,8 @@ void BreakPointList::reset()
 
 void BreakPointList::transfer(BreakPointList & rList)
 {
-    reset();
-    for (size_t i = 0; i < rList.size(); ++i)
-        maBreakPoints.push_back( rList.at( i ) );
-    rList.clear();
+    maBreakPoints.swap(rList.maBreakPoints);
+    rList.reset();
 }
 
 void BreakPointList::InsertSorted(BreakPoint* pNewBrk)
@@ -159,11 +157,6 @@ const BreakPoint* BreakPointList::at(size_t i) const
     return i < maBreakPoints.size() ? maBreakPoints[ i ] : nullptr;
 }
 
-void BreakPointList::clear()
-{
-    maBreakPoints.clear();
-}
-
 } // namespace basctl
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/basctl/source/basicide/breakpoint.hxx b/basctl/source/basicide/breakpoint.hxx
index 8431c3039af3..2ade823452bf 100644
--- a/basctl/source/basicide/breakpoint.hxx
+++ b/basctl/source/basicide/breakpoint.hxx
@@ -72,7 +72,6 @@ public:
     size_t size() const;
     BreakPoint* at(size_t i);
     const BreakPoint* at(size_t i) const;
-    void clear();
     BreakPoint* remove(BreakPoint* ptr);
 };
 
diff --git a/basctl/source/basicide/scriptdocument.cxx b/basctl/source/basicide/scriptdocument.cxx
index 17d928d5c0b2..a99fefafe8a3 100644
--- a/basctl/source/basicide/scriptdocument.cxx
+++ b/basctl/source/basicide/scriptdocument.cxx
@@ -1100,7 +1100,7 @@ namespace basctl
         {
             const ScriptDocument aCheck = ScriptDocument( doc->xModel );
             if  (   _rUrlOrCaption == aCheck.getTitle()
-                ||  _rUrlOrCaption == aCheck.getURL()
+                ||  _rUrlOrCaption == aCheck.m_pImpl->getURL()
                 )
             {
                 aDocument = aCheck;
@@ -1513,12 +1513,6 @@ namespace basctl
     }
 
 
-    OUString ScriptDocument::getURL() const
-    {
-        return m_pImpl->getURL();
-    }
-
-
     bool ScriptDocument::isActive() const
     {
         bool bIsActive( false );
diff --git a/basctl/source/inc/scriptdocument.hxx b/basctl/source/inc/scriptdocument.hxx
index 1a024367aafb..65467998b4b8 100644
--- a/basctl/source/inc/scriptdocument.hxx
+++ b/basctl/source/inc/scriptdocument.hxx
@@ -471,12 +471,6 @@ namespace basctl
         */
         OUString    getTitle() const;
 
-        /** returns the URL of the document
-
-            to be used for valid documents only
-        */
-        OUString    getURL() const;
-
         /** determines whether the document is currently the one-and-only application-wide active document
         */
         bool        isActive() const;