cid#1545233 sidestep COPY_INSTEAD_OF_MOVE

Change-Id: I93b8225b7ae2fdb4ea5fc371ce278f00d3dec33f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157356
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

1 files changed, 7 insertions, 10 deletions

diff --git a/basegfx/source/polygon/b3dpolygontools.cxx b/basegfx/source/polygon/b3dpolygontools.cxx
index 3b3779d7460a..7c92f5ddcea5 100644
--- a/basegfx/source/polygon/b3dpolygontools.cxx
+++ b/basegfx/source/polygon/b3dpolygontools.cxx
@@ -173,7 +173,7 @@ namespace basegfx::utils
         void applyLineDashing(
             const B3DPolygon& rCandidate,
             const std::vector<double>& rDotDashArray,
-            std::function<void(const basegfx::B3DPolygon& rSnippet)> aLineTargetCallback,
+            const std::function<void(const basegfx::B3DPolygon& rSnippet)>& rLineTargetCallback,
             double fDotDashLength)
         {
             const sal_uInt32 nPointCount(rCandidate.count());
@@ -184,14 +184,11 @@ namespace basegfx::utils
                 fDotDashLength = std::accumulate(rDotDashArray.begin(), rDotDashArray.end(), 0.0);
             }
 
-            if(fTools::lessOrEqual(fDotDashLength, 0.0) || !aLineTargetCallback || !nPointCount)
+            if(fTools::lessOrEqual(fDotDashLength, 0.0) || !rLineTargetCallback || !nPointCount)
             {
                 // parameters make no sense, just add source to targets
-                if(aLineTargetCallback)
-                {
-                    aLineTargetCallback(rCandidate);
-                }
-
+                if (rLineTargetCallback)
+                    rLineTargetCallback(rCandidate);
                 return;
             }
 
@@ -259,7 +256,7 @@ namespace basegfx::utils
 
                             aSnippet.append(interpolate(aCurrentPoint, aNextPoint, fDotDashMovingLength / fEdgeLength));
 
-                            implHandleSnippet(aSnippet, aLineTargetCallback, aFirstLine, aLastLine);
+                            implHandleSnippet(aSnippet, rLineTargetCallback, aFirstLine, aLastLine);
 
                             aSnippet.clear();
                         }
@@ -294,13 +291,13 @@ namespace basegfx::utils
             {
                 if(bIsLine)
                 {
-                    implHandleSnippet(aSnippet, aLineTargetCallback, aFirstLine, aLastLine);
+                    implHandleSnippet(aSnippet, rLineTargetCallback, aFirstLine, aLastLine);
                 }
             }
 
             if(bIsClosed)
             {
-                implHandleFirstLast(aLineTargetCallback, aFirstLine, aLastLine);
+                implHandleFirstLast(rLineTargetCallback, aFirstLine, aLastLine);
             }
         }