clang-tidy:readability-redundant-member-init

Change-Id: Ibeff6e5cbc20ab86b1e9cb96292acb340849ede3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121149
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

14 files changed, 12 insertions, 52 deletions

diff --git a/basegfx/source/color/bcolormodifier.cxx b/basegfx/source/color/bcolormodifier.cxx
index 1002e607f6d2..8620a94fe2c7 100644
--- a/basegfx/source/color/bcolormodifier.cxx
+++ b/basegfx/source/color/bcolormodifier.cxx
@@ -148,8 +148,7 @@ namespace basegfx
     }
 
     BColorModifier_gamma::BColorModifier_gamma(double fValue)
-    :   BColorModifier(),
-        mfValue(fValue),
+    :   mfValue(fValue),
         mfInvValue(fValue),
         mbUseIt(!basegfx::fTools::equal(fValue, 1.0) && basegfx::fTools::more(fValue, 0.0) && basegfx::fTools::lessOrEqual(fValue, 10.0))
     {
@@ -195,8 +194,7 @@ namespace basegfx
     }
 
     BColorModifier_RGBLuminanceContrast::BColorModifier_RGBLuminanceContrast(double fRed, double fGreen, double fBlue, double fLuminance, double fContrast)
-    :   BColorModifier(),
-        mfRed(std::clamp(fRed, -1.0, 1.0)),
+    :   mfRed(std::clamp(fRed, -1.0, 1.0)),
         mfGreen(std::clamp(fGreen, -1.0, 1.0)),
         mfBlue(std::clamp(fBlue, -1.0, 1.0)),
         mfLuminance(std::clamp(fLuminance, -1.0, 1.0)),
diff --git a/basegfx/source/curve/b2dbeziertools.cxx b/basegfx/source/curve/b2dbeziertools.cxx
index c24ba4215a2e..8fd4c4b84c74 100644
--- a/basegfx/source/curve/b2dbeziertools.cxx
+++ b/basegfx/source/curve/b2dbeziertools.cxx
@@ -24,8 +24,7 @@
 namespace basegfx
 {
     B2DCubicBezierHelper::B2DCubicBezierHelper(const B2DCubicBezier& rBase, sal_uInt32 nDivisions)
-    :   maLengthArray(),
-        mnEdgeCount(0)
+    :   mnEdgeCount(0)
     {
         const bool bIsBezier(rBase.isBezier());
 
diff --git a/basegfx/source/matrix/b2dhommatrix.cxx b/basegfx/source/matrix/b2dhommatrix.cxx
index badda594c9de..f3d2622db27a 100644
--- a/basegfx/source/matrix/b2dhommatrix.cxx
+++ b/basegfx/source/matrix/b2dhommatrix.cxx
@@ -42,7 +42,6 @@ namespace basegfx
     B2DHomMatrix::~B2DHomMatrix() = default;
 
     B2DHomMatrix::B2DHomMatrix(double f_0x0, double f_0x1, double f_0x2, double f_1x0, double f_1x1, double f_1x2)
-        :   mpImpl() // identity
     {
         mpImpl->set(0, 0, f_0x0);
         mpImpl->set(0, 1, f_0x1);
diff --git a/basegfx/source/polygon/b2dpolygon.cxx b/basegfx/source/polygon/b2dpolygon.cxx
index 141982aef10b..2baa16225227 100644
--- a/basegfx/source/polygon/b2dpolygon.cxx
+++ b/basegfx/source/polygon/b2dpolygon.cxx
@@ -250,8 +250,7 @@ public:
     {}
 
     ControlVectorArray2D(const ControlVectorArray2D& rOriginal, sal_uInt32 nIndex, sal_uInt32 nCount)
-    :   maVector(),
-        mnUsedVectors(0)
+    :   mnUsedVectors(0)
     {
         ControlVectorPair2DVector::const_iterator aStart(rOriginal.maVector.begin());
         aStart += nIndex;
@@ -468,9 +467,6 @@ private:
 
 public:
     ImplBufferedData()
-    :   basegfx::SystemDependentDataHolder(),
-        mpDefaultSubdivision(),
-        mpB2DRange()
     {
     }
 
@@ -600,15 +596,11 @@ public:
 
     ImplB2DPolygon()
     :   maPoints(0),
-        mpControlVector(),
-        mpBufferedData(),
         mbIsClosed(false)
     {}
 
     ImplB2DPolygon(const ImplB2DPolygon& rToBeCopied)
     :   maPoints(rToBeCopied.maPoints),
-        mpControlVector(),
-        mpBufferedData(),
         mbIsClosed(rToBeCopied.mbIsClosed)
     {
         // complete initialization using copy
@@ -620,8 +612,6 @@ public:
 
     ImplB2DPolygon(const ImplB2DPolygon& rToBeCopied, sal_uInt32 nIndex, sal_uInt32 nCount)
     :   maPoints(rToBeCopied.maPoints, nIndex, nCount),
-        mpControlVector(),
-        mpBufferedData(),
         mbIsClosed(rToBeCopied.mbIsClosed)
     {
         // complete initialization using partly copy
@@ -1130,7 +1120,6 @@ namespace basegfx
     B2DPolygon::B2DPolygon() = default;
 
     B2DPolygon::B2DPolygon(std::initializer_list<basegfx::B2DPoint> aPoints)
-        : mpPolygon()
     {
         for (const basegfx::B2DPoint& rPoint : aPoints)
         {
diff --git a/basegfx/source/polygon/b2dpolypolygon.cxx b/basegfx/source/polygon/b2dpolypolygon.cxx
index 36c221eeb106..78b3b7085303 100644
--- a/basegfx/source/polygon/b2dpolypolygon.cxx
+++ b/basegfx/source/polygon/b2dpolypolygon.cxx
@@ -30,20 +30,16 @@ class ImplB2DPolyPolygon
 
 public:
     ImplB2DPolyPolygon()
-    :   maPolygons(),
-        mpSystemDependentDataHolder()
     {
     }
 
     explicit ImplB2DPolyPolygon(const ImplB2DPolyPolygon& rSource)
-    :   maPolygons(rSource.maPolygons),
-        mpSystemDependentDataHolder()
+    :   maPolygons(rSource.maPolygons)
     {
     }
 
     explicit ImplB2DPolyPolygon(const basegfx::B2DPolygon& rToBeCopied)
-    :   maPolygons(1,rToBeCopied),
-        mpSystemDependentDataHolder()
+    :   maPolygons(1,rToBeCopied)
     {
     }
 
diff --git a/basegfx/source/polygon/b2dtrapezoid.cxx b/basegfx/source/polygon/b2dtrapezoid.cxx
index 3a255c18a7a3..12dbd66fdf9e 100644
--- a/basegfx/source/polygon/b2dtrapezoid.cxx
+++ b/basegfx/source/polygon/b2dtrapezoid.cxx
@@ -482,9 +482,6 @@ namespace basegfx::trapezoidhelper
         public:
             explicit TrapezoidSubdivider(
                 const B2DPolyPolygon& rSourcePolyPolygon)
-            :   maTrDeEdgeEntries(),
-                maPoints(),
-                maNewPoints()
             {
                 B2DPolyPolygon aSource(rSourcePolyPolygon);
                 TrDeSimpleEdges aTrDeSimpleEdges;
diff --git a/basegfx/source/polygon/b3dpolygon.cxx b/basegfx/source/polygon/b3dpolygon.cxx
index 89c9c279eb75..364f9f8c0e1d 100644
--- a/basegfx/source/polygon/b3dpolygon.cxx
+++ b/basegfx/source/polygon/b3dpolygon.cxx
@@ -37,7 +37,6 @@ class CoordinateData3D
 
 public:
     CoordinateData3D()
-    :   maPoint()
     {
     }
 
@@ -251,8 +250,7 @@ public:
     }
 
     BColorArray(const BColorArray& rOriginal, sal_uInt32 nIndex, sal_uInt32 nCount)
-    :   maVector(),
-        mnUsedEntries(0)
+    :   mnUsedEntries(0)
     {
         BColorDataVector::const_iterator aStart(rOriginal.maVector.begin());
         aStart += nIndex;
@@ -393,8 +391,7 @@ public:
     }
 
     NormalsArray3D(const NormalsArray3D& rOriginal, sal_uInt32 nIndex, sal_uInt32 nCount)
-    :   maVector(),
-        mnUsedEntries(0)
+    :   mnUsedEntries(0)
     {
         NormalsData3DVector::const_iterator aStart(rOriginal.maVector.begin());
         aStart += nIndex;
@@ -542,8 +539,7 @@ public:
     }
 
     TextureCoordinate2D(const TextureCoordinate2D& rOriginal, sal_uInt32 nIndex, sal_uInt32 nCount)
-    :   maVector(),
-        mnUsedEntries(0)
+    :   mnUsedEntries(0)
     {
         TextureData2DVector::const_iterator aStart(rOriginal.maVector.begin());
         aStart += nIndex;
diff --git a/basegfx/source/polygon/b3dpolypolygon.cxx b/basegfx/source/polygon/b3dpolypolygon.cxx
index e391fc783848..97ed39c87718 100644
--- a/basegfx/source/polygon/b3dpolypolygon.cxx
+++ b/basegfx/source/polygon/b3dpolypolygon.cxx
@@ -31,7 +31,7 @@ class ImplB3DPolyPolygon
     PolygonVector                                   maPolygons;
 
 public:
-    ImplB3DPolyPolygon() : maPolygons()
+    ImplB3DPolyPolygon()
     {
     }
 
diff --git a/basegfx/source/range/b2dpolyrange.cxx b/basegfx/source/range/b2dpolyrange.cxx
index d7d0d61de061..beb506fc8e4d 100644
--- a/basegfx/source/range/b2dpolyrange.cxx
+++ b/basegfx/source/range/b2dpolyrange.cxx
@@ -31,10 +31,7 @@ namespace basegfx
     class ImplB2DPolyRange
     {
     public:
-        ImplB2DPolyRange() :
-            maBounds(),
-            maRanges(),
-            maOrient()
+        ImplB2DPolyRange()
         {}
 
         bool operator==(const ImplB2DPolyRange& rRHS) const
diff --git a/basegfx/source/range/b2drange.cxx b/basegfx/source/range/b2drange.cxx
index 55b545933d88..be025cc64b1d 100644
--- a/basegfx/source/range/b2drange.cxx
+++ b/basegfx/source/range/b2drange.cxx
@@ -23,9 +23,7 @@
 
 namespace basegfx
 {
-    B2DRange::B2DRange( const B2IRange& rRange ) :
-        maRangeX(),
-        maRangeY()
+    B2DRange::B2DRange( const B2IRange& rRange )
     {
         if( !rRange.isEmpty() )
         {
diff --git a/basegfx/source/range/b2drangeclipper.cxx b/basegfx/source/range/b2drangeclipper.cxx
index 5dc452728772..2920cda5ebd0 100644
--- a/basegfx/source/range/b2drangeclipper.cxx
+++ b/basegfx/source/range/b2drangeclipper.cxx
@@ -226,7 +226,6 @@ namespace basegfx
             ImplPolygon() :
                 mpLeadingRightEdge(nullptr),
                 mnIdx(-1),
-                maPoints(),
                 mbIsFinished(false)
             {
                 // completely ad-hoc. but what the hell.
diff --git a/basegfx/source/raster/rasterconvert3d.cxx b/basegfx/source/raster/rasterconvert3d.cxx
index 48a5c7bb518f..e998eb99381b 100644
--- a/basegfx/source/raster/rasterconvert3d.cxx
+++ b/basegfx/source/raster/rasterconvert3d.cxx
@@ -48,8 +48,6 @@ namespace basegfx
     }
 
     RasterConverter3D::RasterConverter3D()
-    :   InterpolatorProvider3D(),
-        maLineEntries()
     {}
 
     RasterConverter3D::~RasterConverter3D()
diff --git a/basegfx/source/tools/b2dclipstate.cxx b/basegfx/source/tools/b2dclipstate.cxx
index aa5f655ccbc7..7b8309e0de1c 100644
--- a/basegfx/source/tools/b2dclipstate.cxx
+++ b/basegfx/source/tools/b2dclipstate.cxx
@@ -36,15 +36,10 @@ namespace basegfx::utils
         enum Operation {UNION, INTERSECT, XOR, SUBTRACT};
 
         ImplB2DClipState() :
-            maPendingPolygons(),
-            maPendingRanges(),
-            maClipPoly(),
             mePendingOps(UNION)
         {}
 
         explicit ImplB2DClipState( const B2DPolyPolygon& rPoly ) :
-            maPendingPolygons(),
-            maPendingRanges(),
             maClipPoly(rPoly),
             mePendingOps(UNION)
         {}
diff --git a/basegfx/source/tools/systemdependentdata.cxx b/basegfx/source/tools/systemdependentdata.cxx
index e333ce473437..106124f57389 100644
--- a/basegfx/source/tools/systemdependentdata.cxx
+++ b/basegfx/source/tools/systemdependentdata.cxx
@@ -96,7 +96,6 @@ namespace basegfx
 namespace basegfx
 {
     SystemDependentDataHolder::SystemDependentDataHolder()
-    :   maSystemDependentReferences()
     {
     }