diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-23 16:45:23 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-25 13:51:24 +0100 |
| commit | 0f28c8612f4269cec95688b53d182c7c0169236d (patch) | |
| tree | d840fa85243c10376fc4fb60b4972c028953483a /basegfx | |
| parent | 8fd13c356d78fb72ba5dd288a495551f23e15363 (diff) | |
loplugin:unused-returns in basegfx..cppcanvas
Change-Id: I32dc8c92871c8349651d2f4204a332d387e6e1b2
Reviewed-on: https://gerrit.libreoffice.org/48428
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basegfx')
| -rw-r--r-- | basegfx/source/matrix/b3dhommatrix.cxx | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/basegfx/source/matrix/b3dhommatrix.cxx b/basegfx/source/matrix/b3dhommatrix.cxx index e6a2bd3b4f88..6cfd054992ec 100644 --- a/basegfx/source/matrix/b3dhommatrix.cxx +++ b/basegfx/source/matrix/b3dhommatrix.cxx @@ -85,7 +85,7 @@ namespace basegfx *mpImpl = Impl3DHomMatrix(); } - bool B3DHomMatrix::invert() + void B3DHomMatrix::invert() { Impl3DHomMatrix aWork(*mpImpl); std::unique_ptr<sal_uInt16[]> pIndex( new sal_uInt16[Impl3DHomMatrix_Base::getEdgeLength()] ); @@ -94,10 +94,7 @@ namespace basegfx if(aWork.ludcmp(pIndex.get(), nParity)) { mpImpl->doInvert(aWork, pIndex.get()); - return true; } - - return false; } double B3DHomMatrix::determinant() const @@ -376,15 +373,15 @@ namespace basegfx mpImpl->doMulMatrix(aOrientationMat); } - bool B3DHomMatrix::decompose(B3DTuple& rScale, B3DTuple& rTranslate, B3DTuple& rRotate, B3DTuple& rShear) const + void B3DHomMatrix::decompose(B3DTuple& rScale, B3DTuple& rTranslate, B3DTuple& rRotate, B3DTuple& rShear) const { // when perspective is used, decompose is not made here if(!mpImpl->isLastLineDefault()) - return false; + return; // If determinant is zero, decomposition is not possible if(determinant() == 0.0) - return false; + return; // isolate translation rTranslate.setX(mpImpl->get(0, 3)); @@ -536,8 +533,6 @@ namespace basegfx // correct rotate values rRotate.correctValues(); } - - return true; } } // end of namespace basegfx |