summaryrefslogtreecommitdiff
path: root/basic/source/classes
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-05-09 12:14:32 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-05-09 13:52:30 +0200
commit12191a4f30078bb81c39a74a994ba7b2b410adaf (patch)
tree394626ae75e6b77e4159657847f894e4f7c9495b /basic/source/classes
parent3a9854a92923df8013ca832c48aa9f284bcb1adc (diff)
make loplugin constantparam smarter about string params
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basic/source/classes')
-rw-r--r--basic/source/classes/sb.cxx4
-rw-r--r--basic/source/classes/sbxmod.cxx8
2 files changed, 6 insertions, 6 deletions
diff --git a/basic/source/classes/sb.cxx b/basic/source/classes/sb.cxx
index ac8bf7f56d87..c3e0a63c2668 100644
--- a/basic/source/classes/sb.cxx
+++ b/basic/source/classes/sb.cxx
@@ -425,9 +425,9 @@ SbxBase* SbiFactory::Create( sal_uInt16 nSbxId, sal_uInt32 nCreator )
case SBXID_BASICMETHOD:
return new SbMethod( "", SbxVARIANT, nullptr );
case SBXID_JSCRIPTMOD:
- return new SbJScriptModule( "" );
+ return new SbJScriptModule;
case SBXID_JSCRIPTMETH:
- return new SbJScriptMethod( "", SbxVARIANT );
+ return new SbJScriptMethod( SbxVARIANT );
}
}
return nullptr;
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index 50b435c7c80a..aca923d8c7d5 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -1913,8 +1913,8 @@ void SbModule::handleProcedureProperties( SfxBroadcaster& rBC, const SfxHint& rH
// Implementation SbJScriptModule (Basic module for JavaScript source code)
-SbJScriptModule::SbJScriptModule( const OUString& rName )
- :SbModule( rName )
+SbJScriptModule::SbJScriptModule()
+ :SbModule( "" )
{
}
@@ -2135,8 +2135,8 @@ void SbMethod::Broadcast( SfxHintId nHintId )
// Implementation of SbJScriptMethod (method class as a wrapper for JavaScript-functions)
-SbJScriptMethod::SbJScriptMethod( const OUString& r, SbxDataType t )
- : SbMethod( r, t, nullptr )
+SbJScriptMethod::SbJScriptMethod( SbxDataType t )
+ : SbMethod( "", t, nullptr )
{
}