diff options
| author | baltasarq <baltasarq@gmail.com> | 2021-06-22 12:55:21 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-06-25 16:26:50 +0200 |
| commit | 5eedb3beeaeed88de0d1ebd041a9f15ceea7e78c (patch) | |
| tree | 1f317cb23e1aa28cfca51ca460c68b5e189901bb /basic/source/inc | |
| parent | 4c267311ed7bedfd373db2afc12cad9757922ce1 (diff) | |
tdf#142460: properly handle boolean values in string pool
This makes sure that results of comparison of literals have proper boolean type,
and that this type is properly stored to/read from the string pool.
This introduces a new non-standard "type" character used in the pool: 'b'. It is
not a proper type character used in Basic (unlike '%'/'&'/'!'/'@'), but we have
to use this trick locally, because we need to pass the type that has no own type
character.
The change should be backward-compatible: older versions reading the value should
just ignore the 'b', and read the value as double.
Change-Id: Ibd4a70b366331342346eb171c8ed3c7026279596
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117655
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'basic/source/inc')
| -rw-r--r-- | basic/source/inc/filefmt.hxx | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/basic/source/inc/filefmt.hxx b/basic/source/inc/filefmt.hxx index 3460b1abbd7f..25ba647ad743 100644 --- a/basic/source/inc/filefmt.hxx +++ b/basic/source/inc/filefmt.hxx @@ -40,6 +40,9 @@ // Version 13: tdf#94617 store methods nStart information greater than sal_Int16 limit // tdf#57113 store UTF-16 strings after legacy 1-byte-encoded strings in pool (no // version number bump for backward compatibility; relies on magic number) +// tdf#142460: properly handle boolean values in string pool (no +// version number bump for backward compatibility; relies on +// new integer type suffix 'b') // #define B_LEGACYVERSION 0x00000011 |