improve passstuffbyref return analysis

Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

7 files changed, 11 insertions, 11 deletions

diff --git a/basic/source/classes/errobject.cxx b/basic/source/classes/errobject.cxx
index 7bf209563d91..45421d50600c 100644
--- a/basic/source/classes/errobject.cxx
+++ b/basic/source/classes/errobject.cxx
@@ -189,7 +189,7 @@ SbxErrObject::~SbxErrObject()
     OSL_TRACE("SbxErrObject::~SbxErrObject dtor");
 }
 
-uno::Reference< vba::XErrObject >
+uno::Reference< vba::XErrObject > const &
 SbxErrObject::getUnoErrObject()
 {
     SbxVariable* pVar = getErrObject();
@@ -197,7 +197,7 @@ SbxErrObject::getUnoErrObject()
     return pGlobErr->m_xErr;
 }
 
-SbxVariableRef
+SbxVariableRef const &
 SbxErrObject::getErrObject()
 {
     static SbxVariableRef pGlobErr = new SbxErrObject( OUString("Err"), uno::makeAny( uno::Reference< vba::XErrObject >( new ErrObject() ) ) );
diff --git a/basic/source/classes/sb.cxx b/basic/source/classes/sb.cxx
index 6d2aaa6c84d5..a4de8a1ceb72 100644
--- a/basic/source/classes/sb.cxx
+++ b/basic/source/classes/sb.cxx
@@ -1815,7 +1815,7 @@ void StarBASIC::SetGlobalBreakHdl( const Link<StarBASIC*,sal_uInt16>& rLink )
     GetSbData()->aBreakHdl = rLink;
 }
 
-SbxArrayRef StarBASIC::getUnoListeners()
+SbxArrayRef const & StarBASIC::getUnoListeners()
 {
     if( !xUnoListeners.Is() )
     {
diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx
index 21be5c9dee43..10e96e6de2e6 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -167,7 +167,7 @@ Reference< XIdlReflection > getCoreReflection_Impl()
 }
 
 // save CoreReflection statically
-Reference< XHierarchicalNameAccess > getCoreReflection_HierarchicalNameAccess_Impl()
+Reference< XHierarchicalNameAccess > const & getCoreReflection_HierarchicalNameAccess_Impl()
 {
     static Reference< XHierarchicalNameAccess > xCoreReflection_HierarchicalNameAccess;
 
@@ -184,7 +184,7 @@ Reference< XHierarchicalNameAccess > getCoreReflection_HierarchicalNameAccess_Im
 }
 
 // Hold TypeProvider statically
-Reference< XHierarchicalNameAccess > getTypeProvider_Impl()
+Reference< XHierarchicalNameAccess > const & getTypeProvider_Impl()
 {
     static Reference< XHierarchicalNameAccess > xAccess;
 
@@ -210,7 +210,7 @@ Reference< XHierarchicalNameAccess > getTypeProvider_Impl()
 }
 
 // Hold TypeConverter statically
-Reference< XTypeConverter > getTypeConverter_Impl()
+Reference< XTypeConverter > const & getTypeConverter_Impl()
 {
     static Reference< XTypeConverter > xTypeConverter;
 
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index 1e59c1373474..76ab1aa44761 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -492,7 +492,7 @@ SbModule::~SbModule()
     mxWrapper = nullptr;
 }
 
-uno::Reference< script::XInvocation >
+uno::Reference< script::XInvocation > const &
 SbModule::GetUnoModule()
 {
     if ( !mxWrapper.is() )
diff --git a/basic/source/inc/errobject.hxx b/basic/source/inc/errobject.hxx
index 88cef685e8d2..796b83102269 100644
--- a/basic/source/inc/errobject.hxx
+++ b/basic/source/inc/errobject.hxx
@@ -32,8 +32,8 @@ class SbxErrObject : public SbUnoObject
     virtual ~SbxErrObject();
 
 public:
-    static SbxVariableRef getErrObject();
-    static css::uno::Reference< ooo::vba::XErrObject > getUnoErrObject();
+    static SbxVariableRef const & getErrObject();
+    static css::uno::Reference< ooo::vba::XErrObject > const & getUnoErrObject();
 
     void setNumberAndDescription( ::sal_Int32 _number, const OUString& _description )
         throw (css::uno::RuntimeException);
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 2abca341ca68..420298ab2940 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -160,7 +160,7 @@ OUString getFullPath( const OUString& aRelPath )
 }
 
 // TODO: -> SbiGlobals
-static uno::Reference< ucb::XSimpleFileAccess3 > getFileAccess()
+static uno::Reference< ucb::XSimpleFileAccess3 > const & getFileAccess()
 {
     static uno::Reference< ucb::XSimpleFileAccess3 > xSFI;
     if( !xSFI.is() )
diff --git a/basic/source/runtime/methods1.cxx b/basic/source/runtime/methods1.cxx
index 6bddfd5c8570..93183d289e17 100644
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@@ -67,7 +67,7 @@ using namespace com::sun::star::lang;
 using namespace com::sun::star::sheet;
 using namespace com::sun::star::uno;
 
-static Reference< XCalendar4 > getLocaleCalendar()
+static Reference< XCalendar4 > const & getLocaleCalendar()
 {
     static Reference< XCalendar4 > xCalendar;
     if( !xCalendar.is() )