diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2016-03-09 15:15:16 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2016-03-09 15:16:07 +0000 |
| commit | a139320da2f28fe83145c9c9f33f2b3421fbc4c4 (patch) | |
| tree | 8362f40ae2c875f7bba15eb2f8ae079570dcacee /basic | |
| parent | 1f7af133d9bade2cf226b65fab501d68113f8cc6 (diff) | |
deref of null
regression from
commit f17a4694b07856292804c23b80ce92967d401bb8
Author: Arnaud Versini <arnaud.versini@gmail.com>
Date: Sat Feb 13 20:17:41 2016 +0100
BASIC : use std::unique_ptr for storing SbiExprList
Change-Id: I37f2a1c837c6742cf6d403962d2730b5e80004ec
Reviewed-on: https://gerrit.libreoffice.org/22345
because they have been moved into the container at this
point
Change-Id: If21e0321ffdce66aa9629637d0ff8c16efbbd25e
Diffstat (limited to 'basic')
| -rw-r--r-- | basic/source/comp/exprtree.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/basic/source/comp/exprtree.cxx b/basic/source/comp/exprtree.cxx index 8e3c4412e95a..bd509ad31726 100644 --- a/basic/source/comp/exprtree.cxx +++ b/basic/source/comp/exprtree.cxx @@ -234,8 +234,8 @@ SbiExprNode* SbiExpression::Term( const KeywordSymbolInfo* pKeywordSymbolInfo ) pvMoreParLcl = new SbiExprListVector(); } SbiExprListPtr pAddPar = SbiExprList::ParseParameters( pParser ); - pvMoreParLcl->push_back( std::move(pAddPar) ); bError = bError || !pAddPar->IsValid(); + pvMoreParLcl->push_back( std::move(pAddPar) ); eTok = pParser->Peek(); } } @@ -432,8 +432,8 @@ SbiExprNode* SbiExpression::ObjTerm( SbiSymDef& rObj ) pvMoreParLcl = new SbiExprListVector(); } SbiExprListPtr pAddPar = SbiExprList::ParseParameters( pParser ); - pvMoreParLcl->push_back( std::move(pAddPar) ); bError = bError || !pPar->IsValid(); + pvMoreParLcl->push_back( std::move(pAddPar) ); eTok = pParser->Peek(); } } |