diff options
| author | Noel Grandin <noel@peralex.com> | 2015-01-20 12:38:10 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2015-01-26 08:42:28 +0200 |
| commit | b44cbb26efe1d0b0950b1e1613e131b506dc3876 (patch) | |
| tree | 9b4d5d99e5dad0971079b997a02a6d96536709ca /basic | |
| parent | 26ad60aec69310fecd918f1c2e09056aa4782320 (diff) | |
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
Diffstat (limited to 'basic')
| -rw-r--r-- | basic/inc/sbobjmod.hxx | 2 | ||||
| -rw-r--r-- | basic/source/classes/eventatt.cxx | 2 | ||||
| -rw-r--r-- | basic/source/classes/sbunoobj.cxx | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/basic/inc/sbobjmod.hxx b/basic/inc/sbobjmod.hxx index 37f1b100b187..0f586a9e3a66 100644 --- a/basic/inc/sbobjmod.hxx +++ b/basic/inc/sbobjmod.hxx @@ -60,7 +60,7 @@ class BASIC_DLLPUBLIC SbUserFormModule : public SbObjModule bool mbInit; //protected: - virtual void InitObject(); + void InitObject(); public: TYPEINFO_OVERRIDE(); SbUserFormModule( const OUString& rName, const com::sun::star::script::ModuleInfo& mInfo, bool bIsVBACompat ); diff --git a/basic/source/classes/eventatt.cxx b/basic/source/classes/eventatt.cxx index a60c5c56d0ee..943d96d65aa6 100644 --- a/basic/source/classes/eventatt.cxx +++ b/basic/source/classes/eventatt.cxx @@ -141,7 +141,7 @@ class BasicScriptListener_Impl : public WeakImplHelper1< XScriptListener > StarBASICRef maBasicRef; Reference< frame::XModel > m_xModel; - virtual void firing_impl(const ScriptEvent& aScriptEvent, Any* pRet); + void firing_impl(const ScriptEvent& aScriptEvent, Any* pRet); public: BasicScriptListener_Impl( StarBASIC* pBasic, const Reference< frame::XModel >& xModel ) diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx index 76ff71356b3c..0ae9bd5e154d 100644 --- a/basic/source/classes/sbunoobj.cxx +++ b/basic/source/classes/sbunoobj.cxx @@ -3894,7 +3894,7 @@ void SbUnoSingleton::SFX_NOTIFY( SfxBroadcaster& rBC, const TypeId& rBCType, // solely transmits several events to an general AllListener class BasicAllListener_Impl : public BasicAllListenerHelper { - virtual void firing_impl(const AllEventObject& Event, Any* pRet); + void firing_impl(const AllEventObject& Event, Any* pRet); public: SbxObjectRef xSbxObj; |