diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-08-01 08:40:47 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-08-01 11:06:26 +0200 |
commit | 612b489d3e05b24c1b6690082e8518bac033e9d2 (patch) | |
tree | 23a6c556989071385d1c64730ed72bdbae7c239c /basic | |
parent | 17e14d459dea201b57be2d8e677fa776ead03291 (diff) |
loplugin:checkunusedparams
the "check for taking address of function" part was generating false+
Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f
Reviewed-on: https://gerrit.libreoffice.org/40613
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basic')
-rw-r--r-- | basic/inc/sbstdobj.hxx | 12 | ||||
-rw-r--r-- | basic/source/runtime/stdobj1.cxx | 25 |
2 files changed, 18 insertions, 19 deletions
diff --git a/basic/inc/sbstdobj.hxx b/basic/inc/sbstdobj.hxx index 34a6e49e7450..8fe8c336b848 100644 --- a/basic/inc/sbstdobj.hxx +++ b/basic/inc/sbstdobj.hxx @@ -101,12 +101,12 @@ protected: virtual ~SbStdClipboard() override; virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override; - static void MethClear( SbxVariable* pVar, SbxArray const * pPar_, bool bWrite ); - static void MethGetData( SbxArray* pPar_, bool bWrite ); - static void MethGetFormat( SbxVariable* pVar, SbxArray* pPar_, bool bWrite ); - static void MethGetText( SbxVariable* pVar, SbxArray const * pPar_, bool bWrite ); - static void MethSetData( SbxArray* pPar_, bool bWrite ); - static void MethSetText( SbxArray const * pPar_, bool bWrite ); + static void MethClear( SbxArray const * pPar_ ); + static void MethGetData( SbxArray* pPar_ ); + static void MethGetFormat( SbxVariable* pVar, SbxArray* pPar_ ); + static void MethGetText( SbxVariable* pVar, SbxArray const * pPar_ ); + static void MethSetData( SbxArray* pPar_ ); + static void MethSetText( SbxArray const * pPar_ ); public: diff --git a/basic/source/runtime/stdobj1.cxx b/basic/source/runtime/stdobj1.cxx index 07342d1bb1ee..6777f682f9d6 100644 --- a/basic/source/runtime/stdobj1.cxx +++ b/basic/source/runtime/stdobj1.cxx @@ -277,7 +277,7 @@ void SbStdFont::Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) } -void SbStdClipboard::MethClear( SbxVariable*, SbxArray const * pPar_, bool ) +void SbStdClipboard::MethClear( SbxArray const * pPar_ ) { if( pPar_ && (pPar_->Count() > 1) ) { @@ -287,7 +287,7 @@ void SbStdClipboard::MethClear( SbxVariable*, SbxArray const * pPar_, bool ) } -void SbStdClipboard::MethGetData( SbxArray* pPar_, bool ) +void SbStdClipboard::MethGetData( SbxArray* pPar_ ) { if( !pPar_ || (pPar_->Count() != 2) ) { @@ -304,7 +304,7 @@ void SbStdClipboard::MethGetData( SbxArray* pPar_, bool ) } -void SbStdClipboard::MethGetFormat( SbxVariable* pVar, SbxArray* pPar_, bool ) +void SbStdClipboard::MethGetFormat( SbxVariable* pVar, SbxArray* pPar_ ) { if( !pPar_ || (pPar_->Count() != 2) ) { @@ -322,7 +322,7 @@ void SbStdClipboard::MethGetFormat( SbxVariable* pVar, SbxArray* pPar_, bool ) pVar->PutBool( false ); } -void SbStdClipboard::MethGetText( SbxVariable* pVar, SbxArray const * pPar_, bool ) +void SbStdClipboard::MethGetText( SbxVariable* pVar, SbxArray const * pPar_ ) { if( pPar_ && (pPar_->Count() > 1) ) { @@ -333,7 +333,7 @@ void SbStdClipboard::MethGetText( SbxVariable* pVar, SbxArray const * pPar_, boo pVar->PutString( OUString() ); } -void SbStdClipboard::MethSetData( SbxArray* pPar_, bool ) +void SbStdClipboard::MethSetData( SbxArray* pPar_ ) { if( !pPar_ || (pPar_->Count() != 3) ) { @@ -350,7 +350,7 @@ void SbStdClipboard::MethSetData( SbxArray* pPar_, bool ) } -void SbStdClipboard::MethSetText( SbxArray const * pPar_, bool ) +void SbStdClipboard::MethSetText( SbxArray const * pPar_ ) { if( !pPar_ || (pPar_->Count() != 2) ) { @@ -408,17 +408,16 @@ void SbStdClipboard::Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) SbxVariable* pVar = pHint->GetVar(); SbxArray* pPar_ = pVar->GetParameters(); const sal_uInt32 nWhich = pVar->GetUserData(); - bool bWrite = pHint->GetId() == SfxHintId::BasicDataChanged; // Methods switch( nWhich ) { - case METH_CLEAR: MethClear( pVar, pPar_, bWrite ); return; - case METH_GETDATA: MethGetData( pPar_, bWrite ); return; - case METH_GETFORMAT: MethGetFormat( pVar, pPar_, bWrite ); return; - case METH_GETTEXT: MethGetText( pVar, pPar_, bWrite ); return; - case METH_SETDATA: MethSetData( pPar_, bWrite ); return; - case METH_SETTEXT: MethSetText( pPar_, bWrite ); return; + case METH_CLEAR: MethClear( pPar_ ); return; + case METH_GETDATA: MethGetData( pPar_ ); return; + case METH_GETFORMAT: MethGetFormat( pVar, pPar_ ); return; + case METH_GETTEXT: MethGetText( pVar, pPar_ ); return; + case METH_SETDATA: MethSetData( pPar_ ); return; + case METH_SETTEXT: MethSetText( pPar_ ); return; } SbxObject::Notify( rBC, rHint ); |