summaryrefslogtreecommitdiff
path: root/bean/pom.officebean.xml
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@collabora.com>2022-11-11 15:58:11 +0100
committerMiklos Vajna <vmiklos@collabora.com>2022-11-11 19:35:55 +0100
commitc725028f15c36fc626d9ad8cdc288eb73c3e2643 (patch)
treebf5a3698a417e45f4b812183a05f032b18417677 /bean/pom.officebean.xml
parentc819aa06069ec3ea4f2f51d26a77f455740b828f (diff)
SVG export: fix handling of semi-transparent, multi-para shape text
The bugdoc had a shape with two paragraphs. The export of the second paragraph went wrong: the position & size of the text was larger than expected. This problem was specific to semi-transparent text. SVGTextWriter::setTextPosition() is recursive in this case. The non-transparent case left nCurAction unchanged in the outer setTextPosition() and it returned 1 ("text is found"). The semi-transparent case changed nCurAction by +2 and returned 0 ("text is not found"). This led to all sorts of trouble, including mismatching Push() and Pop() calls on the output device when replaying the metafile. Fix the problem by routing the empty state from the inner setTextPosition() to the outer one: if we return 1 ("text is found"), then we know that the state is non-empty. Once the empty state is correct in the outer setTextPosition(), then even the transparent case also leaves nCurAction unchanged and the whole shape text has the correct position and size. I forgot to update this empty state in ther outer setTextPosition() in commit 666f252457bdb4371d15380a0289e107b2dfbe84 (SVG export: fix lost semi-transparent text on shapes, 2020-07-17). Change-Id: I7dc93fe13c4510220bf09a388e742799ed042510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142590 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
Diffstat (limited to 'bean/pom.officebean.xml')
0 files changed, 0 insertions, 0 deletions