make some symbols private

Change-Id: I224831ad18e754fd67d9b16510cd286a5397f1f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98236
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

3 files changed, 9 insertions, 24 deletions

diff --git a/bin/find-can-be-private-symbols.classes.results b/bin/find-can-be-private-symbols.classes.results
index 05defda91c09..520f90bdb04b 100644
--- a/bin/find-can-be-private-symbols.classes.results
+++ b/bin/find-can-be-private-symbols.classes.results
@@ -4,7 +4,6 @@ BitmapConvolutionMatrixFilter
 BitmapEmbossGreyFilter
 BitmapMedianFilter
 BitmapMonochromeFilter
-BitmapMonochromeMatrixFilter
 BitmapMosaicFilter
 BitmapPalette
 BitmapPopArtFilter
@@ -25,17 +24,12 @@ FmDesignModeChangedHint
 FocusListenerMultiplexer
 FontSelectPattern
 FontSubsetInfo
-FreetypeManager::IFSD_Equal
 GrBackendFormat
 GrBackendRenderTarget
 GrBackendTexture
 GrContext
 GrContextThreadSafeProxy
 GrContext_Base
-GrGLExtensions
-GrGLInterface
-GrGpuResource
-GrGpuResource::ProxyAccess
 GrImageContext
 GrVkExtensions
 GrVkSecondaryCBDrawContext
@@ -51,6 +45,7 @@ MorkParser
 MouseListenerMultiplexer
 MouseMotionListenerMultiplexer
 MyThes
+NotifyEvent
 OpenGLFramebuffer
 OpenGLZone
 PackedTextureAtlasManager
@@ -64,7 +59,6 @@ SalInfoPrinter
 SalPrinter
 SalSystem
 SbClassModuleObject
-ScChart2DataProvider
 ScFormatEntry
 ScPaintHint
 ScPreviewShell
@@ -112,8 +106,6 @@ SfxStyleSheetModifiedHint
 SfxViewFrameItem
 SfxVisibilityItem
 SpinListenerMultiplexer
-SvxGraphicObject
-SvxMetricField
 SvxPrintItem
 SvxRsidItem
 SvxShowText
@@ -157,9 +149,6 @@ SyntaxHighlighter::Tokenizer
 SystemWindow::ImplData
 TBCExtraInfo
 TBCGeneralInfo
-TreeEditListenerMultiplexer
-TreeExpansionListenerMultiplexer
-TreeSelectionListenerMultiplexer
 VclAlignment
 VclBin
 VclBuilder::MenuAndId
@@ -246,23 +235,19 @@ oox::ole::AxPageModel
 oox::ole::AxTabStripModel
 oox::ole::AxToggleButtonModel
 oox::ole::AxUserFormModel
-psp::PrintFontManager::PrintFont
 salhelper::ORealDynamicLoader
-sc::FormulaGroupInterpreter
 sd::DrawView
 sdr::SelectionController
 sdr::ViewSelection
 sdr::animation::primitiveAnimator
 sdr::contact::ObjectContactPainter
-sdr::properties::BaseProperties
 sfx2::sidebar::Panel
 sfx2::sidebar::SidebarToolBox
-sfx2::sidebar::TabBar::Item
-skjpeg_destination_mgr
-svt::MultiLineEditImplementation
+svt::ControlBase
+svt::EditControlBase
 svt::MultiLineTextCell
+svtools::ToolbarPopup
 svx::CommonStyleManager
-svx::DialControl::DialControl_Impl
 svx::PropertyValueProvider
 sw::BroadcastingModify
 sw::UnoCursorHint
@@ -272,7 +257,6 @@ ucbhelper::InteractionApprove
 ucbhelper::InteractionDisapprove
 ucbhelper::InteractionRetry
 ucbhelper::InteractionSupplyAuthentication
-utl::Bootstrap::Impl
 utl::OInputStreamHelper
 vcl::ExtOutDevData
 vcl::test::OutputDeviceTestGradient
@@ -281,3 +265,4 @@ writerperfect::DirectoryStream::Impl
 xmloff::OControlBorderHandler
 xmloff::OFontWidthHandler
 xmloff::ORotationAngleHandler
+xmlsecurity::pdfio
diff --git a/bin/find-can-be-private-symbols.functions.results b/bin/find-can-be-private-symbols.functions.results
index 59453f8ea623..6b2b4c0e5787 100644
--- a/bin/find-can-be-private-symbols.functions.results
+++ b/bin/find-can-be-private-symbols.functions.results
@@ -1,4 +1,3 @@
-GrGLAssembleInterface(void*, void (*(*)(void*, char const*))())
 ImplCallPreNotify(NotifyEvent&)
 ImplDestroyHelpWindow(bool)
 ImplFastBitmapConversion(BitmapBuffer&, BitmapBuffer const&, SalTwoRect const&)
diff --git a/bin/find-can-be-private-symbols.py b/bin/find-can-be-private-symbols.py
index f5ff83fd1757..d679dd2a24bf 100755
--- a/bin/find-can-be-private-symbols.py
+++ b/bin/find-can-be-private-symbols.py
@@ -30,14 +30,14 @@ classes_with_imported_symbols = set()
 all_source_names = set()
 
 
-# look for imported symbols in executables
-subprocess_find_all_source_names = subprocess.Popen("git grep -oh -P '\\b\\w\\w\\w+\\b' -- '*.h*'", stdout=subprocess.PIPE, stderr=subprocess.STDOUT, shell=True)
+subprocess_find_all_source_names = subprocess.Popen("git grep -oh -P '\\b\\w\\w\\w+\\b' -- '*.h*' | sort -u", stdout=subprocess.PIPE, stderr=subprocess.STDOUT, shell=True)
 with subprocess_find_all_source_names.stdout as txt:
     for line in txt:
         line = line.strip()
         all_source_names.add(line)
 subprocess_find_all_source_names.terminate()
 
+# find all our shared libs
 subprocess_find = subprocess.Popen("find ./instdir -name *.so && find ./workdir/LinkTarget/CppunitTest -name *.so", stdout=subprocess.PIPE, shell=True)
 with subprocess_find.stdout as txt:
     for line in txt:
@@ -51,7 +51,8 @@ with subprocess_find.stdout as txt:
             for line2 in txt2:
                 line2 = line2.strip()
                 if line_regex.match(line2):
-                    exported_symbols.add(line2.split(" ")[2])
+                    sym = line2.split(" ")[2]
+                    exported_symbols.add(sym)
         # look for imported symbols
         subprocess_objdump = subprocess.Popen("objdump -T " + sharedlib, stdout=subprocess.PIPE, shell=True)
         with subprocess_objdump.stdout as txt2: