diff options
author | Tor Lillqvist <tml@collabora.com> | 2020-11-12 21:46:06 +0200 |
---|---|---|
committer | Tor Lillqvist <tml@collabora.com> | 2020-11-13 20:01:08 +0100 |
commit | 76fc34baeb4257e71092690b7039c0befe371bae (patch) | |
tree | 8c702aaee468c59229be5504b29ee7b651a858d2 /bridges/source | |
parent | 7392394028275f05377ace11b1cab850e1fcf521 (diff) |
Make bridgetest exercise parameter passing in the C++/UNO bridge harder
The C++/UNO bridge for macOS on arm64 currently uses the Linux code.
Apple's ABI uses slightly different parameter passing on the stack,
though. See
https://developer.apple.com/documentation/xcode/writing_arm64_code_for_apple_platforms?language=objc
That has not been taken into account yet in the bridge code. The
bridgetest, when run on macOS on arm64, didn't notice, sadly, but
succeeded. With this change it crashes, as one would expect it to do.
Add one more byte and short parameter to the setValues(), setValues2()
and getValues() calls in the XBridgeTestBase interface. The stack
allocation for those [in] parameters to setValues() differ between the
Linux and Apple ABIs. Add corresponding attributes to the interface,
and members to the SimpleTest struct.
The changes to the source files in the cli subdirectory (C++/CLI,
VB.NET, and C#) are done blindly as they aren't compiled even on
Windows currently. Most likely the changes to them are incomplete and
erroneous.
Change-Id: I6f689a130d89b23cad9918829107d7da49a79c55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105770
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Diffstat (limited to 'bridges/source')
0 files changed, 0 insertions, 0 deletions