summaryrefslogtreecommitdiff
path: root/bridges
diff options
context:
space:
mode:
authorLuboš Luňák <l.lunak@collabora.com>2018-05-29 12:27:34 +0200
committerLuboš Luňák <l.lunak@collabora.com>2018-05-30 07:13:57 +0200
commita2045f94677c4407c00a3299da0936ded696cfb2 (patch)
tree800b0ecdb366f41c6227f70ec171471caf562a57 /bridges
parent7725eff80a7bc3f3e422e56e1cd7bfa531f19a70 (diff)
make CharClass also mutex-protect calls to its dependent class
When calc_tests runs test_tdf53482_Range_contains_column_headings_file() with Calc's threading enabled, it ends up calling ScInterpreter::ScProper() from threads, which calls to CharClass. And while CharClass tries to be thread-safe (guessing from the mutex usage), it forwards calls to i18npool's CharacterClassificationImpl and cclass_Unicode, both of which aren't thread-safe. Which makes thread safety of CharClass itself pointless. Since CharClass already acquires the mutex anyway because of getMyLocale(), just extend the duration for the entire call, which hopefully shouldn't make that much of a difference. Change-Id: I544b34d7e58c4a901f3b6e3a3ff52156b9e320a8 Reviewed-on: https://gerrit.libreoffice.org/54999 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'bridges')
0 files changed, 0 insertions, 0 deletions