diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-05-13 10:46:00 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-05-13 10:46:00 +0200 |
| commit | 96b129052e280e094b6a150b185f9e8285cecca4 (patch) | |
| tree | e656dc72df93654139be54b29b0d12573497445b /bridges | |
| parent | 9a8411d3b13a4e3675f99f36d5b6e81c5eace9b6 (diff) | |
Revert "CID#705982 ensure umask for mkstemp"
This reverts commit 9ab99483808bad973363f1f27bb548c8628ace1d. Coverity warning
about mkstemp without umask appears to be bogus (cf.
<https://communities.coverity.com/message/6516> "Why are uses of mkstemp
'without securely setting umask first' being flagged?) and calling umask is not
MT-safe, see fdo#60338 "FILESAVE: Saved files have incorrect permissions on
linux."
Diffstat (limited to 'bridges')
| -rw-r--r-- | bridges/source/cpp_uno/shared/vtablefactory.cxx | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/bridges/source/cpp_uno/shared/vtablefactory.cxx b/bridges/source/cpp_uno/shared/vtablefactory.cxx index f6e9e7c2e961..2589f64d40f6 100644 --- a/bridges/source/cpp_uno/shared/vtablefactory.cxx +++ b/bridges/source/cpp_uno/shared/vtablefactory.cxx @@ -60,8 +60,6 @@ #if defined USE_DOUBLE_MMAP #include <fcntl.h> -#include <sys/types.h> -#include <sys/stat.h> #endif using bridges::cpp_uno::shared::VtableFactory; @@ -241,7 +239,6 @@ bool VtableFactory::createBlock(Block &block, sal_Int32 slotCount) const if (aSecurity.getHomeDir(strURLDirectory)) osl::File::getSystemPathFromFileURL(strURLDirectory, strDirectory); - mode_t nOrigMode = umask(S_IRWXG | S_IRWXO); for (int i = strDirectory.isEmpty() ? 1 : 0; i < 2; ++i) { if (strDirectory.isEmpty()) @@ -293,7 +290,6 @@ bool VtableFactory::createBlock(Block &block, sal_Int32 slotCount) const strDirectory = OUString(); } - umask(nOrigMode); if (!block.start || !block.exec || block.fd == -1) { //Fall back to non-doublemmaped allocation |