diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-02-06 18:14:16 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-02-07 10:19:32 +0000 |
| commit | 00659bcdbbb167596e6fd18e283a54819dd6fe91 (patch) | |
| tree | 65316f99002c5aa6851ee1770df557b789772f20 /canvas/qa | |
| parent | 545ddfbaa98cfeaa35c95d7db7b16cd241cedc89 (diff) | |
improve readability of VirtualDevice constructor
(a) It is not obvious what DeviceFormat::DEFAULT means
(b) There are two parameters (each with two states), but only really 2
possible overall states
So
(1) use more useful names
(2) combine the two parameters into one enum
Change-Id: Ic0595b39e032cc9e019b88326389d055b977da00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146589
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'canvas/qa')
| -rw-r--r-- | canvas/qa/cppunit/canvastest.cxx | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/canvas/qa/cppunit/canvastest.cxx b/canvas/qa/cppunit/canvastest.cxx index 7927f07c0723..d4cba860db43 100644 --- a/canvas/qa/cppunit/canvastest.cxx +++ b/canvas/qa/cppunit/canvastest.cxx @@ -76,9 +76,8 @@ public: void setupCanvas(const Size& size, Color backgroundColor = COL_WHITE, bool alpha = false) { - mVclDevice - = alpha ? VclPtr<VirtualDevice>::Create(DeviceFormat::DEFAULT, DeviceFormat::DEFAULT) - : VclPtr<VirtualDevice>::Create(DeviceFormat::DEFAULT); + mVclDevice = alpha ? VclPtr<VirtualDevice>::Create(DeviceFormat::WITH_ALPHA) + : VclPtr<VirtualDevice>::Create(DeviceFormat::WITHOUT_ALPHA); mVclDevice->SetOutputSizePixel(size); mVclDevice->SetBackground(Wallpaper(backgroundColor)); mVclDevice->Erase(); |