summaryrefslogtreecommitdiff
path: root/canvas/workben
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2024-11-15 13:21:49 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2024-11-19 07:46:25 +0100
commit193207c5abf339253e15b59f398da0c1f6f43bee (patch)
treeaf181e0b4335d73b4db5b2ccf180779f7c82de5b /canvas/workben
parentb4b3949da1aad091b9f8d0f301f9f7031d6ce295 (diff)
improve loplugin passparamsbyref
I think I managed to disable this when I converted it to use the shared plugin infrastructure. So fix that, and then make it much smarter to avoid various false positives. Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'canvas/workben')
-rw-r--r--canvas/workben/canvasdemo.cxx6
1 files changed, 3 insertions, 3 deletions
diff --git a/canvas/workben/canvasdemo.cxx b/canvas/workben/canvasdemo.cxx
index 65e8ba775c76..7199553f6223 100644
--- a/canvas/workben/canvasdemo.cxx
+++ b/canvas/workben/canvasdemo.cxx
@@ -88,7 +88,7 @@ class DemoRenderer
uno::Reference< rendering::XGraphicDevice > mxDevice;
DemoRenderer( uno::Reference< rendering::XGraphicDevice > xDevice,
- uno::Reference< rendering::XCanvas > xCanvas,
+ const uno::Reference< rendering::XCanvas > & xCanvas,
Size aSize ) :
maSize(aSize),
maColorBlack( vcl::unotools::colorToStdColorSpaceSequence( COL_BLACK) ),
@@ -139,7 +139,7 @@ class DemoRenderer
maViewState, maRenderState );
}
- void drawStringAt( OString aString, double x, double y )
+ void drawStringAt( const OString & aString, double x, double y )
{
rendering::StringContext aText;
aText.Text = OStringToOUString( aString, RTL_TEXTENCODING_UTF8 );
@@ -261,7 +261,7 @@ class DemoRenderer
//mxCanvas->drawPolyPolygon( xPoly, maViewState, aRenderState );
}
- void drawTitle( OString aTitle )
+ void drawTitle( const OString & aTitle )
{
// FIXME: text anchoring to be done
double nStringWidth = aTitle.getLength() * 8.0;