clang-tidy:readability-redundant-member-init

Change-Id: I48e6fb31df732805423b89ed91b6e4363a69b668
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121150
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

28 files changed, 9 insertions, 71 deletions

diff --git a/canvas/inc/base/bufferedgraphicdevicebase.hxx b/canvas/inc/base/bufferedgraphicdevicebase.hxx
index 067d37a984f0..4cd604148cce 100644
--- a/canvas/inc/base/bufferedgraphicdevicebase.hxx
+++ b/canvas/inc/base/bufferedgraphicdevicebase.hxx
@@ -80,8 +80,6 @@ namespace canvas
         typedef Mutex MutexType;
 
         BufferedGraphicDeviceBase() :
-            mxWindow(),
-            maBounds(),
             mbIsVisible( false ),
             mbIsTopLevel( false )
         {
diff --git a/canvas/inc/base/graphicdevicebase.hxx b/canvas/inc/base/graphicdevicebase.hxx
index 151a39a9f153..c17d7bbb8bc5 100644
--- a/canvas/inc/base/graphicdevicebase.hxx
+++ b/canvas/inc/base/graphicdevicebase.hxx
@@ -116,7 +116,6 @@ namespace canvas
 
         GraphicDeviceBase() :
             maDeviceHelper(),
-            maPropHelper(),
             mbDumpScreenContent(false)
         {
             maPropHelper.initProperties( PropertySetHelper::MakeMap
diff --git a/canvas/source/cairo/cairo_canvasbitmap.cxx b/canvas/source/cairo/cairo_canvasbitmap.cxx
index 55f1603237b2..430bb3b5fc60 100644
--- a/canvas/source/cairo/cairo_canvasbitmap.cxx
+++ b/canvas/source/cairo/cairo_canvasbitmap.cxx
@@ -39,8 +39,6 @@ namespace cairocanvas
                                 rendering::XGraphicDevice* pDevice,
                                 bool                       bHasAlpha ) :
         mpSurfaceProvider( rSurfaceProvider ),
-        mpBufferSurface(),
-        mpBufferCairo(),
         maSize(rSize),
         mbHasAlpha(bHasAlpha)
     {
diff --git a/canvas/source/cairo/cairo_canvashelper.cxx b/canvas/source/cairo/cairo_canvashelper.cxx
index 32124af830f9..2ee30cfc3740 100644
--- a/canvas/source/cairo/cairo_canvashelper.cxx
+++ b/canvas/source/cairo/cairo_canvashelper.cxx
@@ -64,11 +64,7 @@ namespace cairocanvas
     CanvasHelper::CanvasHelper() :
         mpSurfaceProvider(nullptr),
         mpDevice(nullptr),
-        mpVirtualDevice(),
-        mbHaveAlpha(),
-        mpCairo(),
-        mpSurface(),
-        maSize()
+        mbHaveAlpha()
     {
     }
 
diff --git a/canvas/source/cairo/cairo_devicehelper.cxx b/canvas/source/cairo/cairo_devicehelper.cxx
index 1c44b4225560..5dacea7ae676 100644
--- a/canvas/source/cairo/cairo_devicehelper.cxx
+++ b/canvas/source/cairo/cairo_devicehelper.cxx
@@ -39,8 +39,7 @@ namespace cairocanvas
 {
     DeviceHelper::DeviceHelper() :
         mpSurfaceProvider( nullptr ),
-        mpRefDevice( nullptr ),
-        mpSurface()
+        mpRefDevice( nullptr )
     {
     }
 
diff --git a/canvas/source/cairo/cairo_spritecanvashelper.cxx b/canvas/source/cairo/cairo_spritecanvashelper.cxx
index 47bde21e6f25..992e0a581dcc 100644
--- a/canvas/source/cairo/cairo_spritecanvashelper.cxx
+++ b/canvas/source/cairo/cairo_spritecanvashelper.cxx
@@ -91,8 +91,6 @@ namespace cairocanvas
     SpriteCanvasHelper::SpriteCanvasHelper() :
         mpRedrawManager( nullptr ),
         mpOwningSpriteCanvas( nullptr ),
-        mpCompositingSurface(),
-        maCompositingSurfaceSize(),
         mbCompositingSurfaceDirty(true)
     {
     }
diff --git a/canvas/source/cairo/cairo_spritedevicehelper.cxx b/canvas/source/cairo/cairo_spritedevicehelper.cxx
index f2d018937be2..6539cf329a40 100644
--- a/canvas/source/cairo/cairo_spritedevicehelper.cxx
+++ b/canvas/source/cairo/cairo_spritedevicehelper.cxx
@@ -35,8 +35,6 @@ namespace cairocanvas
 
     SpriteDeviceHelper::SpriteDeviceHelper() :
         mpSpriteCanvas( nullptr ),
-        mpBufferSurface(),
-        maSize(),
         mbFullScreen( false )
     {}
 
diff --git a/canvas/source/cairo/cairo_spritehelper.cxx b/canvas/source/cairo/cairo_spritehelper.cxx
index 264c720e995e..b3806f0e94f1 100644
--- a/canvas/source/cairo/cairo_spritehelper.cxx
+++ b/canvas/source/cairo/cairo_spritehelper.cxx
@@ -38,8 +38,6 @@ using namespace ::com::sun::star;
 namespace cairocanvas
 {
     SpriteHelper::SpriteHelper() :
-        mpSpriteCanvas(),
-        mpBufferSurface(),
         mbTextureDirty(true)
     {}
 
diff --git a/canvas/source/cairo/cairo_textlayout.cxx b/canvas/source/cairo/cairo_textlayout.cxx
index 2f7abea5352f..6a1bfc27eece 100644
--- a/canvas/source/cairo/cairo_textlayout.cxx
+++ b/canvas/source/cairo/cairo_textlayout.cxx
@@ -77,7 +77,6 @@ namespace cairocanvas
                             const SurfaceProviderRef&           rRefDevice ) :
         TextLayout_Base( m_aMutex ),
         maText( aText ),
-        maLogicalAdvancements(),
         mpFont( rFont ),
         mpRefDevice( rRefDevice ),
         mnTextDirection( nDirection )
diff --git a/canvas/source/factory/cf_service.cxx b/canvas/source/factory/cf_service.cxx
index 8f16ce0db008..d7e612cb6ca9 100644
--- a/canvas/source/factory/cf_service.cxx
+++ b/canvas/source/factory/cf_service.cxx
@@ -108,13 +108,7 @@ public:
 };
 
 CanvasFactory::CanvasFactory( Reference<XComponentContext> const & xContext ) :
-    m_mutex(),
     m_xContext(xContext),
-    m_xCanvasConfigNameAccess(),
-    m_aAvailableImplementations(),
-    m_aAcceleratedImplementations(),
-    m_aAAImplementations(),
-    m_aCachedImplementations(),
     m_bCacheHasForcedLastImpl(),
     m_bCacheHasUseAcceleratedEntry(),
     m_bCacheHasUseAAEntry()
diff --git a/canvas/source/opengl/ogl_canvascustomsprite.cxx b/canvas/source/opengl/ogl_canvascustomsprite.cxx
index dcc0c15108cf..852933d33698 100644
--- a/canvas/source/opengl/ogl_canvascustomsprite.cxx
+++ b/canvas/source/opengl/ogl_canvascustomsprite.cxx
@@ -33,9 +33,6 @@ namespace oglcanvas
                                             SpriteDeviceHelper&                           rDeviceHelper ) :
         mpSpriteCanvas( rRefDevice ),
         maSize(rSpriteSize),
-        mxClip(),
-        maTransformation(),
-        maPosition(),
         mfAlpha(0.0),
         mfPriority(0.0)
     {
diff --git a/canvas/source/opengl/ogl_canvashelper.cxx b/canvas/source/opengl/ogl_canvashelper.cxx
index 0484f710ae53..b0264d8d1d31 100644
--- a/canvas/source/opengl/ogl_canvashelper.cxx
+++ b/canvas/source/opengl/ogl_canvashelper.cxx
@@ -342,8 +342,7 @@ namespace oglcanvas
 
     CanvasHelper::CanvasHelper() :
         mpDevice( nullptr ),
-        mpDeviceHelper( nullptr ),
-        mpRecordedActions()
+        mpDeviceHelper( nullptr )
     {}
 
     CanvasHelper::~CanvasHelper()
diff --git a/canvas/source/opengl/ogl_spritedevicehelper.cxx b/canvas/source/opengl/ogl_spritedevicehelper.cxx
index 553798aa9fd9..8cb0a6934f66 100644
--- a/canvas/source/opengl/ogl_spritedevicehelper.cxx
+++ b/canvas/source/opengl/ogl_spritedevicehelper.cxx
@@ -74,8 +74,6 @@ namespace oglcanvas
 
     SpriteDeviceHelper::SpriteDeviceHelper() :
         mpSpriteCanvas(nullptr),
-        maActiveSprites(),
-        maLastUpdate(),
         mpTextureCache(std::make_shared<TextureCache>()),
         mnLinearTwoColorGradientProgram(0),
         mnLinearMultiColorGradientProgram(0),
diff --git a/canvas/source/opengl/ogl_textlayout.cxx b/canvas/source/opengl/ogl_textlayout.cxx
index 622a78320f08..41962c8b1ea0 100644
--- a/canvas/source/opengl/ogl_textlayout.cxx
+++ b/canvas/source/opengl/ogl_textlayout.cxx
@@ -24,7 +24,6 @@ namespace oglcanvas
                             const CanvasFont::ImplRef&          rFont ) :
         TextLayoutBaseT( m_aMutex ),
         maText( aText ),
-        maLogicalAdvancements(),
         mpFont( rFont ),
         mnTextDirection( nDirection )
     {
diff --git a/canvas/source/simplecanvas/simplecanvasimpl.cxx b/canvas/source/simplecanvas/simplecanvasimpl.cxx
index c9b87265d1d6..6182d4e2142b 100644
--- a/canvas/source/simplecanvas/simplecanvasimpl.cxx
+++ b/canvas/source/simplecanvas/simplecanvasimpl.cxx
@@ -91,8 +91,7 @@ namespace
         explicit SimpleRenderState( uno::Reference<rendering::XGraphicDevice> const& xDevice ) :
             m_aPenColor( &color2Sequence),
             m_aFillColor( &color2Sequence ),
-            m_aRectClip( [&xDevice](geometry::RealRectangle2D const& rRect) { return rect2Poly(xDevice, rRect); } ),
-            m_aTransformation()
+            m_aRectClip( [&xDevice](geometry::RealRectangle2D const& rRect) { return rect2Poly(xDevice, rRect); } )
         {
             tools::setIdentityAffineMatrix2D( m_aTransformation );
         }
@@ -158,7 +157,6 @@ namespace
                    return mxCanvas->createFont(rFontRequest,
                                                uno::Sequence< beans::PropertyValue >(),
                                                geometry::Matrix2D()); } ),
-            maViewState(),
             maRenderState( mxCanvas->getDevice() )
         {
             tools::initViewState(maViewState);
diff --git a/canvas/source/tools/canvascustomspritehelper.cxx b/canvas/source/tools/canvascustomspritehelper.cxx
index 156936a05e53..c56980bf2ad8 100644
--- a/canvas/source/tools/canvascustomspritehelper.cxx
+++ b/canvas/source/tools/canvascustomspritehelper.cxx
@@ -146,12 +146,6 @@ namespace canvas
     }
 
     CanvasCustomSpriteHelper::CanvasCustomSpriteHelper() :
-        mpSpriteCanvas(),
-        maCurrClipBounds(),
-        maPosition(),
-        maSize(),
-        maTransform(),
-        mxClipPoly(),
         mfPriority(0.0),
         mfAlpha(0.0),
         mbActive(false),
diff --git a/canvas/source/tools/propertysethelper.cxx b/canvas/source/tools/propertysethelper.cxx
index 92f2e3bd28e4..3f8bd4a4eef9 100644
--- a/canvas/source/tools/propertysethelper.cxx
+++ b/canvas/source/tools/propertysethelper.cxx
@@ -57,9 +57,7 @@ namespace canvas
         };
     }
 
-    PropertySetHelper::PropertySetHelper() :
-        mpMap(),
-        maMapEntries()
+    PropertySetHelper::PropertySetHelper()
     {
     }
 
diff --git a/canvas/source/tools/spriteredrawmanager.cxx b/canvas/source/tools/spriteredrawmanager.cxx
index 443673093ff1..25ec64254acc 100644
--- a/canvas/source/tools/spriteredrawmanager.cxx
+++ b/canvas/source/tools/spriteredrawmanager.cxx
@@ -45,8 +45,6 @@ namespace canvas
         public:
             explicit SpriteTracer( const Sprite::Reference& rAffectedSprite ) :
                 mpAffectedSprite(rAffectedSprite),
-                maMoveStartArea(),
-                maMoveEndArea(),
                 mbIsMove( false ),
                 mbIsGenericUpdate( false )
             {
@@ -425,9 +423,7 @@ namespace canvas
                                 { return cp.second.needsUpdate(); } );
     }
 
-    SpriteRedrawManager::SpriteRedrawManager() :
-        maSprites(),
-        maChangeRecords()
+    SpriteRedrawManager::SpriteRedrawManager()
     {
     }
 
diff --git a/canvas/source/tools/surface.cxx b/canvas/source/tools/surface.cxx
index 10c2d4655343..9769931a636e 100644
--- a/canvas/source/tools/surface.cxx
+++ b/canvas/source/tools/surface.cxx
@@ -33,7 +33,6 @@ namespace canvas
                       const ::basegfx::B2ISize&    rSize ) :
         mpColorBuffer(rColorBuffer),
         mpPageManager(rPageManager),
-        mpFragment(),
         maSourceOffset(rPos),
         maSize(rSize),
         mbIsDirty(true)
diff --git a/canvas/source/tools/surfaceproxy.cxx b/canvas/source/tools/surfaceproxy.cxx
index b5c2b52f95b6..46b3d2cd3255 100644
--- a/canvas/source/tools/surfaceproxy.cxx
+++ b/canvas/source/tools/surfaceproxy.cxx
@@ -31,7 +31,6 @@ namespace canvas
     SurfaceProxy::SurfaceProxy( const std::shared_ptr<canvas::IColorBuffer>& pBuffer,
                                 const PageManagerSharedPtr&          pPageManager ) :
         mpPageManager( pPageManager ),
-        maSurfaceList(),
         mpBuffer( pBuffer )
     {
         const ::basegfx::B2ISize aImageSize(mpBuffer->getWidth(),mpBuffer->getHeight());
diff --git a/canvas/source/vcl/canvasbitmaphelper.cxx b/canvas/source/vcl/canvasbitmaphelper.cxx
index 00dc8bf03734..85b886d70814 100644
--- a/canvas/source/vcl/canvasbitmaphelper.cxx
+++ b/canvas/source/vcl/canvasbitmaphelper.cxx
@@ -34,9 +34,7 @@ using namespace ::com::sun::star;
 
 namespace vclcanvas
 {
-    CanvasBitmapHelper::CanvasBitmapHelper() :
-        mpBackBuffer(),
-        mpOutDevReference()
+    CanvasBitmapHelper::CanvasBitmapHelper()
     {
     }
 
diff --git a/canvas/source/vcl/canvashelper.cxx b/canvas/source/vcl/canvashelper.cxx
index a6cd6e0b6fd3..04fd39b95e70 100644
--- a/canvas/source/vcl/canvashelper.cxx
+++ b/canvas/source/vcl/canvashelper.cxx
@@ -104,9 +104,6 @@ namespace vclcanvas
 
     CanvasHelper::CanvasHelper() :
         mpDevice(),
-        mpProtectedOutDevProvider(),
-        mpOutDevProvider(),
-        mp2ndOutDevProvider(),
         mbHaveAlpha( false )
     {
     }
diff --git a/canvas/source/vcl/devicehelper.cxx b/canvas/source/vcl/devicehelper.cxx
index a16ede0f5236..40d2575f8883 100644
--- a/canvas/source/vcl/devicehelper.cxx
+++ b/canvas/source/vcl/devicehelper.cxx
@@ -33,8 +33,7 @@ using namespace ::com::sun::star;
 
 namespace vclcanvas
 {
-    DeviceHelper::DeviceHelper() :
-        mpOutDev()
+    DeviceHelper::DeviceHelper()
     {}
 
     void DeviceHelper::init( const OutDevProviderSharedPtr& rOutDev )
diff --git a/canvas/source/vcl/spritecanvashelper.cxx b/canvas/source/vcl/spritecanvashelper.cxx
index 1796c8ac7ffe..37a425e7a486 100644
--- a/canvas/source/vcl/spritecanvashelper.cxx
+++ b/canvas/source/vcl/spritecanvashelper.cxx
@@ -120,7 +120,6 @@ namespace vclcanvas
         mpRedrawManager( nullptr ),
         mpOwningSpriteCanvas( nullptr ),
         maVDev(VclPtr<VirtualDevice>::Create()),
-        maLastUpdate(),
         mbShowFrameInfo( false ),
         mbShowSpriteBounds( false ),
         mbIsUnsafeScrolling( false )
diff --git a/canvas/source/vcl/spritedevicehelper.cxx b/canvas/source/vcl/spritedevicehelper.cxx
index 150e3fcb42af..99f8b19145ce 100644
--- a/canvas/source/vcl/spritedevicehelper.cxx
+++ b/canvas/source/vcl/spritedevicehelper.cxx
@@ -31,8 +31,7 @@ using namespace ::com::sun::star;
 
 namespace vclcanvas
 {
-    SpriteDeviceHelper::SpriteDeviceHelper() :
-        mpBackBuffer()
+    SpriteDeviceHelper::SpriteDeviceHelper()
     {
     }
 
diff --git a/canvas/source/vcl/spritehelper.cxx b/canvas/source/vcl/spritehelper.cxx
index 57b38a9a2815..89cc33d7a2d4 100644
--- a/canvas/source/vcl/spritehelper.cxx
+++ b/canvas/source/vcl/spritehelper.cxx
@@ -46,9 +46,6 @@ using namespace ::com::sun::star;
 namespace vclcanvas
 {
     SpriteHelper::SpriteHelper() :
-        mpBackBuffer(),
-        mpBackBufferMask(),
-        maContent(),
         mbShowSpriteBounds(false)
     {
     }
diff --git a/canvas/source/vcl/textlayout.cxx b/canvas/source/vcl/textlayout.cxx
index 9beeee0d34d1..eee17aefe460 100644
--- a/canvas/source/vcl/textlayout.cxx
+++ b/canvas/source/vcl/textlayout.cxx
@@ -81,7 +81,6 @@ namespace vclcanvas
                             const OutDevProviderSharedPtr&                   rOutDev ) :
         TextLayout_Base( m_aMutex ),
         maText( aText ),
-        maLogicalAdvancements(),
         mpFont( rFont ),
         mxDevice( xDevice ),
         mpOutDevProvider( rOutDev ),
diff --git a/canvas/workben/canvasdemo.cxx b/canvas/workben/canvasdemo.cxx
index 85791072d860..8efdee81f36a 100644
--- a/canvas/workben/canvasdemo.cxx
+++ b/canvas/workben/canvasdemo.cxx
@@ -89,13 +89,9 @@ class DemoRenderer
                       uno::Reference< rendering::XCanvas > xCanvas,
                       Size aSize ) :
             maSize(aSize),
-            maBox(),
-            maViewState(),
-            maRenderState(),
             maColorBlack( vcl::unotools::colorToStdColorSpaceSequence( COL_BLACK) ),
             maColorRed( vcl::unotools::colorToStdColorSpaceSequence( COL_RED) ),
             mxCanvas(xCanvas),
-            mxDefaultFont(),
             mxDevice( xDevice )
         {
             // Geometry init