diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 08:37:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 11:20:07 +0200 |
| commit | c0cc59adca23580864a2e5cdadf66212246cbfcc (patch) | |
| tree | 57413c8efb3ca4a59f3699592353da1c575e345d /canvas | |
| parent | 4bf2052e9dbdfcd32a749747c918f2d714010633 (diff) | |
loplugin:singlevalfields improvement
look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr
Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'canvas')
| -rw-r--r-- | canvas/source/opengl/ogl_spritedevicehelper.cxx | 2 | ||||
| -rw-r--r-- | canvas/source/opengl/ogl_spritedevicehelper.hxx | 8 |
2 files changed, 0 insertions, 10 deletions
diff --git a/canvas/source/opengl/ogl_spritedevicehelper.cxx b/canvas/source/opengl/ogl_spritedevicehelper.cxx index 1764f3078765..82345bd7045a 100644 --- a/canvas/source/opengl/ogl_spritedevicehelper.cxx +++ b/canvas/source/opengl/ogl_spritedevicehelper.cxx @@ -77,7 +77,6 @@ namespace oglcanvas { SpriteDeviceHelper::SpriteDeviceHelper() : - mpDevice(nullptr), mpSpriteCanvas(nullptr), maActiveSprites(), maLastUpdate(), @@ -138,7 +137,6 @@ namespace oglcanvas { // release all references mpSpriteCanvas = nullptr; - mpDevice = nullptr; mpTextureCache.reset(); if( mxContext->isInitialized() ) diff --git a/canvas/source/opengl/ogl_spritedevicehelper.hxx b/canvas/source/opengl/ogl_spritedevicehelper.hxx index 38053f22100f..ddc6e27a3e04 100644 --- a/canvas/source/opengl/ogl_spritedevicehelper.hxx +++ b/canvas/source/opengl/ogl_spritedevicehelper.hxx @@ -115,14 +115,6 @@ namespace oglcanvas bool activateWindowContext(); private: - /** Phyical output device - - Deliberately not a refcounted reference, because of - potential circular references for canvas. Needed to - create bitmaps - */ - css::rendering::XGraphicDevice* mpDevice; - /// Pointer to sprite canvas (owner of this helper), needed to create bitmaps SpriteCanvas* mpSpriteCanvas; |