loplugin: new global analysis locking2

look for methods where we don't need to guard access
to the field, because the field is never modified

Change-Id: I62c33cc3f52881557515765d3733c4afc78547aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155836
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 0 insertions, 22 deletions

diff --git a/canvas/source/cairo/cairo_canvasfont.cxx b/canvas/source/cairo/cairo_canvasfont.cxx
index 82f300e8a205..2445f408853c 100644
--- a/canvas/source/cairo/cairo_canvasfont.cxx
+++ b/canvas/source/cairo/cairo_canvasfont.cxx
@@ -116,8 +116,6 @@ namespace cairocanvas
 
     rendering::FontRequest SAL_CALL  CanvasFont::getFontRequest(  )
     {
-        SolarMutexGuard aGuard;
-
         return maFontRequest;
     }
 
diff --git a/canvas/source/cairo/cairo_textlayout.cxx b/canvas/source/cairo/cairo_textlayout.cxx
index ff12a6092c13..31ef31fa7a49 100644
--- a/canvas/source/cairo/cairo_textlayout.cxx
+++ b/canvas/source/cairo/cairo_textlayout.cxx
@@ -244,8 +244,6 @@ namespace cairocanvas
 
     sal_Int8 SAL_CALL TextLayout::getMainTextDirection(  )
     {
-        std::unique_lock aGuard( m_aMutex );
-
         return mnTextDirection;
     }
 
@@ -258,8 +256,6 @@ namespace cairocanvas
 
     rendering::StringContext SAL_CALL TextLayout::getText(  )
     {
-        std::unique_lock aGuard( m_aMutex );
-
         return maText;
     }
 
diff --git a/canvas/source/opengl/ogl_canvasfont.cxx b/canvas/source/opengl/ogl_canvasfont.cxx
index 213dbe92b0e5..43a9d860b5ca 100644
--- a/canvas/source/opengl/ogl_canvasfont.cxx
+++ b/canvas/source/opengl/ogl_canvasfont.cxx
@@ -53,8 +53,6 @@ namespace oglcanvas
 
     rendering::FontRequest SAL_CALL CanvasFont::getFontRequest(  )
     {
-        std::unique_lock aGuard( m_aMutex );
-
         return maFontRequest;
     }
 
diff --git a/canvas/source/opengl/ogl_textlayout.cxx b/canvas/source/opengl/ogl_textlayout.cxx
index 4447aef5d828..a87365275436 100644
--- a/canvas/source/opengl/ogl_textlayout.cxx
+++ b/canvas/source/opengl/ogl_textlayout.cxx
@@ -175,8 +175,6 @@ namespace oglcanvas
 
     sal_Int8 SAL_CALL TextLayout::getMainTextDirection(  )
     {
-        std::unique_lock aGuard( m_aMutex );
-
         return mnTextDirection;
     }
 
@@ -189,8 +187,6 @@ namespace oglcanvas
 
     rendering::StringContext SAL_CALL TextLayout::getText(  )
     {
-        std::unique_lock aGuard( m_aMutex );
-
         return maText;
     }
 
diff --git a/canvas/source/tools/parametricpolypolygon.cxx b/canvas/source/tools/parametricpolypolygon.cxx
index acad3b58b7d6..8c660a5e5308 100644
--- a/canvas/source/tools/parametricpolypolygon.cxx
+++ b/canvas/source/tools/parametricpolypolygon.cxx
@@ -228,8 +228,6 @@ namespace canvas
 
     ParametricPolyPolygon::Values ParametricPolyPolygon::getValues() const
     {
-        std::unique_lock aGuard( m_aMutex );
-
         return maValues;
     }
 
diff --git a/canvas/source/vcl/canvasfont.cxx b/canvas/source/vcl/canvasfont.cxx
index 41b7da25016d..336f70d632f0 100644
--- a/canvas/source/vcl/canvasfont.cxx
+++ b/canvas/source/vcl/canvasfont.cxx
@@ -98,8 +98,6 @@ namespace vclcanvas
 
     rendering::FontRequest SAL_CALL  CanvasFont::getFontRequest(  )
     {
-        SolarMutexGuard aGuard;
-
         return maFontRequest;
     }
 
@@ -156,8 +154,6 @@ namespace vclcanvas
 
     const css::geometry::Matrix2D& CanvasFont::getFontMatrix() const
     {
-        SolarMutexGuard aGuard;
-
         return maFontMatrix;
     }
 }
diff --git a/canvas/source/vcl/textlayout.cxx b/canvas/source/vcl/textlayout.cxx
index 12273daf5933..d6474e744c32 100644
--- a/canvas/source/vcl/textlayout.cxx
+++ b/canvas/source/vcl/textlayout.cxx
@@ -324,8 +324,6 @@ namespace vclcanvas
 
     sal_Int8 SAL_CALL TextLayout::getMainTextDirection(  )
     {
-        SolarMutexGuard aGuard;
-
         return mnTextDirection;
     }
 
@@ -338,8 +336,6 @@ namespace vclcanvas
 
     rendering::StringContext SAL_CALL TextLayout::getText(  )
     {
-        SolarMutexGuard aGuard;
-
         return maText;
     }