diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-06 14:33:24 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-06 17:16:34 +0200 |
| commit | bce47223099bb3349d96af9d6b1fe88bcdd539df (patch) | |
| tree | 21e71197cf83f80657914bb529c459208a01547a /canvas | |
| parent | f4d4b100ffd18993d4eab1bcd52fe12b7f8f3e32 (diff) | |
clang-tidy bugprone-use-after-move in BitmapFilter::Filter
which necesitated changing the API and hence the call sites
Change-Id: Id417a235bf9b2bf1a3d152dc6600c0635486cafa
Reviewed-on: https://gerrit.libreoffice.org/60086
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'canvas')
| -rw-r--r-- | canvas/source/vcl/canvashelper.cxx | 3 | ||||
| -rw-r--r-- | canvas/source/vcl/spritehelper.cxx | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/canvas/source/vcl/canvashelper.cxx b/canvas/source/vcl/canvashelper.cxx index cdbf15cd6b88..c89a216ce092 100644 --- a/canvas/source/vcl/canvashelper.cxx +++ b/canvas/source/vcl/canvashelper.cxx @@ -720,7 +720,8 @@ namespace vclcanvas // transparency is fully transparent if( aBmpEx.IsAlpha() ) { - BitmapFilter::Filter(aBmpEx, BitmapAlphaClampFilter(253)); + BitmapAlphaClampFilter filter(253); + BitmapFilter::Filter(aBmpEx, filter); } mp2ndOutDevProvider->getOutDev().DrawBitmapEx( vcl::unotools::pointFromB2DPoint( aOutputPos ), diff --git a/canvas/source/vcl/spritehelper.cxx b/canvas/source/vcl/spritehelper.cxx index 123a6b64b2e4..1a1bc30f585f 100644 --- a/canvas/source/vcl/spritehelper.cxx +++ b/canvas/source/vcl/spritehelper.cxx @@ -158,7 +158,8 @@ namespace vclcanvas OSL_FAIL("CanvasCustomSprite::redraw(): Mask bitmap is not " "monochrome (performance!)"); BitmapEx aMaskEx(aMask); - BitmapFilter::Filter(aMaskEx, BitmapMonochromeFilter(255)); + BitmapMonochromeFilter filter(255); + BitmapFilter::Filter(aMaskEx, filter); aMask = aMaskEx.GetBitmap(); } #endif |