summaryrefslogtreecommitdiff
path: root/chart2/qa/extras/data/ods/tdf128432.ods
diff options
context:
space:
mode:
authorSahil Gautam <sahil.gautam.extern@allotropia.de>2025-03-18 16:51:03 +0530
committerThorsten Behrens <thorsten.behrens@allotropia.de>2025-03-20 18:24:20 +0100
commitddfce993c3d833171b92980476b11c985fb7693d (patch)
treed8cc9cfe77468a57ef52537f30ef9453ebc2a418 /chart2/qa/extras/data/ods/tdf128432.ods
parent6b67355f1275ea296a6a74c8f4d6a9060ff2f8a1 (diff)
tdf#165803 use COL_WHITE for DOCCOLOR for both light and dark modes HEADmaster
LibreOffice since 1995 has used light as the default background color for slides and documents. 'LibreOffice Themes' broke this behaviour as it depends on the hardcoded color values for the document colors. if the desktop environment is in dark mode, a dark document color is used. this causes issues for the slides created pre themes as they were created with white slide background. issues like black text on black background. this is also concerning because DOCCOLOR is not saved with the document, so if someone creates slides/documents with DOCCOLOR in mind, they would be disappointed to see the difference. so the simplest solution to this problem would be to use white color for both light and dark modes. since we would be using COL_WHITE for DOCCOLOR after this patch, it would be best change CALCGRID as well, to use a lighter shade of grey in dark mode (which would match the document color changes) changing DOCCOLOR value to COL_WHITE for dark mode broke a sd_tiledrendering test it was using the DOCCOLOR to check if dark or light theme is being used. commented that test out for now (just for this patch). reworking themes ui and implementation details to simplify the feature. Change-Id: Ib1ff7f2ca14110270baa8d6790d76696fd268183 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183071 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
Diffstat (limited to 'chart2/qa/extras/data/ods/tdf128432.ods')
0 files changed, 0 insertions, 0 deletions