diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-11-15 13:21:49 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-11-19 07:46:25 +0100 |
| commit | 193207c5abf339253e15b59f398da0c1f6f43bee (patch) | |
| tree | af181e0b4335d73b4db5b2ccf180779f7c82de5b /chart2/qa | |
| parent | b4b3949da1aad091b9f8d0f301f9f7031d6ce295 (diff) | |
improve loplugin passparamsbyref
I think I managed to disable this when I converted it to
use the shared plugin infrastructure.
So fix that, and then make it much smarter to avoid various
false positives.
Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2/qa')
| -rw-r--r-- | chart2/qa/extras/charttest.hxx | 2 | ||||
| -rw-r--r-- | chart2/qa/extras/uichart.cxx | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx index 8fb413a244f6..696e3c7ab164 100644 --- a/chart2/qa/extras/charttest.hxx +++ b/chart2/qa/extras/charttest.hxx @@ -62,7 +62,7 @@ using namespace css::uno; class ChartTest : public UnoApiXmlTest { public: - ChartTest(OUString path) + ChartTest(const OUString& path) : UnoApiXmlTest(path) { } diff --git a/chart2/qa/extras/uichart.cxx b/chart2/qa/extras/uichart.cxx index fe0c53a73bcf..e17d0e6daa20 100644 --- a/chart2/qa/extras/uichart.cxx +++ b/chart2/qa/extras/uichart.cxx @@ -21,13 +21,13 @@ public: { } - void testCopyPasteToNewSheet(uno::Reference<chart::XChartDocument> xChartDoc, + void testCopyPasteToNewSheet(const uno::Reference<chart::XChartDocument>& xChartDoc, OUString aObjectName, sal_Int32 nColumns, sal_Int32 nRows); }; -void Chart2UiChartTest::testCopyPasteToNewSheet(uno::Reference<chart::XChartDocument> xChartDoc, - OUString aObjectName, sal_Int32 nColumns, - sal_Int32 nRows) +void Chart2UiChartTest::testCopyPasteToNewSheet( + const uno::Reference<chart::XChartDocument>& xChartDoc, OUString aObjectName, + sal_Int32 nColumns, sal_Int32 nRows) { CPPUNIT_ASSERT(xChartDoc.is()); uno::Reference<chart::XChartDataArray> xChartData(xChartDoc->getData(), uno::UNO_QUERY_THROW); |