Improved loplugin:stringconstant (now that GCC 7 supports it): chart2

Change-Id: I9fb8e2853b5ddb1f9fe589f4e47828025ea52915
Reviewed-on: https://gerrit.libreoffice.org/76692
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

12 files changed, 27 insertions, 27 deletions

diff --git a/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx b/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx
index e1caf55e82376..9948a284eb187 100644
--- a/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx
@@ -106,7 +106,7 @@ void SAL_CALL AreaWrapper::setSize( const awt::Size& /*aSize*/ )
 // ____ XShapeDescriptor (base of XShape) ____
 OUString SAL_CALL AreaWrapper::getShapeType()
 {
-    return OUString( "com.sun.star.chart.ChartArea" );
+    return "com.sun.star.chart.ChartArea";
 }
 
 // ____ XComponent ____
@@ -157,7 +157,7 @@ std::vector< std::unique_ptr<WrappedProperty> > AreaWrapper::createWrappedProper
 
 OUString SAL_CALL AreaWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.Area");
+    return "com.sun.star.comp.chart.Area";
 }
 
 sal_Bool SAL_CALL AreaWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx b/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx
index c84037422de35..fd28c36a4ff7b 100644
--- a/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx
@@ -476,7 +476,7 @@ void SAL_CALL AxisWrapper::setSize( const awt::Size& /*aSize*/ )
 // ____ XShapeDescriptor (base of XShape) ____
 OUString SAL_CALL AxisWrapper::getShapeType()
 {
-    return OUString("com.sun.star.chart.ChartAxis");
+    return "com.sun.star.chart.ChartAxis";
 }
 
 // ____ XNumberFormatsSupplier ____
@@ -643,7 +643,7 @@ std::vector< std::unique_ptr<WrappedProperty> > AxisWrapper::createWrappedProper
 
 OUString SAL_CALL AxisWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.Axis");
+    return "com.sun.star.comp.chart.Axis";
 }
 
 sal_Bool SAL_CALL AxisWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx b/chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx
index 80b9ed8a77dd1..5696d6b5c3f49 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx
@@ -672,7 +672,7 @@ void ChartDataWrapper::applyData( lcl_Operator& rDataOperator )
 
 OUString SAL_CALL ChartDataWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.ChartData");
+    return "com.sun.star.comp.chart.ChartData";
 }
 
 sal_Bool SAL_CALL ChartDataWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
index c0d3f469cad03..046f8bd87ea4c 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
@@ -1410,7 +1410,7 @@ std::vector< std::unique_ptr<WrappedProperty> > ChartDocumentWrapper::createWrap
 
 OUString SAL_CALL ChartDocumentWrapper::getImplementationName()
 {
-    return OUString(CHART_CHARTAPIWRAPPER_IMPLEMENTATION_NAME);
+    return CHART_CHARTAPIWRAPPER_IMPLEMENTATION_NAME;
 }
 
 sal_Bool SAL_CALL ChartDocumentWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
index 813a51196def8..09ccd200521f9 100644
--- a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.cxx
@@ -831,7 +831,7 @@ Any SAL_CALL DataSeriesPointWrapper::getPropertyValue( const OUString& rProperty
 
 OUString SAL_CALL DataSeriesPointWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.DataSeries");
+    return "com.sun.star.comp.chart.DataSeries";
 }
 
 sal_Bool SAL_CALL DataSeriesPointWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx b/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
index 52e4c202a5125..3ba2fe5323dbd 100644
--- a/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
@@ -477,11 +477,11 @@ OUString lcl_getDiagramType( const OUString & rTemplateServiceName )
         // "Area" "StackedArea" "PercentStackedArea" "ThreeDArea"
         // "StackedThreeDArea" "PercentStackedThreeDArea"
         if( aName.indexOf( "Area" ) != -1 )
-            return OUString("com.sun.star.chart.AreaDiagram");
+            return "com.sun.star.chart.AreaDiagram";
 
         // "Pie" "PieAllExploded" "ThreeDPie" "ThreeDPieAllExploded"
         if( aName.indexOf( "Pie" ) != -1 )
-            return OUString("com.sun.star.chart.PieDiagram");
+            return "com.sun.star.chart.PieDiagram";
 
         // "Column" "StackedColumn" "PercentStackedColumn" "ThreeDColumnDeep"
         // "ThreeDColumnFlat" "StackedThreeDColumnFlat"
@@ -490,33 +490,33 @@ OUString lcl_getDiagramType( const OUString & rTemplateServiceName )
         // "StackedThreeDBarFlat" "PercentStackedThreeDBarFlat" "ColumnWithLine"
         // "StackedColumnWithLine"
         if( aName.indexOf( "Column" ) != -1 || aName.indexOf( "Bar" ) != -1 )
-            return OUString( "com.sun.star.chart.BarDiagram" );
+            return "com.sun.star.chart.BarDiagram";
 
         // "Donut" "DonutAllExploded" "ThreeDDonut" "ThreeDDonutAllExploded"
         if( aName.indexOf( "Donut" ) != -1 )
-            return OUString( "com.sun.star.chart.DonutDiagram" );
+            return "com.sun.star.chart.DonutDiagram";
 
         // "ScatterLineSymbol" "ScatterLine" "ScatterSymbol" "ThreeDScatter"
         if( aName.indexOf( "Scatter" ) != -1 )
-            return OUString( "com.sun.star.chart.XYDiagram" );
+            return "com.sun.star.chart.XYDiagram";
 
         // "FilledNet" "StackedFilledNet" "PercentStackedFilledNet"
         if( aName.indexOf( "FilledNet" ) != -1 )
-            return OUString( "com.sun.star.chart.FilledNetDiagram" );
+            return "com.sun.star.chart.FilledNetDiagram";
 
         // "Net" "NetSymbol" "NetLine" "StackedNet" "StackedNetSymbol"
         // "StackedNetLine" "PercentStackedNet" "PercentStackedNetSymbol"
         // "PercentStackedNetLine"
         if( aName.indexOf( "Net" ) != -1 )
-            return OUString( "com.sun.star.chart.NetDiagram" );
+            return "com.sun.star.chart.NetDiagram";
 
         // "StockLowHighClose" "StockOpenLowHighClose" "StockVolumeLowHighClose"
         // "StockVolumeOpenLowHighClose"
         if( aName.indexOf( "Stock" ) != -1 )
-            return OUString( "com.sun.star.chart.StockDiagram" );
+            return "com.sun.star.chart.StockDiagram";
 
         if( aName.indexOf( "Bubble" ) != -1 )
-            return OUString( "com.sun.star.chart.BubbleDiagram" );
+            return "com.sun.star.chart.BubbleDiagram";
 
         // Note: this must be checked after Bar, Net and Scatter
 
@@ -525,7 +525,7 @@ OUString lcl_getDiagramType( const OUString & rTemplateServiceName )
         // "PercentStackedLineSymbol" "ThreeDLine" "StackedThreeDLine"
         // "PercentStackedThreeDLine" "ThreeDLineDeep"
         if( aName.indexOf( "Line" ) != -1 || aName.indexOf( "Symbol" ) != -1 )
-            return OUString( "com.sun.star.chart.LineDiagram" );
+            return "com.sun.star.chart.LineDiagram";
 
         OSL_FAIL( "unknown template" );
     }
@@ -729,7 +729,7 @@ void SAL_CALL DiagramWrapper::setSize( const awt::Size& aSize )
 // ____ XShapeDescriptor (base of XShape) ____
 OUString SAL_CALL DiagramWrapper::getShapeType()
 {
-    return OUString( "com.sun.star.chart.Diagram" );
+    return "com.sun.star.chart.Diagram";
 }
 
 // ____ XDiagramPositioning ____
@@ -1869,7 +1869,7 @@ std::vector< std::unique_ptr<WrappedProperty> > DiagramWrapper::createWrappedPro
 
 OUString SAL_CALL DiagramWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.Diagram");
+    return "com.sun.star.comp.chart.Diagram";
 }
 
 sal_Bool SAL_CALL DiagramWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/GridWrapper.cxx b/chart2/source/controller/chartapiwrapper/GridWrapper.cxx
index c699e51db73a2..aee6ad0aa6724 100644
--- a/chart2/source/controller/chartapiwrapper/GridWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/GridWrapper.cxx
@@ -166,7 +166,7 @@ std::vector< std::unique_ptr<WrappedProperty> > GridWrapper::createWrappedProper
 
 OUString SAL_CALL GridWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.Grid");
+    return "com.sun.star.comp.chart.Grid";
 }
 
 sal_Bool SAL_CALL GridWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/LegendWrapper.cxx b/chart2/source/controller/chartapiwrapper/LegendWrapper.cxx
index 038015c122572..994dfcd034e42 100644
--- a/chart2/source/controller/chartapiwrapper/LegendWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/LegendWrapper.cxx
@@ -314,7 +314,7 @@ void SAL_CALL LegendWrapper::setSize( const awt::Size& aSize )
 // ____ XShapeDescriptor (base of XShape) ____
 OUString SAL_CALL LegendWrapper::getShapeType()
 {
-    return OUString( "com.sun.star.chart.ChartLegend" );
+    return "com.sun.star.chart.ChartLegend";
 }
 
 // ____ XComponent ____
@@ -398,7 +398,7 @@ std::vector< std::unique_ptr<WrappedProperty> > LegendWrapper::createWrappedProp
 
 OUString SAL_CALL LegendWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.Legend");
+    return "com.sun.star.comp.chart.Legend";
 }
 
 sal_Bool SAL_CALL LegendWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx b/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx
index f7edd83c45ab3..f38ff93c9bef7 100644
--- a/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/MinMaxLineWrapper.cxx
@@ -377,7 +377,7 @@ uno::Sequence< uno::Any > SAL_CALL MinMaxLineWrapper::getPropertyDefaults( const
 
 OUString SAL_CALL MinMaxLineWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.ChartLine");
+    return "com.sun.star.comp.chart.ChartLine";
 }
 
 sal_Bool SAL_CALL MinMaxLineWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx b/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
index d46cc6c9ce015..8a30633ac935c 100644
--- a/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/TitleWrapper.cxx
@@ -232,7 +232,7 @@ void SAL_CALL TitleWrapper::setSize( const awt::Size& /*aSize*/ )
 // ____ XShapeDescriptor (base of XShape) ____
 OUString SAL_CALL TitleWrapper::getShapeType()
 {
-    return OUString( "com.sun.star.chart.ChartTitle" );
+    return "com.sun.star.chart.ChartTitle";
 }
 
 // ____ XComponent ____
@@ -482,7 +482,7 @@ std::vector< std::unique_ptr<WrappedProperty> > TitleWrapper::createWrappedPrope
 
 OUString SAL_CALL TitleWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.Title");
+    return "com.sun.star.comp.chart.Title";
 }
 
 sal_Bool SAL_CALL TitleWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/UpDownBarWrapper.cxx b/chart2/source/controller/chartapiwrapper/UpDownBarWrapper.cxx
index ecc5ebbe4a925..0343c29530a87 100644
--- a/chart2/source/controller/chartapiwrapper/UpDownBarWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/UpDownBarWrapper.cxx
@@ -344,7 +344,7 @@ uno::Sequence< uno::Any > SAL_CALL UpDownBarWrapper::getPropertyDefaults( const
 
 OUString SAL_CALL UpDownBarWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.ChartArea");
+    return "com.sun.star.comp.chart.ChartArea";
 }
 
 sal_Bool SAL_CALL UpDownBarWrapper::supportsService( const OUString& rServiceName )
diff --git a/chart2/source/controller/chartapiwrapper/WallFloorWrapper.cxx b/chart2/source/controller/chartapiwrapper/WallFloorWrapper.cxx
index 5d70880fe1c29..b95872fb41463 100644
--- a/chart2/source/controller/chartapiwrapper/WallFloorWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/WallFloorWrapper.cxx
@@ -148,7 +148,7 @@ std::vector< std::unique_ptr<WrappedProperty> > WallFloorWrapper::createWrappedP
 
 OUString SAL_CALL WallFloorWrapper::getImplementationName()
 {
-    return OUString("com.sun.star.comp.chart.WallOrFloor");
+    return "com.sun.star.comp.chart.WallOrFloor";
 }
 
 sal_Bool SAL_CALL WallFloorWrapper::supportsService( const OUString& rServiceName )