diff options
author | Kohei Yoshida <kohei.yoshida@collabora.com> | 2014-07-21 19:55:03 -0400 |
---|---|---|
committer | Kohei Yoshida <kohei.yoshida@collabora.com> | 2014-07-21 20:31:24 -0400 |
commit | 9e970303ddcccd9e33641f8f00bbc4c739a58cd7 (patch) | |
tree | 8d04e4966c5b38c08e78a010c358a9aab06f9676 /chart2/source/controller/itemsetwrapper | |
parent | b2ffa40c12024886c3c6fd36d198aed2f8434fde (diff) |
Remove auto_ptr from CharacterPropertyItemConverter.
And adjust all that's necessary.
Change-Id: I121e5aa4d117da2e5e6b11e4fd85960a8b3aa727
Diffstat (limited to 'chart2/source/controller/itemsetwrapper')
7 files changed, 67 insertions, 120 deletions
diff --git a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx index e3b71752a751..30f014ea801a 100644 --- a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx @@ -70,12 +70,8 @@ namespace }; } // anonymous namespace -namespace chart -{ -namespace wrapper -{ +namespace chart { namespace wrapper { -SAL_WNODEPRECATED_DECLARATIONS_PUSH AxisItemConverter::AxisItemConverter( const Reference< beans::XPropertySet > & rPropertySet, SfxItemPool& rItemPool, @@ -83,7 +79,7 @@ AxisItemConverter::AxisItemConverter( const Reference< chart2::XChartDocument > & xChartDoc, ::chart::ExplicitScaleData * pScale /* = NULL */, ::chart::ExplicitIncrementData * pIncrement /* = NULL */, - ::std::auto_ptr< awt::Size > pRefSize /* = NULL */ ) : + const awt::Size* pRefSize ) : ItemConverter( rPropertySet, rItemPool ), m_xChartDoc( xChartDoc ), m_pExplicitScale( NULL ), @@ -100,13 +96,12 @@ AxisItemConverter::AxisItemConverter( rPropertySet, rItemPool, rDrawModel, xNamedPropertyContainerFactory, GraphicPropertyItemConverter::LINE_PROPERTIES )); - m_aConverters.push_back( new CharacterPropertyItemConverter( rPropertySet, rItemPool, pRefSize, - "ReferencePageSize" )); + m_aConverters.push_back( + new CharacterPropertyItemConverter(rPropertySet, rItemPool, pRefSize, "ReferencePageSize")); m_xAxis.set( Reference< chart2::XAxis >( rPropertySet, uno::UNO_QUERY ) ); OSL_ASSERT( m_xAxis.is()); } -SAL_WNODEPRECATED_DECLARATIONS_POP AxisItemConverter::~AxisItemConverter() { @@ -993,7 +988,6 @@ bool AxisItemConverter::ApplySpecialItem( sal_uInt16 nWhichId, const SfxItemSet return (bSetScale || bChangedOtherwise); } -} // namespace wrapper -} // namespace chart +}} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx b/chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx index 9619f009acc1..97bf8c87123f 100644 --- a/chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/CharacterPropertyItemConverter.cxx @@ -64,10 +64,7 @@ namespace } } // anonymous namespace -namespace chart -{ -namespace wrapper -{ +namespace chart { namespace wrapper { CharacterPropertyItemConverter::CharacterPropertyItemConverter( const uno::Reference< beans::XPropertySet > & rPropertySet, @@ -75,19 +72,19 @@ CharacterPropertyItemConverter::CharacterPropertyItemConverter( ItemConverter( rPropertySet, rItemPool ) {} -SAL_WNODEPRECATED_DECLARATIONS_PUSH CharacterPropertyItemConverter::CharacterPropertyItemConverter( const uno::Reference< beans::XPropertySet > & rPropertySet, SfxItemPool& rItemPool, - ::std::auto_ptr< awt::Size > pRefSize, + const awt::Size* pRefSize, const OUString & rRefSizePropertyName, const uno::Reference< beans::XPropertySet > & rRefSizePropSet ) : ItemConverter( rPropertySet, rItemPool ), - m_pRefSize( pRefSize ), m_aRefSizePropertyName( rRefSizePropertyName ), m_xRefSizePropSet( rRefSizePropSet.is() ? rRefSizePropSet : rPropertySet ) -{} -SAL_WNODEPRECATED_DECLARATIONS_POP +{ + if (pRefSize) + m_pRefSize.reset(*pRefSize); +} CharacterPropertyItemConverter::~CharacterPropertyItemConverter() {} @@ -268,7 +265,7 @@ void CharacterPropertyItemConverter::FillSpecialItem( float fHeight; if( aValue >>= fHeight ) { - if( m_pRefSize.get()) + if (m_pRefSize) { awt::Size aOldRefSize; if( GetRefSizePropertySet()->getPropertyValue( m_aRefSizePropertyName ) >>= aOldRefSize ) @@ -518,7 +515,7 @@ bool CharacterPropertyItemConverter::ApplySpecialItem( bSetValue = true; else { - if( m_pRefSize.get() ) + if (m_pRefSize) { awt::Size aNewRefSize = *m_pRefSize; awt::Size aOldRefSize; @@ -533,11 +530,10 @@ bool CharacterPropertyItemConverter::ApplySpecialItem( if( bSetValue ) { // set new reference size only if there was a reference size before (auto-scaling on) - if( m_pRefSize.get() && - GetRefSizePropertySet()->getPropertyValue( m_aRefSizePropertyName ).hasValue()) + if (m_pRefSize && GetRefSizePropertySet()->getPropertyValue( m_aRefSizePropertyName ).hasValue()) { - GetRefSizePropertySet()->setPropertyValue( m_aRefSizePropertyName, - uno::makeAny( *m_pRefSize )); + GetRefSizePropertySet()->setPropertyValue( + m_aRefSizePropertyName, uno::makeAny(*m_pRefSize)); } GetPropertySet()->setPropertyValue( "CharHeight" + aPostfix, aValue ); @@ -556,7 +552,11 @@ bool CharacterPropertyItemConverter::ApplySpecialItem( return bChanged; } -} // namespace wrapper -} // namespace chart +uno::Reference<beans::XPropertySet> CharacterPropertyItemConverter::GetRefSizePropertySet() const +{ + return m_xRefSizePropSet; +} + +}} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx b/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx index 6e8cbc3956ab..2c126dee085b 100644 --- a/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx @@ -190,12 +190,8 @@ bool lcl_UseSourceFormatFromItemToPropertySet( sal_uInt16 nWhichId, const SfxIte } // anonymous namespace -namespace chart -{ -namespace wrapper -{ +namespace chart { namespace wrapper { -SAL_WNODEPRECATED_DECLARATIONS_PUSH DataPointItemConverter::DataPointItemConverter( const uno::Reference< frame::XModel > & xChartModel, const uno::Reference< uno::XComponentContext > & xContext, @@ -203,16 +199,15 @@ DataPointItemConverter::DataPointItemConverter( const uno::Reference< XDataSeries > & xSeries, SfxItemPool& rItemPool, SdrModel& rDrawModel, - const uno::Reference< lang::XMultiServiceFactory > & xNamedPropertyContainerFactory, - GraphicPropertyItemConverter::eGraphicObjectType eMapTo /* = FILL_PROPERTIES */, - ::std::auto_ptr< awt::Size > pRefSize /* = NULL */, - bool bDataSeries /* = false */, - bool bUseSpecialFillColor /* = false */, - sal_Int32 nSpecialFillColor /* =0 */, - bool bOverwriteLabelsForAttributedDataPointsAlso /*false*/, + const uno::Reference<lang::XMultiServiceFactory>& xNamedPropertyContainerFactory, + GraphicPropertyItemConverter::eGraphicObjectType eMapTo, + const awt::Size* pRefSize, + bool bDataSeries, + bool bUseSpecialFillColor, + sal_Int32 nSpecialFillColor, + bool bOverwriteLabelsForAttributedDataPointsAlso, sal_Int32 nNumberFormat, - sal_Int32 nPercentNumberFormat - ) : + sal_Int32 nPercentNumberFormat ) : ItemConverter( rPropertySet, rItemPool ), m_bDataSeries( bDataSeries ), m_bOverwriteLabelsForAttributedDataPointsAlso(m_bDataSeries && bOverwriteLabelsForAttributedDataPointsAlso), @@ -225,7 +220,7 @@ DataPointItemConverter::DataPointItemConverter( { m_aConverters.push_back( new GraphicPropertyItemConverter( rPropertySet, rItemPool, rDrawModel, xNamedPropertyContainerFactory, eMapTo )); - m_aConverters.push_back( new CharacterPropertyItemConverter( rPropertySet, rItemPool, pRefSize, "ReferencePageSize")); + m_aConverters.push_back( new CharacterPropertyItemConverter(rPropertySet, rItemPool, pRefSize, "ReferencePageSize")); if( bDataSeries ) { m_aConverters.push_back( new StatisticsItemConverter( xChartModel, rPropertySet, rItemPool )); @@ -241,7 +236,6 @@ DataPointItemConverter::DataPointItemConverter( m_bForbidPercentValue = AxisType::CATEGORY != ChartTypeHelper::getAxisType( xChartType, 0 ); } -SAL_WNODEPRECATED_DECLARATIONS_POP DataPointItemConverter::~DataPointItemConverter() { @@ -674,7 +668,6 @@ void DataPointItemConverter::FillSpecialItem( } } -} // namespace wrapper -} // namespace chart +}} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/chart2/source/controller/itemsetwrapper/LegendItemConverter.cxx b/chart2/source/controller/itemsetwrapper/LegendItemConverter.cxx index 31e1e3ca0b91..a82664aedfc5 100644 --- a/chart2/source/controller/itemsetwrapper/LegendItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/LegendItemConverter.cxx @@ -54,7 +54,7 @@ LegendItemConverter::LegendItemConverter( rPropertySet, rItemPool, rDrawModel, xNamedPropertyContainerFactory, GraphicPropertyItemConverter::LINE_AND_FILL_PROPERTIES )); m_aConverters.push_back( new CharacterPropertyItemConverter( - rPropertySet, rItemPool, pRefSize, + rPropertySet, rItemPool, pRefSize.get(), "ReferencePageSize" )); } SAL_WNODEPRECATED_DECLARATIONS_POP diff --git a/chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx b/chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx index 99ea0eeca82a..934e961fa204 100644 --- a/chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx +++ b/chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx @@ -32,23 +32,21 @@ #include "chartview/ExplicitValueProvider.hxx" #include "DiagramHelper.hxx" +#include <boost/scoped_ptr.hpp> + using namespace ::com::sun::star; using namespace ::com::sun::star::chart2; using ::com::sun::star::uno::Reference; using ::com::sun::star::uno::Sequence; -namespace chart -{ -namespace wrapper -{ +namespace chart { namespace wrapper { -SAL_WNODEPRECATED_DECLARATIONS_PUSH AllAxisItemConverter::AllAxisItemConverter( const uno::Reference< frame::XModel > & xChartModel, SfxItemPool& rItemPool, SdrModel& rDrawModel, const uno::Reference< lang::XMultiServiceFactory > & /*xNamedPropertyContainerFactory*/, - ::std::auto_ptr< awt::Size > pRefSize ) + const awt::Size* pRefSize ) : MultipleItemConverter( rItemPool ) { Reference< XDiagram > xDiagram( ChartModelHelper::findDiagram( xChartModel ) ); @@ -56,18 +54,12 @@ AllAxisItemConverter::AllAxisItemConverter( for( sal_Int32 nA = 0; nA < aElementList.getLength(); nA++ ) { uno::Reference< beans::XPropertySet > xObjectProperties(aElementList[nA], uno::UNO_QUERY); - if( pRefSize.get()) - m_aConverters.push_back( new ::chart::wrapper::AxisItemConverter( - xObjectProperties, rItemPool, rDrawModel, - uno::Reference< chart2::XChartDocument >( xChartModel, uno::UNO_QUERY ), 0, 0, - ::std::auto_ptr< awt::Size >( new awt::Size( *pRefSize )) )); - else - m_aConverters.push_back( new ::chart::wrapper::AxisItemConverter( - xObjectProperties, rItemPool, rDrawModel, - uno::Reference< chart2::XChartDocument >( xChartModel, uno::UNO_QUERY ), 0, 0 ) ); + m_aConverters.push_back( new ::chart::wrapper::AxisItemConverter( + xObjectProperties, rItemPool, rDrawModel, + uno::Reference< chart2::XChartDocument >( xChartModel, uno::UNO_QUERY ), 0, 0, + pRefSize)); } } -SAL_WNODEPRECATED_DECLARATIONS_POP AllAxisItemConverter::~AllAxisItemConverter() { @@ -107,13 +99,12 @@ const sal_uInt16 * AllGridItemConverter::GetWhichPairs() const return nGridWhichPairs; } -SAL_WNODEPRECATED_DECLARATIONS_PUSH AllDataLabelItemConverter::AllDataLabelItemConverter( const uno::Reference< frame::XModel > & xChartModel, SfxItemPool& rItemPool, SdrModel& rDrawModel, const uno::Reference< lang::XMultiServiceFactory > & xNamedPropertyContainerFactory, - ::std::auto_ptr< awt::Size > pRefSize ) + const awt::Size* pRefSize ) : MultipleItemConverter( rItemPool ) { ::std::vector< uno::Reference< chart2::XDataSeries > > aSeriesList( @@ -129,21 +120,13 @@ AllDataLabelItemConverter::AllDataLabelItemConverter( sal_Int32 nPercentNumberFormat=ExplicitValueProvider::getExplicitPercentageNumberFormatKeyForDataLabel( xObjectProperties,uno::Reference< util::XNumberFormatsSupplier >(xChartModel, uno::UNO_QUERY)); - m_aConverters.push_back( new ::chart::wrapper::DataPointItemConverter( - xChartModel, xContext, - xObjectProperties, *aIt, rItemPool, rDrawModel, - xNamedPropertyContainerFactory, - GraphicPropertyItemConverter::FILLED_DATA_POINT, - ::std::auto_ptr< awt::Size >( pRefSize.get() ? new awt::Size( *pRefSize ) : 0), - true, /*bDataSeries*/ - false, /*bUseSpecialFillColor*/ - 0, /*nSpecialFillColor*/ - true /*bOverwriteLabelsForAttributedDataPointsAlso*/, - nNumberFormat, nPercentNumberFormat - )); + m_aConverters.push_back( + new ::chart::wrapper::DataPointItemConverter( + xChartModel, xContext, xObjectProperties, *aIt, rItemPool, rDrawModel, + xNamedPropertyContainerFactory, GraphicPropertyItemConverter::FILLED_DATA_POINT, + pRefSize, true, false, 0, true, nNumberFormat, nPercentNumberFormat)); } } -SAL_WNODEPRECATED_DECLARATIONS_POP AllDataLabelItemConverter::~AllDataLabelItemConverter() { @@ -155,13 +138,12 @@ const sal_uInt16 * AllDataLabelItemConverter::GetWhichPairs() const return nDataLabelWhichPairs; } -SAL_WNODEPRECATED_DECLARATIONS_PUSH AllTitleItemConverter::AllTitleItemConverter( const uno::Reference< frame::XModel > & xChartModel, SfxItemPool& rItemPool, SdrModel& rDrawModel, const uno::Reference< lang::XMultiServiceFactory > & xNamedPropertyContainerFactory, - ::std::auto_ptr< awt::Size > pRefSize ) + const awt::Size* pRefSize ) : MultipleItemConverter( rItemPool ) { for(sal_Int32 nTitle = TitleHelper::TITLE_BEGIN; nTitle < TitleHelper::NORMAL_TITLE_END; nTitle++ ) @@ -170,14 +152,11 @@ AllTitleItemConverter::AllTitleItemConverter( if(!xTitle.is()) continue; uno::Reference< beans::XPropertySet > xObjectProperties( xTitle, uno::UNO_QUERY); - ::std::auto_ptr< awt::Size > pSingleRefSize(0); - if( pRefSize.get()) - pSingleRefSize = ::std::auto_ptr< awt::Size >( new awt::Size( *pRefSize )); - m_aConverters.push_back( new ::chart::wrapper::TitleItemConverter( - xObjectProperties, rItemPool, rDrawModel, xNamedPropertyContainerFactory, pSingleRefSize )); + m_aConverters.push_back( + new ::chart::wrapper::TitleItemConverter( + xObjectProperties, rItemPool, rDrawModel, xNamedPropertyContainerFactory, pRefSize)); } } -SAL_WNODEPRECATED_DECLARATIONS_POP AllTitleItemConverter::~AllTitleItemConverter() { @@ -215,7 +194,6 @@ const sal_uInt16 * AllSeriesStatisticsConverter::GetWhichPairs() const return nStatWhichPairs; } -} // namespace wrapper -} // namespace chart +}} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/chart2/source/controller/itemsetwrapper/RegressionEquationItemConverter.cxx b/chart2/source/controller/itemsetwrapper/RegressionEquationItemConverter.cxx index 4cf5baa758dd..d41096270ef0 100644 --- a/chart2/source/controller/itemsetwrapper/RegressionEquationItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/RegressionEquationItemConverter.cxx @@ -44,19 +44,15 @@ namespace }; } // anonymous namespace -namespace chart -{ -namespace wrapper -{ +namespace chart { namespace wrapper { -SAL_WNODEPRECATED_DECLARATIONS_PUSH RegressionEquationItemConverter::RegressionEquationItemConverter( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > & rPropertySet, SfxItemPool& rItemPool, SdrModel& rDrawModel, const uno::Reference< lang::XMultiServiceFactory > & xNamedPropertyContainerFactory, - ::std::auto_ptr< ::com::sun::star::awt::Size > pRefSize ) : + const awt::Size* pRefSize ) : ItemConverter( rPropertySet, rItemPool ) { m_aConverters.push_back( new GraphicPropertyItemConverter( @@ -64,10 +60,9 @@ RegressionEquationItemConverter::RegressionEquationItemConverter( xNamedPropertyContainerFactory, GraphicPropertyItemConverter::LINE_AND_FILL_PROPERTIES )); - m_aConverters.push_back( new CharacterPropertyItemConverter( - rPropertySet, rItemPool, pRefSize, "ReferencePageSize")); + m_aConverters.push_back( + new CharacterPropertyItemConverter(rPropertySet, rItemPool, pRefSize, "ReferencePageSize")); } -SAL_WNODEPRECATED_DECLARATIONS_POP RegressionEquationItemConverter::~RegressionEquationItemConverter() { @@ -156,7 +151,6 @@ void RegressionEquationItemConverter::FillSpecialItem( } } -} // namespace wrapper -} // namespace chart +}} /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/chart2/source/controller/itemsetwrapper/TitleItemConverter.cxx b/chart2/source/controller/itemsetwrapper/TitleItemConverter.cxx index 2593499ec939..71d3230cb3b6 100644 --- a/chart2/source/controller/itemsetwrapper/TitleItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/TitleItemConverter.cxx @@ -47,53 +47,44 @@ namespace }; } // anonymous namespace -namespace chart -{ -namespace wrapper -{ +namespace chart { namespace wrapper { class FormattedStringsConverter : public ::comphelper::MultipleItemConverter { public: - SAL_WNODEPRECATED_DECLARATIONS_PUSH FormattedStringsConverter( const uno::Sequence< uno::Reference< chart2::XFormattedString > > & aStrings, SfxItemPool & rItemPool, - ::std::auto_ptr< awt::Size > pRefSize, + const awt::Size* pRefSize, const uno::Reference< beans::XPropertySet > & xParentProp ); - SAL_WNODEPRECATED_DECLARATIONS_POP virtual ~FormattedStringsConverter(); protected: virtual const sal_uInt16 * GetWhichPairs() const SAL_OVERRIDE; }; -SAL_WNODEPRECATED_DECLARATIONS_PUSH FormattedStringsConverter::FormattedStringsConverter( const uno::Sequence< uno::Reference< chart2::XFormattedString > > & aStrings, SfxItemPool & rItemPool, - ::std::auto_ptr< ::com::sun::star::awt::Size > pRefSize, + const awt::Size* pRefSize, const uno::Reference< beans::XPropertySet > & xParentProp ) : MultipleItemConverter( rItemPool ) { - bool bHasRefSize = (pRefSize.get() && xParentProp.is()); + bool bHasRefSize = (pRefSize && xParentProp.is()); for( sal_Int32 i = 0; i < aStrings.getLength(); ++i ) { uno::Reference< beans::XPropertySet > xProp( aStrings[ i ], uno::UNO_QUERY ); if( xProp.is()) { if( bHasRefSize ) - m_aConverters.push_back( new CharacterPropertyItemConverter( - xProp, rItemPool, - ::std::auto_ptr< awt::Size >( new awt::Size( *pRefSize )), - "ReferencePageSize" , - xParentProp )); + m_aConverters.push_back( + new CharacterPropertyItemConverter( + xProp, rItemPool, pRefSize, "ReferencePageSize", xParentProp)); else m_aConverters.push_back( new CharacterPropertyItemConverter( xProp, rItemPool )); } } } -SAL_WNODEPRECATED_DECLARATIONS_POP FormattedStringsConverter::~FormattedStringsConverter() { @@ -104,14 +95,12 @@ const sal_uInt16 * FormattedStringsConverter::GetWhichPairs() const return nCharacterPropertyWhichPairs; } -SAL_WNODEPRECATED_DECLARATIONS_PUSH TitleItemConverter::TitleItemConverter( - const ::com::sun::star::uno::Reference< - ::com::sun::star::beans::XPropertySet > & rPropertySet, + const uno::Reference<beans::XPropertySet> & rPropertySet, SfxItemPool& rItemPool, SdrModel& rDrawModel, const uno::Reference< lang::XMultiServiceFactory > & xNamedPropertyContainerFactory, - ::std::auto_ptr< ::com::sun::star::awt::Size > pRefSize ) : + const awt::Size* pRefSize ) : ItemConverter( rPropertySet, rItemPool ) { m_aConverters.push_back( new GraphicPropertyItemConverter( @@ -132,7 +121,6 @@ TitleItemConverter::TitleItemConverter( } } } -SAL_WNODEPRECATED_DECLARATIONS_POP TitleItemConverter::~TitleItemConverter() { |