diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-08-01 08:40:47 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-08-01 11:06:26 +0200 |
commit | 612b489d3e05b24c1b6690082e8518bac033e9d2 (patch) | |
tree | 23a6c556989071385d1c64730ed72bdbae7c239c /chart2/source/controller | |
parent | 17e14d459dea201b57be2d8e677fa776ead03291 (diff) |
loplugin:checkunusedparams
the "check for taking address of function" part was generating false+
Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f
Reviewed-on: https://gerrit.libreoffice.org/40613
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2/source/controller')
12 files changed, 14 insertions, 21 deletions
diff --git a/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx index f7214e3e2946..245fc313558a 100644 --- a/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx +++ b/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx @@ -153,7 +153,7 @@ void WrappedAxisAndGridExistenceProperty::setPropertyValue( const Any& rOuterVal if( m_bAxis ) AxisHelper::showAxis( m_nDimensionIndex, m_bMain, xDiagram, m_spChart2ModelContact->m_xContext ); else - AxisHelper::showGrid( m_nDimensionIndex, 0, m_bMain, xDiagram, m_spChart2ModelContact->m_xContext ); + AxisHelper::showGrid( m_nDimensionIndex, 0, m_bMain, xDiagram ); } else { diff --git a/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx index 0f8bd60b38f6..f0f5f76e8f71 100644 --- a/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx +++ b/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx @@ -813,8 +813,7 @@ void WrappedRegressionCurvesProperty::setValueToSeries( const Reference< beans:: RegressionCurveHelper::changeRegressionCurveType( eNewRegressionType, xRegressionCurveContainer, - xRegressionCurve, - uno::Reference< uno::XComponentContext >()); + xRegressionCurve); } } diff --git a/chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.cxx b/chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.cxx index a0e1b70ce273..cdf64d7473e8 100644 --- a/chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.cxx +++ b/chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.cxx @@ -141,7 +141,7 @@ void TitlesAndObjectsTabPage::commitToModel() aNewExistenceList[1] = m_pCB_Grid_Y->IsChecked(); aNewExistenceList[2] = m_pCB_Grid_Z->IsChecked(); AxisHelper::changeVisibilityOfGrids( xDiagram - , aOldExistenceList, aNewExistenceList, m_xCC ); + , aOldExistenceList, aNewExistenceList ); } } diff --git a/chart2/source/controller/inc/MultipleChartConverters.hxx b/chart2/source/controller/inc/MultipleChartConverters.hxx index c29fa506769e..37a9f8b0cde1 100644 --- a/chart2/source/controller/inc/MultipleChartConverters.hxx +++ b/chart2/source/controller/inc/MultipleChartConverters.hxx @@ -35,7 +35,6 @@ public: const css::uno::Reference<css::frame::XModel> & xChartModel, SfxItemPool& rItemPool, SdrModel& rDrawModel, - const css::uno::Reference<css::lang::XMultiServiceFactory>& xNamedPropertyContainerFactory, const css::awt::Size* pRefSize = nullptr ); virtual ~AllAxisItemConverter() override; diff --git a/chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx b/chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx index 2f22f13fd01c..efef2960eb06 100644 --- a/chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx +++ b/chart2/source/controller/itemsetwrapper/MultipleChartConverters.cxx @@ -43,7 +43,6 @@ AllAxisItemConverter::AllAxisItemConverter( const uno::Reference< frame::XModel > & xChartModel, SfxItemPool& rItemPool, SdrModel& rDrawModel, - const uno::Reference< lang::XMultiServiceFactory > & /*xNamedPropertyContainerFactory*/, const awt::Size* pRefSize ) : MultipleItemConverter( rItemPool ) { diff --git a/chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx b/chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx index ef80018a7bb5..026720001bc9 100644 --- a/chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx @@ -162,8 +162,7 @@ bool RegressionCurveItemConverter::ApplySpecialItem( xCurve = RegressionCurveHelper::changeRegressionCurveType( eNewRegress, m_xCurveContainer, - xCurve, - uno::Reference< uno::XComponentContext >()); + xCurve); uno::Reference<beans::XPropertySet> xProperties( xCurve, uno::UNO_QUERY ); resetPropertySet( xProperties ); bChanged = true; diff --git a/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx b/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx index dc48db2d0fa9..f5e988551e5d 100644 --- a/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx +++ b/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx @@ -436,8 +436,7 @@ bool StatisticsItemConverter::ApplySpecialItem( xCurve = RegressionCurveHelper::changeRegressionCurveType( eRegress, xContainer, - xCurve, - uno::Reference< uno::XComponentContext >()); + xCurve); uno::Reference< beans::XPropertySet > xProperties( xCurve, uno::UNO_QUERY ); resetPropertySet( xProperties ); bChanged = true; diff --git a/chart2/source/controller/main/ChartController_Insert.cxx b/chart2/source/controller/main/ChartController_Insert.cxx index eceb5af49d6d..e3b3e9146b3c 100644 --- a/chart2/source/controller/main/ChartController_Insert.cxx +++ b/chart2/source/controller/main/ChartController_Insert.cxx @@ -145,7 +145,7 @@ void ChartController::executeDispatch_InsertGrid() InsertAxisOrGridDialogData aDialogOutput; aDlg->getResult( aDialogOutput ); bool bChanged = AxisHelper::changeVisibilityOfGrids( xDiagram - , aDialogInput.aExistenceList, aDialogOutput.aExistenceList, m_xCC ); + , aDialogInput.aExistenceList, aDialogOutput.aExistenceList ); if( bChanged ) aUndoGuard.commit(); } @@ -366,8 +366,7 @@ void ChartController::executeDispatch_InsertTrendline() uno::Reference< chart2::XRegressionCurve > xCurve = RegressionCurveHelper::addRegressionCurve( SvxChartRegress::Linear, - xRegressionCurveContainer, - m_xCC ); + xRegressionCurveContainer ); uno::Reference< beans::XPropertySet > xProperties( xCurve, uno::UNO_QUERY ); diff --git a/chart2/source/controller/main/ChartController_Properties.cxx b/chart2/source/controller/main/ChartController_Properties.cxx index de3eebd88e76..8ea9d08ab2a7 100644 --- a/chart2/source/controller/main/ChartController_Properties.cxx +++ b/chart2/source/controller/main/ChartController_Properties.cxx @@ -313,7 +313,7 @@ wrapper::ItemConverter* createItemConverter( pItemConverter = new wrapper::AllAxisItemConverter( xChartModel, rDrawModel.GetItemPool(), - rDrawModel, uno::Reference< lang::XMultiServiceFactory >( xChartModel, uno::UNO_QUERY ), pRefSize.get()); + rDrawModel, pRefSize.get()); } break; case OBJECTTYPE_GRID: diff --git a/chart2/source/controller/main/ChartController_Tools.cxx b/chart2/source/controller/main/ChartController_Tools.cxx index 860cdde2bb9c..68b85a0b65a8 100644 --- a/chart2/source/controller/main/ChartController_Tools.cxx +++ b/chart2/source/controller/main/ChartController_Tools.cxx @@ -879,12 +879,12 @@ void ChartController::executeDispatch_ToggleGridHorizontal() } else { - AxisHelper::showGrid( nDimensionIndex, nCooSysIndex, false, xDiagram, m_xCC ); + AxisHelper::showGrid( nDimensionIndex, nCooSysIndex, false, xDiagram ); } } else { - AxisHelper::showGrid( nDimensionIndex, nCooSysIndex, true, xDiagram, m_xCC ); + AxisHelper::showGrid( nDimensionIndex, nCooSysIndex, true, xDiagram ); } aUndoGuard.commit(); } @@ -911,12 +911,12 @@ void ChartController::executeDispatch_ToggleGridVertical() } else { - AxisHelper::showGrid( nDimensionIndex, nCooSysIndex, false, xDiagram, m_xCC ); + AxisHelper::showGrid( nDimensionIndex, nCooSysIndex, false, xDiagram ); } } else { - AxisHelper::showGrid( nDimensionIndex, nCooSysIndex, true, xDiagram, m_xCC ); + AxisHelper::showGrid( nDimensionIndex, nCooSysIndex, true, xDiagram ); } aUndoGuard.commit(); diff --git a/chart2/source/controller/sidebar/ChartElementsPanel.cxx b/chart2/source/controller/sidebar/ChartElementsPanel.cxx index 36241b580be8..39607513f4f8 100644 --- a/chart2/source/controller/sidebar/ChartElementsPanel.cxx +++ b/chart2/source/controller/sidebar/ChartElementsPanel.cxx @@ -155,7 +155,7 @@ void setGridVisible(const css::uno::Reference<css::frame::XModel>& xModel, GridT if (bVisible) AxisHelper::showGrid(nDimensionIndex, nCooSysIndex, bMajor, - xDiagram, comphelper::getProcessComponentContext()); + xDiagram); else AxisHelper::hideGrid(nDimensionIndex, nCooSysIndex, bMajor, xDiagram); } diff --git a/chart2/source/controller/sidebar/ChartSeriesPanel.cxx b/chart2/source/controller/sidebar/ChartSeriesPanel.cxx index 6eb04776332b..07cf968c2e7b 100644 --- a/chart2/source/controller/sidebar/ChartSeriesPanel.cxx +++ b/chart2/source/controller/sidebar/ChartSeriesPanel.cxx @@ -164,8 +164,7 @@ void setTrendlineVisible(const css::uno::Reference<css::frame::XModel>& { RegressionCurveHelper::addRegressionCurve( SvxChartRegress::Linear, - xRegressionCurveContainer, - comphelper::getProcessComponentContext()); + xRegressionCurveContainer); } else RegressionCurveHelper::removeAllExceptMeanValueLine( |