commit: loplugin:checkunusedparams in chart2

Change-Id: Ia1f42e74365ca1dace93babc132ad67fd09fc99d
Reviewed-on: https://gerrit.libreoffice.org/37064
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 9 insertions, 11 deletions

diff --git a/chart2/source/model/main/Axis.cxx b/chart2/source/model/main/Axis.cxx
index 35b5c6df84f1..69ac5871f21e 100644
--- a/chart2/source/model/main/Axis.cxx
+++ b/chart2/source/model/main/Axis.cxx
@@ -385,7 +385,7 @@ Axis::Axis( const Axis & rOther ) :
 }
 
 // late initialization to call after copy-constructing
-void Axis::Init( const Axis & /* rOther */ )
+void Axis::Init()
 {
     if( m_aScaleData.Categories.is())
         EventListenerHelper::addListener( m_aScaleData.Categories, this );
@@ -543,7 +543,7 @@ Reference< util::XCloneable > SAL_CALL Axis::createClone()
     // hold a reference to the clone
     Reference< util::XCloneable > xResult( pNewAxis );
     // do initialization that uses uno references to the clone
-    pNewAxis->Init( *this );
+    pNewAxis->Init();
     return xResult;
 }
 
diff --git a/chart2/source/model/main/Axis.hxx b/chart2/source/model/main/Axis.hxx
index 5ec250fc36b2..8292a7c5019b 100644
--- a/chart2/source/model/main/Axis.hxx
+++ b/chart2/source/model/main/Axis.hxx
@@ -71,7 +71,7 @@ protected:
     explicit Axis( const Axis & rOther );
 
     // late initialization to call after copy-constructing
-    void Init( const Axis & rOther );
+    void Init();
 
     // ____ OPropertySet ____
     virtual css::uno::Any GetDefaultValue( sal_Int32 nHandle ) const override;
diff --git a/chart2/source/model/main/ChartModel.cxx b/chart2/source/model/main/ChartModel.cxx
index 579a9c341eb8..1b3e233b5218 100644
--- a/chart2/source/model/main/ChartModel.cxx
+++ b/chart2/source/model/main/ChartModel.cxx
@@ -650,7 +650,7 @@ void SAL_CALL ChartModel::close( sal_Bool bDeliverOwnership )
             //if not successful canceled
             if(!bLongLastingCallsAreCanceled)
             {
-                m_aLifeTimeManager.g_close_endTryClose( bDeliverOwnership, true );
+                m_aLifeTimeManager.g_close_endTryClose( bDeliverOwnership );
                 throw aVetoException;
             }
         }
diff --git a/chart2/source/model/template/ChartTypeTemplate.cxx b/chart2/source/model/template/ChartTypeTemplate.cxx
index d876ae0c4c56..cc7b5b833145 100644
--- a/chart2/source/model/template/ChartTypeTemplate.cxx
+++ b/chart2/source/model/template/ChartTypeTemplate.cxx
@@ -166,7 +166,7 @@ uno::Reference< XDiagram > SAL_CALL ChartTypeTemplate::createDiagramByDataSource
         }
 
         Sequence< Reference< XChartType > > aOldChartTypesSeq;
-        FillDiagram( xDia, aData.Series, aData.Categories, aOldChartTypesSeq, true );
+        FillDiagram( xDia, aData.Series, aData.Categories, aOldChartTypesSeq );
     }
     catch( const uno::Exception & ex )
     {
@@ -247,7 +247,7 @@ void SAL_CALL ChartTypeTemplate::changeDiagram( const uno::Reference< XDiagram >
             }
         }
 
-        FillDiagram( xDiagram, aSeriesSeq, aData.Categories, aOldChartTypesSeq, false );
+        FillDiagram( xDiagram, aSeriesSeq, aData.Categories, aOldChartTypesSeq );
     }
     catch( const uno::Exception & ex )
     {
@@ -628,7 +628,7 @@ void ChartTypeTemplate::adaptScales(
                         {
 
                             Reference< XChartType > xChartType( getChartTypeForNewSeries(Sequence< Reference< XChartType > >() ));
-                            bool bSupportsDates = ::chart::ChartTypeHelper::isSupportingDateAxis( xChartType, 2, nDimensionX );
+                            bool bSupportsDates = ::chart::ChartTypeHelper::isSupportingDateAxis( xChartType, nDimensionX );
                             if( aData.AxisType != AxisType::CATEGORY && ( aData.AxisType != AxisType::DATE || !bSupportsDates) )
                             {
                                 aData.AxisType = AxisType::CATEGORY;
@@ -765,8 +765,7 @@ void ChartTypeTemplate::FillDiagram(
     const Reference< XDiagram >& xDiagram,
     const Sequence< Sequence< Reference< XDataSeries > > >& aSeriesSeq,
     const Reference< data::XLabeledDataSequence >& xCategories,
-    const Sequence< Reference< XChartType > >& aOldChartTypesSeq,
-    bool /* bCreate */ )
+    const Sequence< Reference< XChartType > >& aOldChartTypesSeq )
 {
     adaptDiagram( xDiagram );
 
diff --git a/chart2/source/model/template/ChartTypeTemplate.hxx b/chart2/source/model/template/ChartTypeTemplate.hxx
index 4cf11ca6cdae..94122c69295c 100644
--- a/chart2/source/model/template/ChartTypeTemplate.hxx
+++ b/chart2/source/model/template/ChartTypeTemplate.hxx
@@ -248,8 +248,7 @@ private:
                           css::chart2::data::XLabeledDataSequence >& xCategories,
                       const css::uno::Sequence<
                               css::uno::Reference<
-                                  css::chart2::XChartType > > & aOldChartTypesSeq,
-                      bool bCreate );
+                                  css::chart2::XChartType > > & aOldChartTypesSeq);
 };
 
 } //  namespace chart