loplugin:checkunusedparams

the "check for taking address of function" part was generating false+

Change-Id: Iad6203850901229b7b1b2f8938c68ec703cd343f
Reviewed-on: https://gerrit.libreoffice.org/40613
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 8 insertions, 18 deletions

diff --git a/chart2/source/tools/ObjectIdentifier.cxx b/chart2/source/tools/ObjectIdentifier.cxx
index f81722c5009d..d99a21983e60 100644
--- a/chart2/source/tools/ObjectIdentifier.cxx
+++ b/chart2/source/tools/ObjectIdentifier.cxx
@@ -364,7 +364,7 @@ OUString ObjectIdentifier::createClassifiedIdentifierForObject(
         Reference< XDiagram > xDiagram( xObject, uno::UNO_QUERY );
         if( xDiagram.is() )
         {
-            return createClassifiedIdentifierForParticle( createParticleForDiagram( xDiagram, rModel ) );
+            return createClassifiedIdentifierForParticle( createParticleForDiagram() );
         }
 
         //todo
@@ -446,7 +446,7 @@ OUString ObjectIdentifier::createClassifiedIdentifierForObject(
         Reference< XDiagram > xDiagram( xObject, uno::UNO_QUERY );
         if( xDiagram.is() )
         {
-            return createClassifiedIdentifierForParticle( createParticleForDiagram( xDiagram, xChartModel ) );
+            return createClassifiedIdentifierForParticle( createParticleForDiagram() );
         }
 
         //todo
@@ -506,19 +506,9 @@ OUString ObjectIdentifier::createClassifiedIdentifierForParticles(
     return aRet.makeStringAndClear();
 }
 
-OUString ObjectIdentifier::createParticleForDiagram(
-          const Reference< XDiagram >& /*xDiagram*/
-        , ChartModel& /*xChartModel*/ )
+OUString ObjectIdentifier::createParticleForDiagram()
 {
-    //todo: if more than one diagram is implemeted, add the correct diagram index here
-    return OUString("D=0");
-}
-
-OUString ObjectIdentifier::createParticleForDiagram(
-          const Reference< XDiagram >& /*xDiagram*/
-        , const Reference< frame::XModel >& /*xChartModel*/ )
-{
-    //todo: if more than one diagram is implemeted, add the correct diagram index here
+    //TODO: if more than one diagram is implemented, add the correct diagram index here
     return OUString("D=0");
 }
 
@@ -539,7 +529,7 @@ OUString ObjectIdentifier::createParticleForCoordinateSystem(
             Reference< XCoordinateSystem > xCurrentCooSys( aCooSysList[nCooSysIndex] );
             if( xCooSys == xCurrentCooSys )
             {
-                aRet = ObjectIdentifier::createParticleForDiagram( xDiagram, rModel );
+                aRet = ObjectIdentifier::createParticleForDiagram();
                 aRet.append(":CS=");
                 aRet.append( OUString::number( nCooSysIndex ) );
                 break;
@@ -567,7 +557,7 @@ OUString ObjectIdentifier::createParticleForCoordinateSystem(
             Reference< XCoordinateSystem > xCurrentCooSys( aCooSysList[nCooSysIndex] );
             if( xCooSys == xCurrentCooSys )
             {
-                aRet = ObjectIdentifier::createParticleForDiagram( xDiagram, xChartModel );
+                aRet = ObjectIdentifier::createParticleForDiagram();
                 aRet.append(":CS=");
                 aRet.append( OUString::number( nCooSysIndex ) );
                 break;
@@ -649,7 +639,7 @@ OUString ObjectIdentifier::createParticleForLegend( ChartModel& rModel )
     Reference< XDiagram > xDiagram( rModel.getFirstDiagram() );
     //todo: if more than one diagram is implemeted, find the correct diagram which is owner of the given legend
 
-    aRet.append( ObjectIdentifier::createParticleForDiagram( xDiagram, rModel ) );
+    aRet.append( ObjectIdentifier::createParticleForDiagram() );
     aRet.append(":");
     aRet.append(getStringForType( OBJECTTYPE_LEGEND ));
     aRet.append("=");
@@ -665,7 +655,7 @@ OUString ObjectIdentifier::createParticleForLegend(
     Reference< XDiagram > xDiagram( ChartModelHelper::findDiagram( xChartModel ) );
     //todo: if more than one diagram is implemeted, find the correct diagram which is owner of the given legend
 
-    aRet.append( ObjectIdentifier::createParticleForDiagram( xDiagram, xChartModel ) );
+    aRet.append( ObjectIdentifier::createParticleForDiagram() );
     aRet.append(":");
     aRet.append(getStringForType( OBJECTTYPE_LEGEND ));
     aRet.append("=");