diff options
author | Noel Grandin <noel@peralex.com> | 2015-11-06 09:23:33 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2015-11-09 08:34:40 +0000 |
commit | 6c80a8fe89fadf9a2c7260a09c037a09462f53d1 (patch) | |
tree | d36da9ee2a5fdc579d2a57ff6ba02deaddfa785a /chart2/source/tools | |
parent | e1fc599eb764186e5d511ace9785463eebbc7028 (diff) |
new loplugin: oncevar
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'chart2/source/tools')
-rw-r--r-- | chart2/source/tools/DataSeriesHelper.cxx | 3 | ||||
-rw-r--r-- | chart2/source/tools/ErrorBar.cxx | 3 | ||||
-rw-r--r-- | chart2/source/tools/ExplicitCategoriesProvider.cxx | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/chart2/source/tools/DataSeriesHelper.cxx b/chart2/source/tools/DataSeriesHelper.cxx index 6cea3031b228..eea642e0ace9 100644 --- a/chart2/source/tools/DataSeriesHelper.cxx +++ b/chart2/source/tools/DataSeriesHelper.cxx @@ -390,7 +390,6 @@ void setStackModeAtSeries( if( eStackMode == StackMode_AMBIGUOUS ) return; - const OUString aPropName( "StackingDirection" ); const uno::Any aPropValue = uno::makeAny( ( (eStackMode == StackMode_Y_STACKED) || (eStackMode == StackMode_Y_STACKED_PERCENT) ) @@ -407,7 +406,7 @@ void setStackModeAtSeries( Reference< beans::XPropertySet > xProp( aSeries[i], uno::UNO_QUERY ); if( xProp.is() ) { - xProp->setPropertyValue( aPropName, aPropValue ); + xProp->setPropertyValue( "StackingDirection", aPropValue ); sal_Int32 nAxisIndex; xProp->getPropertyValue( "AttachedAxisIndex" ) >>= nAxisIndex; diff --git a/chart2/source/tools/ErrorBar.cxx b/chart2/source/tools/ErrorBar.cxx index 4f301e460fb7..c22e592028b0 100644 --- a/chart2/source/tools/ErrorBar.cxx +++ b/chart2/source/tools/ErrorBar.cxx @@ -179,7 +179,6 @@ namespace { OUString getSourceRangeStrFromLabeledSequences( const uno::Sequence< uno::Reference< chart2::data::XLabeledDataSequence > >& aSequences, bool bPositive ) { - const OUString aRolePrefix( "error-bars" ); OUString aDirection; if(bPositive) aDirection = "positive"; @@ -196,7 +195,7 @@ OUString getSourceRangeStrFromLabeledSequences( const uno::Sequence< uno::Refere uno::Reference< beans::XPropertySet > xSeqProp( xSequence, uno::UNO_QUERY_THROW ); OUString aRole; if( ( xSeqProp->getPropertyValue( "Role" ) >>= aRole ) && - aRole.match( aRolePrefix ) && aRole.indexOf(aDirection) >= 0 ) + aRole.match( "error-bars" ) && aRole.indexOf(aDirection) >= 0 ) { return xSequence->getSourceRangeRepresentation(); } diff --git a/chart2/source/tools/ExplicitCategoriesProvider.cxx b/chart2/source/tools/ExplicitCategoriesProvider.cxx index 56977db55e4b..c7c588b699c9 100644 --- a/chart2/source/tools/ExplicitCategoriesProvider.cxx +++ b/chart2/source/tools/ExplicitCategoriesProvider.cxx @@ -371,7 +371,6 @@ Sequence< OUString > lcl_getExplicitSimpleCategories( { aRet.realloc(nMaxCategoryCount); aOuterEnd = aComplexCatsPerIndex.end(); - OUString aSpace(" "); for(sal_Int32 nN=0; nN<nMaxCategoryCount; nN++) { OUString aText; @@ -383,7 +382,7 @@ Sequence< OUString > lcl_getExplicitSimpleCategories( if( !aAddText.isEmpty() ) { if(!aText.isEmpty()) - aText += aSpace; + aText += " "; aText += aAddText; } } |