diff options
author | Alyssa Ross <hi@alyssa.is> | 2018-11-26 01:07:42 +0000 |
---|---|---|
committer | Michael Stahl <Michael.Stahl@cib.de> | 2018-11-26 11:57:19 +0100 |
commit | ab9d95e6073d84a0dbabf1a4e704b8468afe7bff (patch) | |
tree | 745d7b40a07c8f9ce6bdc9cbccfcb2b4acd6db88 /chart2/source/view/inc/LabelPositionHelper.hxx | |
parent | 2d6dfead4b0546c28dcc864dc27488f83d190e3f (diff) |
Use -filelist with macOS linker
macOS's linker can take a -filelist argument, in place of taking the
list of object files to link on the command line. This is a more limited
version of "response files" as used elsewhere in the code base, and by
using it we make it far less likely that a linker invocation will hit
ARG_MAX.
A standard LibreOffice build probably won't hit ARG_MAX on macOS just
yet, but it's not far off - some LDFLAGS are enough to tip it over the
edge, which is what prompted me to fix the issue. If not fixed, a few
more object files will probably break LibreOffice builds on macOS! An
example of another large program that has encountered this issue is
Thunderbird, which implemented the same fix[1].
The changes I've made to use -filelist are adapted from the code
elsewhere in gbuild that creates response files, but this is slightly
different because -filelist files are a bit different - they can only
contain object files, as opposed to arbitrary linker arguments, and
arguments are separated by newlines rather than spaces.
[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=837618
Change-Id: I01b9126aad95056c3dc82f941dea4fd43f95d0f2
Reviewed-on: https://gerrit.libreoffice.org/64010
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Diffstat (limited to 'chart2/source/view/inc/LabelPositionHelper.hxx')
0 files changed, 0 insertions, 0 deletions