diff options
author | Noel Grandin <noel@peralex.com> | 2016-08-04 11:35:36 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2016-08-05 06:26:59 +0000 |
commit | f22fa994603311a36f467a6afea19bc4fad03814 (patch) | |
tree | f261b4bad8ef402d5d06b1619e35e6b5f5fd04f8 /chart2/source/view/inc | |
parent | ce97110f37825f9666bff8ff2df0d2092620ae17 (diff) |
loplugin:countusersofdefaultparams in canvas,chart2
Change-Id: Id66a706171b73affeb508812744028d9f30133af
Reviewed-on: https://gerrit.libreoffice.org/27868
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'chart2/source/view/inc')
-rw-r--r-- | chart2/source/view/inc/3DChartObjects.hxx | 2 | ||||
-rw-r--r-- | chart2/source/view/inc/AbstractShapeFactory.hxx | 10 | ||||
-rw-r--r-- | chart2/source/view/inc/GL3DBarChart.hxx | 2 | ||||
-rw-r--r-- | chart2/source/view/inc/GL3DRenderer.hxx | 2 | ||||
-rw-r--r-- | chart2/source/view/inc/OpenglShapeFactory.hxx | 8 | ||||
-rw-r--r-- | chart2/source/view/inc/PolarLabelPositionHelper.hxx | 4 | ||||
-rw-r--r-- | chart2/source/view/inc/ShapeFactory.hxx | 8 | ||||
-rw-r--r-- | chart2/source/view/inc/VSeriesPlotter.hxx | 8 |
8 files changed, 22 insertions, 22 deletions
diff --git a/chart2/source/view/inc/3DChartObjects.hxx b/chart2/source/view/inc/3DChartObjects.hxx index fd2c8b23c277..a8e30d1c1b1c 100644 --- a/chart2/source/view/inc/3DChartObjects.hxx +++ b/chart2/source/view/inc/3DChartObjects.hxx @@ -109,7 +109,7 @@ public: virtual void render() override; void setPosition(const glm::vec2& rTopLeft, const glm::vec2& rBottomRight, - const glm::vec3& r3DPos = glm::vec3(0.0, 0.0, 0.0)); + const glm::vec3& r3DPos); private: TextCacheItem maText; diff --git a/chart2/source/view/inc/AbstractShapeFactory.hxx b/chart2/source/view/inc/AbstractShapeFactory.hxx index 8d988bee27c0..ff2ac600694c 100644 --- a/chart2/source/view/inc/AbstractShapeFactory.hxx +++ b/chart2/source/view/inc/AbstractShapeFactory.hxx @@ -132,7 +132,7 @@ public: , const Stripe& rStripe , const css::uno::Reference< css::beans::XPropertySet >& xSourceProp , const tPropertyNameMap& rPropertyNameMap - , bool bDoubleSided = true + , bool bDoubleSided , short nRotatedTexture = 0 //0 to 7 are the different possibilities , bool bFlatNormals=true ) = 0; @@ -152,8 +152,8 @@ public: , const css::drawing::Position3D& rPos , const css::drawing::Direction3D& rSize , sal_Int32 nStandardSymbol - , sal_Int32 nBorderColor=0 - , sal_Int32 nFillColor=0 ) = 0; + , sal_Int32 nBorderColor + , sal_Int32 nFillColor ) = 0; virtual css::uno::Reference< css::drawing::XShape > createGraphic2D( const css::uno::Reference< css::drawing::XShapes >& xTarget @@ -236,7 +236,7 @@ public: /** * Only necessary for stateless implementations */ - virtual void render(css::uno::Reference< css::drawing::XShapes > xRootShape, bool bInitOpenGL = true) = 0; + virtual void render(css::uno::Reference< css::drawing::XShapes > xRootShape, bool bInitOpenGL) = 0; virtual bool preRender(css::uno::Reference< css::drawing::XShapes > xRootShape, OpenGLWindow* pWindow) = 0; virtual void postRender(OpenGLWindow* pWindow) = 0; @@ -255,7 +255,7 @@ public: static css::uno::Any makeTransformation( const css::awt::Point& rScreenPosition2D, double fRotationAnglePi=0.0 ); - static OUString getStackedString( const OUString& rString, bool bStacked=true ); + static OUString getStackedString( const OUString& rString, bool bStacked ); static bool hasPolygonAnyLines( css::drawing::PolyPolygonShape3D& rPoly ); static bool isPolygonEmptyOrSinglePoint( css::drawing::PolyPolygonShape3D& rPoly ); diff --git a/chart2/source/view/inc/GL3DBarChart.hxx b/chart2/source/view/inc/GL3DBarChart.hxx index e7ae9ac4c1d5..4fe03a5f1729 100644 --- a/chart2/source/view/inc/GL3DBarChart.hxx +++ b/chart2/source/view/inc/GL3DBarChart.hxx @@ -103,7 +103,7 @@ private: void updateDataUpdateFPS(); DECL_LINK_TYPED(UpdateTimerHdl, Idle*, void); static int calcTimeInterval(TimeValue &startTime, TimeValue &endTime); - float addScreenTextShape(OUString &nStr, const glm::vec2& rLeftOrRightTop, float nTextHeight, bool bLeftTopFlag = true, + float addScreenTextShape(OUString &nStr, const glm::vec2& rLeftOrRightTop, float nTextHeight, bool bLeftTopFlag, const glm::vec4& rColor = glm::vec4(0.0f, 1.0f, 1.0f, 0.0f), const glm::vec3& rPos = glm::vec3(0.0f, 0.0f, 0.0f), sal_uInt32 nEvent = 0); diff --git a/chart2/source/view/inc/GL3DRenderer.hxx b/chart2/source/view/inc/GL3DRenderer.hxx index ee3403b7cc67..49feca78e73e 100644 --- a/chart2/source/view/inc/GL3DRenderer.hxx +++ b/chart2/source/view/inc/GL3DRenderer.hxx @@ -176,7 +176,7 @@ public: ~OpenGL3DRenderer(); void init(); - void Set3DSenceInfo(sal_uInt32 color = 255, bool twoSidesLighting = true); + void Set3DSenceInfo(sal_uInt32 color, bool twoSidesLighting = true); void SetLightInfo(bool lightOn, sal_uInt32 color, const glm::vec4& direction); void AddShapePolygon3DObject(sal_uInt32 color, bool lineOnly, sal_uInt32 lineColor, long fillStyle, sal_uInt32 specular, sal_uInt32 nUniqueId); diff --git a/chart2/source/view/inc/OpenglShapeFactory.hxx b/chart2/source/view/inc/OpenglShapeFactory.hxx index aa74308f951b..01b2223cf59c 100644 --- a/chart2/source/view/inc/OpenglShapeFactory.hxx +++ b/chart2/source/view/inc/OpenglShapeFactory.hxx @@ -82,7 +82,7 @@ public: , const Stripe& rStripe , const css::uno::Reference< css::beans::XPropertySet >& xSourceProp , const tPropertyNameMap& rPropertyNameMap - , bool bDoubleSided = true + , bool bDoubleSided , short nRotatedTexture = 0 //0 to 7 are the different possibilities , bool bFlatNormals=true ) override; @@ -100,8 +100,8 @@ public: , const css::drawing::Position3D& rPos , const css::drawing::Direction3D& rSize , sal_Int32 nStandardSymbol - , sal_Int32 nBorderColor=0 - , sal_Int32 nFillColor=0 ) override; + , sal_Int32 nBorderColor + , sal_Int32 nFillColor ) override; virtual css::uno::Reference< css::drawing::XShape > createGraphic2D( const css::uno::Reference< css::drawing::XShapes >& xTarget @@ -182,7 +182,7 @@ public: virtual void setPageSize( css::uno::Reference < css::drawing::XShapes > xChartShapes, const css::awt::Size& rSize ) override; - virtual void render(css::uno::Reference< css::drawing::XShapes > xDrawPage, bool bInitOpenGL = true) override; + virtual void render(css::uno::Reference< css::drawing::XShapes > xDrawPage, bool bInitOpenGL) override; virtual bool preRender(css::uno::Reference< css::drawing::XShapes > xRootShape, OpenGLWindow* pWindow) override; virtual void postRender(OpenGLWindow* pWindow) override; diff --git a/chart2/source/view/inc/PolarLabelPositionHelper.hxx b/chart2/source/view/inc/PolarLabelPositionHelper.hxx index a5bb57251574..95d25d33909f 100644 --- a/chart2/source/view/inc/PolarLabelPositionHelper.hxx +++ b/chart2/source/view/inc/PolarLabelPositionHelper.hxx @@ -46,7 +46,7 @@ public: , double fLogicValueOnAngleAxis , double fLogicValueOnRadiusAxis , double fLogicZ - , sal_Int32 nScreenValueOffsetInRadiusDirection=0 ) const; + , sal_Int32 nScreenValueOffsetInRadiusDirection ) const; /** Calculate the anchor point position for a text label. * When the requested label placement is of `INSIDE` or `OUTSIDE` type the @@ -64,7 +64,7 @@ public: , double fUnitCircleStartAngleDegree, double fUnitCircleWidthAngleDegree , double fUnitCircleInnerRadius, double fUnitCircleOuterRadius , double fLogicZ - , sal_Int32 nScreenValueOffsetInRadiusDirection=0 ) const; + , sal_Int32 nScreenValueOffsetInRadiusDirection ) const; private: PolarPlottingPositionHelper* m_pPosHelper; diff --git a/chart2/source/view/inc/ShapeFactory.hxx b/chart2/source/view/inc/ShapeFactory.hxx index 8083411de00d..02a75d3a0764 100644 --- a/chart2/source/view/inc/ShapeFactory.hxx +++ b/chart2/source/view/inc/ShapeFactory.hxx @@ -93,7 +93,7 @@ public: , const Stripe& rStripe , const css::uno::Reference< css::beans::XPropertySet >& xSourceProp , const tPropertyNameMap& rPropertyNameMap - , bool bDoubleSided = true + , bool bDoubleSided , short nRotatedTexture = 0 //0 to 7 are the different possibilities , bool bFlatNormals=true ) override; @@ -111,8 +111,8 @@ public: , const css::drawing::Position3D& rPos , const css::drawing::Direction3D& rSize , sal_Int32 nStandardSymbol - , sal_Int32 nBorderColor=0 - , sal_Int32 nFillColor=0 ) override; + , sal_Int32 nBorderColor + , sal_Int32 nFillColor ) override; virtual css::uno::Reference< css::drawing::XShape > createGraphic2D( const css::uno::Reference< css::drawing::XShapes >& xTarget @@ -242,7 +242,7 @@ private: , const css::drawing::Position3D& rPosition , const css::drawing::Direction3D& rSize , double fTopHeight, sal_Int32 nRotateZAngleHundredthDegree - , bool bCylinder = false); + , bool bCylinder); }; } //namespace chart diff --git a/chart2/source/view/inc/VSeriesPlotter.hxx b/chart2/source/view/inc/VSeriesPlotter.hxx index fb4ffbb8c6af..d5817b211a0e 100644 --- a/chart2/source/view/inc/VSeriesPlotter.hxx +++ b/chart2/source/view/inc/VSeriesPlotter.hxx @@ -195,7 +195,7 @@ public: virtual LegendSymbolStyle getLegendSymbolStyle(); virtual css::awt::Size getPreferredLegendKeyAspectRatio() override; - virtual css::uno::Any getExplicitSymbol( const VDataSeries& rSeries, sal_Int32 nPointIndex=-1/*-1 for series symbol*/ ); + virtual css::uno::Any getExplicitSymbol( const VDataSeries& rSeries, sal_Int32 nPointIndex/*-1 for series symbol*/ ); css::uno::Reference< css::drawing::XShape > createLegendSymbolForSeries( const css::awt::Size& rEntryKeyAspectRatio @@ -224,7 +224,7 @@ public: // This method creates a series plotter of the requested type; e.g. : return new PieChart .... static VSeriesPlotter* createSeriesPlotter( const css::uno::Reference< css::chart2::XChartType >& xChartTypeModel , sal_Int32 nDimensionCount - , bool bExcludingPositioning = false /*for pie and donut charts labels and exploded segments are excluded from the given size*/); + , bool bExcludingPositioning /*for pie and donut charts labels and exploded segments are excluded from the given size*/); sal_Int32 getPointCount() const; @@ -319,7 +319,7 @@ protected: , double fValue , double fSumValue , const css::awt::Point& rScreenPosition2D - , LabelAlignment eAlignment=LABEL_ALIGN_CENTER + , LabelAlignment eAlignment , sal_Int32 nOffset=0 , sal_Int32 nTextWidth = 0 ); @@ -364,7 +364,7 @@ protected: void createErrorBar_Y( const css::drawing::Position3D& rUnscaledLogicPosition , VDataSeries& rVDataSeries, sal_Int32 nPointIndex , const css::uno::Reference< css::drawing::XShapes >& xTarget - , double* pfScaledLogicX=nullptr ); + , double* pfScaledLogicX ); void createRegressionCurvesShapes( VDataSeries& rVDataSeries , const css::uno::Reference< css::drawing::XShapes >& xTarget |