diff options
author | Noel Grandin <noel@peralex.com> | 2015-08-12 15:09:30 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2015-08-14 10:52:46 +0200 |
commit | 70a30fd179266f65500b880ccb0f87011b670fca (patch) | |
tree | 881d1723620d030171ff3de9bad2cc96f80994ed /chart2/source/view | |
parent | 9045d0bf35c9b4d5f6d8f791017124341abf8d4f (diff) |
loplugin: defaultparams
Change-Id: I65c0ed65b20f606cf1409a3158ff1ef1e2d6cd9f
Diffstat (limited to 'chart2/source/view')
-rw-r--r-- | chart2/source/view/axes/Tickmarks_Equidistant.cxx | 2 | ||||
-rw-r--r-- | chart2/source/view/charttypes/PieChart.cxx | 2 | ||||
-rw-r--r-- | chart2/source/view/charttypes/VSeriesPlotter.cxx | 2 | ||||
-rw-r--r-- | chart2/source/view/diagram/VDiagram.cxx | 7 | ||||
-rw-r--r-- | chart2/source/view/main/ChartView.cxx | 8 | ||||
-rw-r--r-- | chart2/source/view/main/GL3DRenderer.cxx | 2 | ||||
-rw-r--r-- | chart2/source/view/main/PlottingPositionHelper.cxx | 2 |
7 files changed, 12 insertions, 13 deletions
diff --git a/chart2/source/view/axes/Tickmarks_Equidistant.cxx b/chart2/source/view/axes/Tickmarks_Equidistant.cxx index a83a73fdbfa5..6f7a39da897d 100644 --- a/chart2/source/view/axes/Tickmarks_Equidistant.cxx +++ b/chart2/source/view/axes/Tickmarks_Equidistant.cxx @@ -316,7 +316,7 @@ void EquidistantTickFactory::getAllTicks( TickInfoArraysType& rAllTickInfos ) co //create point sequences for each tick depth sal_Int32 nDepthCount = this->getTickDepth(); - sal_Int32 nMaxMajorTickCount = this->getMaxTickCount( 0 ); + sal_Int32 nMaxMajorTickCount = this->getMaxTickCount(); if (nDepthCount <= 0 || nMaxMajorTickCount <= 0) return; diff --git a/chart2/source/view/charttypes/PieChart.cxx b/chart2/source/view/charttypes/PieChart.cxx index 01a566dc330d..c6e9379c605a 100644 --- a/chart2/source/view/charttypes/PieChart.cxx +++ b/chart2/source/view/charttypes/PieChart.cxx @@ -319,7 +319,7 @@ void PieChart::createTextLabelShape( awt::Point aScreenPosition2D( aPolarPosHelper.getLabelScreenPositionAndAlignmentForUnitCircleValues(eAlignment, nLabelPlacement , rParam.mfUnitCircleStartAngleDegree, rParam.mfUnitCircleWidthAngleDegree - , rParam.mfUnitCircleInnerRadius, rParam.mfUnitCircleOuterRadius, rParam.mfLogicZ+0.5, 0 )); + , rParam.mfUnitCircleInnerRadius, rParam.mfUnitCircleOuterRadius, rParam.mfLogicZ+0.5 )); ///the screen position of the pie/donut center is calculated. PieLabelInfo aPieLabelInfo; diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx b/chart2/source/view/charttypes/VSeriesPlotter.cxx index d2c17a5a26a5..2fa557f42c48 100644 --- a/chart2/source/view/charttypes/VSeriesPlotter.cxx +++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx @@ -403,7 +403,7 @@ OUString VSeriesPlotter::getLabelTextForValue( VDataSeries& rDataSeries { sal_Unicode cDecSeparator = '.';//@todo get this locale dependent aNumber = ::rtl::math::doubleToUString( fValue, rtl_math_StringFormat_G /*rtl_math_StringFormat*/ - , 3/*DecPlaces*/ , cDecSeparator, false /*bEraseTrailingDecZeros*/ ); + , 3/*DecPlaces*/ , cDecSeparator ); } return aNumber; } diff --git a/chart2/source/view/diagram/VDiagram.cxx b/chart2/source/view/diagram/VDiagram.cxx index 9f5db9926456..10b14fe8e57e 100644 --- a/chart2/source/view/diagram/VDiagram.cxx +++ b/chart2/source/view/diagram/VDiagram.cxx @@ -487,7 +487,6 @@ void VDiagram::createShapes_3d() bool bAddFloorAndWall = DiagramHelper::isSupportingFloorAndWall( m_xDiagram ); const bool bDoubleSided = false; - const bool bFlatNormals = true; //add walls { @@ -523,7 +522,7 @@ void VDiagram::createShapes_3d() uno::Reference< drawing::XShape > xShape = m_pShapeFactory->createStripe( xWallGroup_Shapes, aStripe - , xWallProp, PropertyMapper::getPropertyNameMapForFillAndLineProperties(), bDoubleSided, nRotatedTexture, bFlatNormals ); + , xWallProp, PropertyMapper::getPropertyNameMapForFillAndLineProperties(), bDoubleSided, nRotatedTexture ); if( !bAddFloorAndWall ) { //we always need this object as dummy object for correct scene dimensions @@ -551,7 +550,7 @@ void VDiagram::createShapes_3d() uno::Reference< drawing::XShape > xShape = m_pShapeFactory->createStripe(xWallGroup_Shapes, aStripe - , xWallProp, PropertyMapper::getPropertyNameMapForFillAndLineProperties(), bDoubleSided, nRotatedTexture, bFlatNormals ); + , xWallProp, PropertyMapper::getPropertyNameMapForFillAndLineProperties(), bDoubleSided, nRotatedTexture ); if( !bAddFloorAndWall ) { //we always need this object as dummy object for correct scene dimensions @@ -625,7 +624,7 @@ void VDiagram::createShapes_3d() uno::Reference< drawing::XShape > xShape = m_pShapeFactory->createStripe(xOuterGroup_Shapes, aStripe - , xFloorProp, PropertyMapper::getPropertyNameMapForFillAndLineProperties(), bDoubleSided, 0, bFlatNormals ); + , xFloorProp, PropertyMapper::getPropertyNameMapForFillAndLineProperties(), bDoubleSided, 0 ); CuboidPlanePosition eBottomPos( ThreeDHelper::getAutomaticCuboidPlanePositionForStandardBottom( uno::Reference< beans::XPropertySet >( m_xDiagram, uno::UNO_QUERY ) ) ); if( !bAddFloorAndWall || (CuboidPlanePosition_Bottom!=eBottomPos) ) diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx index be644ba192b2..2877ba560ade 100644 --- a/chart2/source/view/main/ChartView.cxx +++ b/chart2/source/view/main/ChartView.cxx @@ -1212,7 +1212,7 @@ void ChartView::init() m_pDrawModelWrapper = ::boost::shared_ptr< DrawModelWrapper >( new DrawModelWrapper( m_xCC ) ); m_xShapeFactory = m_pDrawModelWrapper->getShapeFactory(); m_xDrawPage = m_pDrawModelWrapper->getMainDrawPage(); - StartListening( m_pDrawModelWrapper->getSdrModel(), false /*bPreventDups*/ ); + StartListening( m_pDrawModelWrapper->getSdrModel() ); } } @@ -1234,7 +1234,7 @@ ChartView::~ChartView() if( m_pDrawModelWrapper.get() ) { SolarMutexGuard aSolarGuard; - EndListening( m_pDrawModelWrapper->getSdrModel(), false /*bAllDups*/ ); + EndListening( m_pDrawModelWrapper->getSdrModel() ); m_pDrawModelWrapper.reset(); } m_xDrawPage = NULL; @@ -2081,7 +2081,7 @@ sal_Int32 ExplicitValueProvider::getExplicitNumberFormatKeyForDataLabel( OUString aRole( ChartTypeHelper::getRoleOfSequenceForDataLabelNumberFormatDetection( xChartType ) ); Reference< data::XLabeledDataSequence > xLabeledSequence( - DataSeriesHelper::getDataSequenceByRole( xSeriesSource, aRole, false )); + DataSeriesHelper::getDataSequenceByRole( xSeriesSource, aRole )); if( xLabeledSequence.is() ) { Reference< data::XDataSequence > xValues( xLabeledSequence->getValues() ); @@ -2905,7 +2905,7 @@ void SAL_CALL ChartView::removeModeChangeApproveListener( const uno::Reference< // ____ XUpdatable ____ void SAL_CALL ChartView::update() throw (uno::RuntimeException, std::exception) { - impl_updateView(true); + impl_updateView(); //#i100778# migrate all imported or old documents to a plot area sizing exclusive axes (in case the save settings allow for this): //Although in general it is a bad idea to change the model from within the view this is exceptionally the best place to do this special conversion. diff --git a/chart2/source/view/main/GL3DRenderer.cxx b/chart2/source/view/main/GL3DRenderer.cxx index 4d10e4f8b4d2..2dc32a3614fe 100644 --- a/chart2/source/view/main/GL3DRenderer.cxx +++ b/chart2/source/view/main/GL3DRenderer.cxx @@ -439,7 +439,7 @@ void OpenGL3DRenderer::init() m_TextInfoBatch.batchNum = 512; CHECK_GL_ERROR(); glViewport(0, 0, m_iWidth, m_iHeight); - Set3DSenceInfo(0xFFFFFF, true); + Set3DSenceInfo(0xFFFFFF); m_GlobalScaleMatrix = glm::scale(glm::vec3(0.01f, 0.01f, 0.01f)); } diff --git a/chart2/source/view/main/PlottingPositionHelper.cxx b/chart2/source/view/main/PlottingPositionHelper.cxx index 1fab03024824..25a22a649bf0 100644 --- a/chart2/source/view/main/PlottingPositionHelper.cxx +++ b/chart2/source/view/main/PlottingPositionHelper.cxx @@ -625,7 +625,7 @@ drawing::Position3D PolarPlottingPositionHelper::transformLogicToScene( double f this->clipLogicValues( &fX,&fY,&fZ ); double fLogicValueOnAngleAxis = m_bSwapXAndY ? fY : fX; double fLogicValueOnRadiusAxis = m_bSwapXAndY ? fX : fY; - return this->transformAngleRadiusToScene( fLogicValueOnAngleAxis, fLogicValueOnRadiusAxis, fZ, true ); + return this->transformAngleRadiusToScene( fLogicValueOnAngleAxis, fLogicValueOnRadiusAxis, fZ ); } drawing::Position3D PolarPlottingPositionHelper::transformScaledLogicToScene( double fX, double fY, double fZ, bool bClip ) const |