summaryrefslogtreecommitdiff
path: root/chart2/source/view
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2021-08-31 10:46:25 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2021-08-31 14:29:44 +0200
commit6191fc447395e877876290eedf28019a1866958d (patch)
treebef29c6d3a1e4f1320f020b8c35eff1076e82e50 /chart2/source/view
parentbb5425ed3d8cc04e4242059a17912752d6b48c53 (diff)
clang-tidy:readability-redundant-member-init
Change-Id: I5e8baec88d5f17ddda452bd945c87769623cb4e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121357 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2/source/view')
-rw-r--r--chart2/source/view/axes/ScaleAutomatism.cxx2
-rw-r--r--chart2/source/view/axes/VAxisProperties.cxx3
-rw-r--r--chart2/source/view/axes/VCoordinateSystem.cxx2
-rw-r--r--chart2/source/view/axes/VPolarAxis.cxx1
-rw-r--r--chart2/source/view/axes/VPolarGrid.cxx1
-rw-r--r--chart2/source/view/charttypes/PieChart.cxx2
-rw-r--r--chart2/source/view/charttypes/VSeriesPlotter.cxx3
-rw-r--r--chart2/source/view/diagram/VDiagram.cxx1
-rw-r--r--chart2/source/view/main/ChartView.cxx6
-rw-r--r--chart2/source/view/main/PlotterBase.cxx1
-rw-r--r--chart2/source/view/main/PlottingPositionHelper.cxx5
-rw-r--r--chart2/source/view/main/VDataSeries.cxx7
-rw-r--r--chart2/source/view/main/VTitle.cxx1
13 files changed, 3 insertions, 32 deletions
diff --git a/chart2/source/view/axes/ScaleAutomatism.cxx b/chart2/source/view/axes/ScaleAutomatism.cxx
index f433a6bd076b..09da37aba034 100644
--- a/chart2/source/view/axes/ScaleAutomatism.cxx
+++ b/chart2/source/view/axes/ScaleAutomatism.cxx
@@ -64,7 +64,6 @@ ExplicitScaleData::ExplicitScaleData()
, Maximum(10.0)
, Origin(0.0)
, Orientation(css::chart2::AxisOrientation_MATHEMATICAL)
- , Scaling()
, AxisType(css::chart2::AxisType::REALNUMBER)
, ShiftedCategoryPosition(false)
, TimeResolution(css::chart::TimeUnit::DAY)
@@ -84,7 +83,6 @@ ExplicitIncrementData::ExplicitIncrementData()
, Distance(1.0)
, PostEquidistant(true)
, BaseValue(0.0)
- , SubIncrements()
{
}
diff --git a/chart2/source/view/axes/VAxisProperties.cxx b/chart2/source/view/axes/VAxisProperties.cxx
index c6e296e277ed..295ad21a68e6 100644
--- a/chart2/source/view/axes/VAxisProperties.cxx
+++ b/chart2/source/view/axes/VAxisProperties.cxx
@@ -168,9 +168,6 @@ AxisProperties::AxisProperties( const uno::Reference< XAxis >& xAxisModel
, m_nNumberFormatKey(0)
, m_nMajorTickmarks(1)
, m_nMinorTickmarks(1)
- , m_aTickmarkPropertiesList()
- , m_aLineProperties()
- //for category axes
, m_nAxisType(AxisType::REALNUMBER)
, m_bComplexCategories(false)
, m_pExplicitCategoriesProvider(pExplicitCategoriesProvider)
diff --git a/chart2/source/view/axes/VCoordinateSystem.cxx b/chart2/source/view/axes/VCoordinateSystem.cxx
index c9364b63a76a..ded24e5b1353 100644
--- a/chart2/source/view/axes/VCoordinateSystem.cxx
+++ b/chart2/source/view/axes/VCoordinateSystem.cxx
@@ -66,11 +66,9 @@ std::unique_ptr<VCoordinateSystem> VCoordinateSystem::createCoordinateSystem(
VCoordinateSystem::VCoordinateSystem( const Reference< XCoordinateSystem >& xCooSys )
: m_xCooSysModel(xCooSys)
- , m_aMatrixSceneToScreen()
, m_eLeftWallPos(CuboidPlanePosition_Left)
, m_eBackWallPos(CuboidPlanePosition_Back)
, m_eBottomPos(CuboidPlanePosition_Bottom)
- , m_aMergedMinMaxSupplier()
, m_aExplicitScales(3)
, m_aExplicitIncrements(3)
{
diff --git a/chart2/source/view/axes/VPolarAxis.cxx b/chart2/source/view/axes/VPolarAxis.cxx
index 9e41857c29d4..a12055aa5017 100644
--- a/chart2/source/view/axes/VPolarAxis.cxx
+++ b/chart2/source/view/axes/VPolarAxis.cxx
@@ -41,7 +41,6 @@ VPolarAxis::VPolarAxis( const AxisProperties& rAxisProperties
, sal_Int32 nDimensionIndex, sal_Int32 nDimensionCount )
: VAxisBase( nDimensionIndex, nDimensionCount, rAxisProperties, xNumberFormatsSupplier )
, m_pPosHelper( new PolarPlottingPositionHelper() )
- , m_aIncrements()
{
PlotterBase::m_pPosHelper = m_pPosHelper.get();
}
diff --git a/chart2/source/view/axes/VPolarGrid.cxx b/chart2/source/view/axes/VPolarGrid.cxx
index 46d176b6d91b..9233fd1d6472 100644
--- a/chart2/source/view/axes/VPolarGrid.cxx
+++ b/chart2/source/view/axes/VPolarGrid.cxx
@@ -42,7 +42,6 @@ VPolarGrid::VPolarGrid( sal_Int32 nDimensionIndex, sal_Int32 nDimensionCount
: VAxisOrGridBase( nDimensionIndex, nDimensionCount )
, m_aGridPropertiesList( rGridPropertiesList )
, m_pPosHelper( new PolarPlottingPositionHelper() )
- , m_aIncrements()
{
PlotterBase::m_pPosHelper = m_pPosHelper.get();
}
diff --git a/chart2/source/view/charttypes/PieChart.cxx b/chart2/source/view/charttypes/PieChart.cxx
index 08f94d00f513..37d0426b4734 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -893,7 +893,7 @@ void PieChart::createShapes()
}
PieChart::PieLabelInfo::PieLabelInfo()
- : aFirstPosition(), aOrigin(), fValue(0.0)
+ : fValue(0.0)
, bMovementAllowed(false), bMoved(false)
, bShowLeaderLine(false), pPrevious(nullptr)
, pNext(nullptr)
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index ee89ab640134..b0a591d3c065 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -104,7 +104,6 @@ VDataSeriesGroup::VDataSeriesGroup( std::unique_ptr<VDataSeries> pSeries )
: m_aSeriesVector(1)
, m_bMaxPointCountDirty(true)
, m_nMaxPointCount(0)
- , m_aListOfCachedYValues()
{
m_aSeriesVector[0] = std::move(pSeries);
}
@@ -144,11 +143,9 @@ VSeriesPlotter::VSeriesPlotter( const uno::Reference<XChartType>& xChartTypeMode
, m_pMainPosHelper( nullptr )
, m_xChartTypeModel(xChartTypeModel)
, m_xChartTypeModelProps( uno::Reference< beans::XPropertySet >::query( xChartTypeModel ))
- , m_aZSlots()
, m_bCategoryXAxis(bCategoryXAxis)
, m_nTimeResolution(css::chart::TimeUnit::DAY)
, m_aNullDate(30,12,1899)
- , m_xColorScheme()
, m_pExplicitCategoriesProvider(nullptr)
, m_bPointsWereSkipped(false)
, m_bPieLabelsAllowToMove(false)
diff --git a/chart2/source/view/diagram/VDiagram.cxx b/chart2/source/view/diagram/VDiagram.cxx
index bf3c96e82d53..d9b2eddd7cc0 100644
--- a/chart2/source/view/diagram/VDiagram.cxx
+++ b/chart2/source/view/diagram/VDiagram.cxx
@@ -47,7 +47,6 @@ VDiagram::VDiagram(
, m_nDimensionCount(nDimension)
, m_xDiagram(xDiagram)
, m_aPreferredAspectRatio(rPreferredAspectRatio)
- , m_xAspectRatio3D()
, m_fXAnglePi(0)
, m_fYAnglePi(0)
, m_fZAnglePi(0)
diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx
index 7a02ba66b5d8..c9ef9f953bb6 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -1040,12 +1040,8 @@ const uno::Sequence<sal_Int8>& ExplicitValueProvider::getUnoTunnelId()
ChartView::ChartView(
uno::Reference<uno::XComponentContext> const & xContext,
ChartModel& rModel)
- : m_aMutex()
- , m_xCC(xContext)
+ : m_xCC(xContext)
, mrChartModel(rModel)
- , m_xShapeFactory()
- , m_xDrawPage()
- , m_pDrawModelWrapper()
, m_aListenerContainer( m_aMutex )
, m_bViewDirty(true)
, m_bInViewUpdate(false)
diff --git a/chart2/source/view/main/PlotterBase.cxx b/chart2/source/view/main/PlotterBase.cxx
index 9de0a8133b4e..b3311b023cbf 100644
--- a/chart2/source/view/main/PlotterBase.cxx
+++ b/chart2/source/view/main/PlotterBase.cxx
@@ -29,7 +29,6 @@ using namespace ::com::sun::star::chart2;
PlotterBase::PlotterBase( sal_Int32 nDimensionCount )
: m_pShapeFactory(nullptr)
- , m_aCID()
, m_nDimension(nDimensionCount)
, m_pPosHelper(nullptr)
{
diff --git a/chart2/source/view/main/PlottingPositionHelper.cxx b/chart2/source/view/main/PlottingPositionHelper.cxx
index 69a346b067e3..ae499fa82fb9 100644
--- a/chart2/source/view/main/PlottingPositionHelper.cxx
+++ b/chart2/source/view/main/PlottingPositionHelper.cxx
@@ -39,9 +39,7 @@ using namespace ::com::sun::star;
using namespace ::com::sun::star::chart2;
PlottingPositionHelper::PlottingPositionHelper()
- : m_aScales()
- , m_aMatrixScreenToScene()
- , m_bSwapXAndY( false )
+ : m_bSwapXAndY( false )
, m_nXResolution( 1000 )
, m_nYResolution( 1000 )
, m_nZResolution( 1000 )
@@ -316,7 +314,6 @@ drawing::Direction3D PlottingPositionHelper::getScaledLogicWidth() const
PolarPlottingPositionHelper::PolarPlottingPositionHelper()
: m_fRadiusOffset(0.0)
, m_fAngleDegreeOffset(90.0)
- , m_aUnitCartesianToScene()
{
m_bMaySkipPointsInRegressionCalculation = false;
}
diff --git a/chart2/source/view/main/VDataSeries.cxx b/chart2/source/view/main/VDataSeries.cxx
index 1135174c24d3..b3047d4126b3 100644
--- a/chart2/source/view/main/VDataSeries.cxx
+++ b/chart2/source/view/main/VDataSeries.cxx
@@ -144,22 +144,15 @@ VDataSeries::VDataSeries( const uno::Reference< XDataSeries >& xDataSeries )
, m_fLogicZPos(0.0)
, m_xDataSeries(xDataSeries)
, m_nPointCount(0)
-
, m_pValueSequenceForDataLabelNumberFormatDetection(&m_aValues_Y)
-
, m_fXMeanValue(std::numeric_limits<double>::quiet_NaN())
, m_fYMeanValue(std::numeric_limits<double>::quiet_NaN())
-
- , m_aAttributedDataPointIndexList()
-
, m_eStackingDirection(StackingDirection_NO_STACKING)
, m_nAxisIndex(0)
, m_bConnectBars(false)
, m_bGroupBarsPerAxis(true)
, m_nStartingAngle(90)
-
, m_nGlobalSeriesIndex(0)
-
, m_nCurrentAttributedPoint(-1)
, m_nMissingValueTreatment(css::chart::MissingValueTreatment::LEAVE_GAP)
, m_bAllowPercentValueInDataLabel(false)
diff --git a/chart2/source/view/main/VTitle.cxx b/chart2/source/view/main/VTitle.cxx
index ad2e857101fb..79d5d7a28256 100644
--- a/chart2/source/view/main/VTitle.cxx
+++ b/chart2/source/view/main/VTitle.cxx
@@ -32,7 +32,6 @@ using namespace ::com::sun::star::chart2;
VTitle::VTitle( const uno::Reference< XTitle > & xTitle )
: m_xTitle(xTitle)
- , m_aCID()
, m_fRotationAngleDegree(0.0)
, m_nXPos(0)
, m_nYPos(0)