improve defaultparams loplugin

to catch calling params with defaults like "= OUSString()"

Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9
Reviewed-on: https://gerrit.libreoffice.org/22932
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

8 files changed, 18 insertions, 18 deletions

diff --git a/chart2/source/view/charttypes/AreaChart.cxx b/chart2/source/view/charttypes/AreaChart.cxx
index 3fe22b70c283..8618f269d062 100644
--- a/chart2/source/view/charttypes/AreaChart.cxx
+++ b/chart2/source/view/charttypes/AreaChart.cxx
@@ -651,13 +651,13 @@ void AreaChart::createShapes()
 
     //therefore create an own group for the texts and the error bars to move them to front
     //(because the text group is created after the series group the texts are displayed on top)
-    m_xSeriesTarget   = createGroupShape( m_xLogicTarget,OUString() );
+    m_xSeriesTarget   = createGroupShape( m_xLogicTarget );
     if( m_bArea )
-        m_xErrorBarTarget = createGroupShape( m_xLogicTarget,OUString() );
+        m_xErrorBarTarget = createGroupShape( m_xLogicTarget );
     else
         m_xErrorBarTarget = m_xSeriesTarget;
-    m_xTextTarget     = m_pShapeFactory->createGroup2D( m_xFinalTarget,OUString() );
-    m_xRegressionCurveEquationTarget = m_pShapeFactory->createGroup2D( m_xFinalTarget,OUString() );
+    m_xTextTarget     = m_pShapeFactory->createGroup2D( m_xFinalTarget );
+    m_xRegressionCurveEquationTarget = m_pShapeFactory->createGroup2D( m_xFinalTarget );
 
     //check necessary here that different Y axis can not be stacked in the same group? ... hm?
 
diff --git a/chart2/source/view/charttypes/BarChart.cxx b/chart2/source/view/charttypes/BarChart.cxx
index cd2019ed024d..10759c3dad4d 100644
--- a/chart2/source/view/charttypes/BarChart.cxx
+++ b/chart2/source/view/charttypes/BarChart.cxx
@@ -423,14 +423,14 @@ void BarChart::createShapes()
     //to achieve this the regression curve target is created after the series target and before the text target
 
     uno::Reference< drawing::XShapes > xSeriesTarget(
-        createGroupShape( m_xLogicTarget,OUString() ));
+        createGroupShape( m_xLogicTarget ));
     uno::Reference< drawing::XShapes > xRegressionCurveTarget(
-        createGroupShape( m_xLogicTarget,OUString() ));
+        createGroupShape( m_xLogicTarget ));
     uno::Reference< drawing::XShapes > xTextTarget(
-        m_pShapeFactory->createGroup2D( m_xFinalTarget,OUString() ));
+        m_pShapeFactory->createGroup2D( m_xFinalTarget ));
 
     uno::Reference< drawing::XShapes > xRegressionCurveEquationTarget(
-        m_pShapeFactory->createGroup2D( m_xFinalTarget,OUString() ));
+        m_pShapeFactory->createGroup2D( m_xFinalTarget ));
     //check necessary here that different Y axis can not be stacked in the same group? ... hm?
 
     double fLogicZ        = 1.0;//as defined
diff --git a/chart2/source/view/charttypes/BubbleChart.cxx b/chart2/source/view/charttypes/BubbleChart.cxx
index 11004bb1e54f..2f8356044454 100644
--- a/chart2/source/view/charttypes/BubbleChart.cxx
+++ b/chart2/source/view/charttypes/BubbleChart.cxx
@@ -200,9 +200,9 @@ void BubbleChart::createShapes()
     //therefore create an own group for the texts and the error bars to move them to front
     //(because the text group is created after the series group the texts are displayed on top)
     uno::Reference< drawing::XShapes > xSeriesTarget(
-        createGroupShape( m_xLogicTarget,OUString() ));
+        createGroupShape( m_xLogicTarget ));
     uno::Reference< drawing::XShapes > xTextTarget(
-        m_pShapeFactory->createGroup2D( m_xFinalTarget,OUString() ));
+        m_pShapeFactory->createGroup2D( m_xFinalTarget ));
 
     //update/create information for current group
     double fLogicZ = 1.0;//as defined
diff --git a/chart2/source/view/charttypes/CandleStickChart.cxx b/chart2/source/view/charttypes/CandleStickChart.cxx
index d8af62579d0c..892e9e1a5ea4 100644
--- a/chart2/source/view/charttypes/CandleStickChart.cxx
+++ b/chart2/source/view/charttypes/CandleStickChart.cxx
@@ -92,7 +92,7 @@ void CandleStickChart::createShapes()
     //(because the text group is created after the series group the texts are displayed on top)
 
     uno::Reference< drawing::XShapes > xSeriesTarget(
-        createGroupShape( m_xLogicTarget,OUString() ));
+        createGroupShape( m_xLogicTarget ));
     uno::Reference< drawing::XShapes > xLossTarget(
         createGroupShape( m_xLogicTarget, ObjectIdentifier::createClassifiedIdentifier(
             OBJECTTYPE_DATA_STOCK_LOSS, OUString() )));
@@ -100,7 +100,7 @@ void CandleStickChart::createShapes()
         createGroupShape( m_xLogicTarget, ObjectIdentifier::createClassifiedIdentifier(
             OBJECTTYPE_DATA_STOCK_GAIN, OUString() )));
     uno::Reference< drawing::XShapes > xTextTarget(
-        m_pShapeFactory->createGroup2D( m_xFinalTarget,OUString() ));
+        m_pShapeFactory->createGroup2D( m_xFinalTarget ));
 
     //check necessary here that different Y axis can not be stacked in the same group? ... hm?
 
diff --git a/chart2/source/view/charttypes/NetChart.cxx b/chart2/source/view/charttypes/NetChart.cxx
index 3f971b26719d..a922b54a7b6c 100644
--- a/chart2/source/view/charttypes/NetChart.cxx
+++ b/chart2/source/view/charttypes/NetChart.cxx
@@ -356,8 +356,8 @@ void NetChart::createShapes()
 
     //therefore create an own group for the texts and the error bars to move them to front
     //(because the text group is created after the series group the texts are displayed on top)
-    m_xSeriesTarget   = createGroupShape( m_xLogicTarget,OUString() );
-    m_xTextTarget     = m_pShapeFactory->createGroup2D( m_xFinalTarget,OUString() );
+    m_xSeriesTarget   = createGroupShape( m_xLogicTarget );
+    m_xTextTarget     = m_pShapeFactory->createGroup2D( m_xFinalTarget );
 
     //check necessary here that different Y axis can not be stacked in the same group? ... hm?
 
diff --git a/chart2/source/view/charttypes/PieChart.cxx b/chart2/source/view/charttypes/PieChart.cxx
index b083f246ac98..9d0458330036 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -506,9 +506,9 @@ void PieChart::createShapes()
     ///(because the text group is created after the series group the texts are
     ///displayed on top)
     uno::Reference< drawing::XShapes > xSeriesTarget(
-        createGroupShape( m_xLogicTarget,OUString() ));
+        createGroupShape( m_xLogicTarget ));
     uno::Reference< drawing::XShapes > xTextTarget(
-        m_pShapeFactory->createGroup2D( m_xFinalTarget,OUString() ));
+        m_pShapeFactory->createGroup2D( m_xFinalTarget ));
     //check necessary here that different Y axis can not be stacked in the same group? ... hm?
 
     ///pay attention that the `m_bSwapXAndY` parameter used by the polar
diff --git a/chart2/source/view/diagram/VDiagram.cxx b/chart2/source/view/diagram/VDiagram.cxx
index 656f0aa1947f..85915f4e350f 100644
--- a/chart2/source/view/diagram/VDiagram.cxx
+++ b/chart2/source/view/diagram/VDiagram.cxx
@@ -479,7 +479,7 @@ void VDiagram::createShapes_3d()
             uno::Reference<drawing::XShapes>( m_xOuterGroupShape, uno::UNO_QUERY );
 
     //create additional group to manipulate the aspect ratio of the whole diagram:
-    xOuterGroup_Shapes = m_pShapeFactory->createGroup3D( xOuterGroup_Shapes, OUString() );
+    xOuterGroup_Shapes = m_pShapeFactory->createGroup3D( xOuterGroup_Shapes );
 
     m_xAspectRatio3D.set( xOuterGroup_Shapes, uno::UNO_QUERY );
 
diff --git a/chart2/source/view/main/ShapeFactory.cxx b/chart2/source/view/main/ShapeFactory.cxx
index 5e5ad546ef79..821d77422ec9 100644
--- a/chart2/source/view/main/ShapeFactory.cxx
+++ b/chart2/source/view/main/ShapeFactory.cxx
@@ -455,7 +455,7 @@ uno::Reference<drawing::XShape>
     if( !xTarget.is() )
         return nullptr;
 
-    Reference< drawing::XShapes > xGroup( ShapeFactory::createGroup3D( xTarget, OUString() ) );
+    Reference< drawing::XShapes > xGroup( ShapeFactory::createGroup3D( xTarget ) );
 
     bool bDoubleSided = false;
     short nRotatedTexture = 0;