summaryrefslogtreecommitdiff
path: root/chart2/source
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2019-10-14 14:59:06 +0100
committerCaolán McNamara <caolanm@redhat.com>2019-10-14 20:30:00 +0200
commit5c921a617da29eeeedc6f78dd34263963efeeac0 (patch)
treed0b620cd34189ea2394751812b545f2014f5ba84 /chart2/source
parent4e0241697371c40f4348bdfb6585a872d4cbcbf6 (diff)
Resolves: tdf#128134 page creation order affecting travel
the page is created before the page is moved to, so CanTravel gets locked. Only lock when the page is the current page Change-Id: Ic21fe3077a750e1279db8be0dd5c7f9112c999b1 Reviewed-on: https://gerrit.libreoffice.org/80779 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'chart2/source')
-rw-r--r--chart2/source/controller/dialogs/dlg_CreationWizard.cxx10
1 files changed, 6 insertions, 4 deletions
diff --git a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
index ef67bf7fe568..89f60fa929d2 100644
--- a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
+++ b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
@@ -156,14 +156,16 @@ void CreationWizard::enterState(WizardState nState)
vcl::RoadmapWizardMachine::enterState(nState);
}
-void CreationWizard::setInvalidPage( BuilderPage * /* pTabPage */ )
+void CreationWizard::setInvalidPage(BuilderPage* pTabPage)
{
- m_bCanTravel = false;
+ if (pTabPage == m_pCurTabPage)
+ m_bCanTravel = false;
}
-void CreationWizard::setValidPage( BuilderPage * /* pTabPage */ )
+void CreationWizard::setValidPage(BuilderPage* pTabPage)
{
- m_bCanTravel = true;
+ if (pTabPage == m_pCurTabPage)
+ m_bCanTravel = true;
}
OUString CreationWizard::getStateDisplayName( WizardState nState ) const