diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2019-10-08 14:55:25 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2019-10-08 18:07:57 +0200 |
| commit | 8ec3116162e030709c42420fc70e7423db9a06df (patch) | |
| tree | 360506ec2ca6a131969b2a587d2d16e9db305740 /chart2/source | |
| parent | 7dbebef754b66e28e92be200be434d17006d3767 (diff) | |
Introduce o3tl::unsafe_downcast for known-good dynamic_cast downcasts
(This helps rewrite code that silences Coverity unchecked dynamic_cast warnings,
like 57b89ea1c2ff07b53c3cc002e5ec9e52abd0c1bd "coverity#704563 Unchecked dynamic
cast", in a way that is cleaner and potentially executes faster.)
Change-Id: I3319c0eeec2aa822f686feacd499a76c8c9b9499
Reviewed-on: https://gerrit.libreoffice.org/80458
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'chart2/source')
| -rw-r--r-- | chart2/source/controller/main/DrawCommandDispatch.cxx | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/chart2/source/controller/main/DrawCommandDispatch.cxx b/chart2/source/controller/main/DrawCommandDispatch.cxx index 0c46970d926a..e8230b1d2eab 100644 --- a/chart2/source/controller/main/DrawCommandDispatch.cxx +++ b/chart2/source/controller/main/DrawCommandDispatch.cxx @@ -24,6 +24,7 @@ #include <chartview/DrawModelWrapper.hxx> #include <com/sun/star/frame/CommandGroup.hpp> +#include <o3tl/unsafe_downcast.hxx> #include <vcl/svapp.hxx> #include <svl/itempool.hxx> #include <editeng/adjustitem.hxx> @@ -161,12 +162,7 @@ void DrawCommandDispatch::setAttributes( SdrObject* pObj ) pObj->SetMergedItem( SdrTextHorzAdjustItem( SDRTEXTHORZADJUST_BLOCK ) ); pObj->SetMergedItem( makeSdrTextAutoGrowHeightItem( false ) ); - SdrObjCustomShape* pShape(dynamic_cast< SdrObjCustomShape* >( pObj )); - assert(pShape); - if(pShape) - { - pShape->MergeDefaultAttributes( &m_aCustomShapeType ); - } + o3tl::unsafe_downcast< SdrObjCustomShape* >( pObj )->MergeDefaultAttributes( &m_aCustomShapeType ); } } } |