diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-06 14:31:52 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-07 07:25:29 +0100 |
commit | 8169a0e5a10defde3e0f53137734fd06ffca85d7 (patch) | |
tree | 49ca64d53ba080db4b75ce7f51283c40e50e347e /chart2/source | |
parent | be354a2abd27548405caf97fdbc814b5a6b06995 (diff) |
loplugin:countusersofdefaultparams in chart2
Change-Id: Ibad415d2c539b2438e4939c2c23f32d84a5a677f
Reviewed-on: https://gerrit.libreoffice.org/45948
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2/source')
22 files changed, 29 insertions, 29 deletions
diff --git a/chart2/source/controller/inc/AccessibleBase.hxx b/chart2/source/controller/inc/AccessibleBase.hxx index c881be5786b6..5055f7b009b5 100644 --- a/chart2/source/controller/inc/AccessibleBase.hxx +++ b/chart2/source/controller/inc/AccessibleBase.hxx @@ -101,7 +101,7 @@ public: AccessibleBase( const AccessibleElementInfo & rAccInfo, bool bMayHaveChildren, - bool bAlwaysTransparent = false ); + bool bAlwaysTransparent ); virtual ~AccessibleBase() override; protected: diff --git a/chart2/source/controller/inc/AxisItemConverter.hxx b/chart2/source/controller/inc/AxisItemConverter.hxx index 5f4ca5309ef7..ad742691ada5 100644 --- a/chart2/source/controller/inc/AxisItemConverter.hxx +++ b/chart2/source/controller/inc/AxisItemConverter.hxx @@ -39,9 +39,9 @@ public: const css::uno::Reference<css::beans::XPropertySet>& rPropertySet, SfxItemPool& rItemPool, SdrModel& rDrawModel, const css::uno::Reference<css::chart2::XChartDocument> & xChartDoc, - ExplicitScaleData const * pScale = nullptr, - ExplicitIncrementData const * pIncrement = nullptr, - const css::awt::Size* pRefSize = nullptr ); + ExplicitScaleData const * pScale, + ExplicitIncrementData const * pIncrement, + const css::awt::Size* pRefSize ); virtual ~AxisItemConverter() override; diff --git a/chart2/source/controller/inc/DataPointItemConverter.hxx b/chart2/source/controller/inc/DataPointItemConverter.hxx index 1cf452b1c1a6..61b91abe8f68 100644 --- a/chart2/source/controller/inc/DataPointItemConverter.hxx +++ b/chart2/source/controller/inc/DataPointItemConverter.hxx @@ -44,7 +44,7 @@ public: SfxItemPool& rItemPool, SdrModel& rDrawModel, const css::uno::Reference<css::lang::XMultiServiceFactory>& xNamedPropertyContainerFactory, - GraphicObjectType eMapTo = GraphicObjectType::FilledDataPoint, + GraphicObjectType eMapTo, const css::awt::Size* pRefSize = nullptr, bool bDataSeries = false, bool bUseSpecialFillColor = false, diff --git a/chart2/source/controller/inc/GraphicPropertyItemConverter.hxx b/chart2/source/controller/inc/GraphicPropertyItemConverter.hxx index ceeb5811dfe2..6f09b20c78d5 100644 --- a/chart2/source/controller/inc/GraphicPropertyItemConverter.hxx +++ b/chart2/source/controller/inc/GraphicPropertyItemConverter.hxx @@ -46,7 +46,7 @@ public: SfxItemPool& rItemPool, SdrModel& rDrawModel, const css::uno::Reference< css::lang::XMultiServiceFactory > & xNamedPropertyContainerFactory, - GraphicObjectType eObjectType = GraphicObjectType::FilledDataPoint ); + GraphicObjectType eObjectType ); virtual ~GraphicPropertyItemConverter() override; protected: diff --git a/chart2/source/controller/inc/LegendItemConverter.hxx b/chart2/source/controller/inc/LegendItemConverter.hxx index 8d24a15718aa..d039e84d34a8 100644 --- a/chart2/source/controller/inc/LegendItemConverter.hxx +++ b/chart2/source/controller/inc/LegendItemConverter.hxx @@ -40,7 +40,7 @@ public: SfxItemPool& rItemPool, SdrModel& rDrawModel, const css::uno::Reference< css::lang::XMultiServiceFactory > & xNamedPropertyContainerFactory, - const css::awt::Size* pRefSize = nullptr ); + const css::awt::Size* pRefSize ); virtual ~LegendItemConverter() override; diff --git a/chart2/source/controller/inc/MultipleChartConverters.hxx b/chart2/source/controller/inc/MultipleChartConverters.hxx index 37a9f8b0cde1..8969a106ce93 100644 --- a/chart2/source/controller/inc/MultipleChartConverters.hxx +++ b/chart2/source/controller/inc/MultipleChartConverters.hxx @@ -35,7 +35,7 @@ public: const css::uno::Reference<css::frame::XModel> & xChartModel, SfxItemPool& rItemPool, SdrModel& rDrawModel, - const css::awt::Size* pRefSize = nullptr ); + const css::awt::Size* pRefSize ); virtual ~AllAxisItemConverter() override; diff --git a/chart2/source/controller/inc/ObjectHierarchy.hxx b/chart2/source/controller/inc/ObjectHierarchy.hxx index 1c6f0761fa33..76a694dac9f0 100644 --- a/chart2/source/controller/inc/ObjectHierarchy.hxx +++ b/chart2/source/controller/inc/ObjectHierarchy.hxx @@ -50,7 +50,7 @@ public: */ explicit ObjectHierarchy( const css::uno::Reference< css::chart2::XChartDocument > & xChartDocument, - ExplicitValueProvider * pExplicitValueProvider = nullptr, + ExplicitValueProvider * pExplicitValueProvider, bool bFlattenDiagram = false, bool bOrderingForElementSelector = false ); ~ObjectHierarchy(); @@ -80,7 +80,7 @@ class ObjectKeyNavigation public: explicit ObjectKeyNavigation( const ObjectIdentifier & rCurrentOID, const css::uno::Reference< css::chart2::XChartDocument > & xChartDocument, - ExplicitValueProvider * pExplicitValueProvider = nullptr ); + ExplicitValueProvider * pExplicitValueProvider ); bool handleKeyEvent( const css::awt::KeyEvent & rEvent ); const ObjectIdentifier& getCurrentSelection() const { return m_aCurrentOID;} diff --git a/chart2/source/controller/inc/RegressionEquationItemConverter.hxx b/chart2/source/controller/inc/RegressionEquationItemConverter.hxx index 22c49be4d6ec..c664acc1858c 100644 --- a/chart2/source/controller/inc/RegressionEquationItemConverter.hxx +++ b/chart2/source/controller/inc/RegressionEquationItemConverter.hxx @@ -40,7 +40,7 @@ public: SfxItemPool& rItemPool, SdrModel& rDrawModel, const css::uno::Reference< css::lang::XMultiServiceFactory > & xNamedPropertyContainerFactory, - const css::awt::Size* pRefSize = nullptr ); + const css::awt::Size* pRefSize ); virtual ~RegressionEquationItemConverter() override; diff --git a/chart2/source/controller/inc/TextLabelItemConverter.hxx b/chart2/source/controller/inc/TextLabelItemConverter.hxx index b23dd3329e20..1cde585eeb7b 100644 --- a/chart2/source/controller/inc/TextLabelItemConverter.hxx +++ b/chart2/source/controller/inc/TextLabelItemConverter.hxx @@ -37,10 +37,10 @@ public: const css::uno::Reference<css::beans::XPropertySet>& rPropertySet, const css::uno::Reference<css::chart2::XDataSeries>& xSeries, SfxItemPool& rItemPool, - const css::awt::Size* pRefSize = nullptr, - bool bDataSeries = false, - sal_Int32 nNumberFormat = 0, - sal_Int32 nPercentNumberFormat = 0 ); + const css::awt::Size* pRefSize, + bool bDataSeries, + sal_Int32 nNumberFormat, + sal_Int32 nPercentNumberFormat ); virtual ~TextLabelItemConverter() override; diff --git a/chart2/source/controller/inc/TitleItemConverter.hxx b/chart2/source/controller/inc/TitleItemConverter.hxx index 8f2b9c746c47..7e88fe659b6f 100644 --- a/chart2/source/controller/inc/TitleItemConverter.hxx +++ b/chart2/source/controller/inc/TitleItemConverter.hxx @@ -36,7 +36,7 @@ public: const css::uno::Reference<css::beans::XPropertySet>& rPropertySet, SfxItemPool& rItemPool, SdrModel& rDrawModel, const css::uno::Reference<css::lang::XMultiServiceFactory>& xNamedPropertyContainerFactory, - const css::awt::Size* pRefSize = nullptr ); + const css::awt::Size* pRefSize ); virtual ~TitleItemConverter() override; diff --git a/chart2/source/controller/main/ChartTransferable.hxx b/chart2/source/controller/main/ChartTransferable.hxx index 1e950e236d34..35e4f5d514c1 100644 --- a/chart2/source/controller/main/ChartTransferable.hxx +++ b/chart2/source/controller/main/ChartTransferable.hxx @@ -36,7 +36,7 @@ namespace chart class ChartTransferable : public TransferableHelper { public: - explicit ChartTransferable( SdrModel* pDrawModel, SdrObject* pSelectedObj, bool bDrawing = false ); + explicit ChartTransferable( SdrModel* pDrawModel, SdrObject* pSelectedObj, bool bDrawing ); virtual ~ChartTransferable() override; protected: diff --git a/chart2/source/model/inc/BaseCoordinateSystem.hxx b/chart2/source/model/inc/BaseCoordinateSystem.hxx index b29116e92de9..82df7be4599b 100644 --- a/chart2/source/model/inc/BaseCoordinateSystem.hxx +++ b/chart2/source/model/inc/BaseCoordinateSystem.hxx @@ -56,7 +56,7 @@ class BaseCoordinateSystem : public: BaseCoordinateSystem( const css::uno::Reference< css::uno::XComponentContext > & xContext, - sal_Int32 nDimensionCount = 2 ); + sal_Int32 nDimensionCount ); explicit BaseCoordinateSystem( const BaseCoordinateSystem & rSource ); virtual ~BaseCoordinateSystem() override; diff --git a/chart2/source/model/inc/CartesianCoordinateSystem.hxx b/chart2/source/model/inc/CartesianCoordinateSystem.hxx index 75d9aa2288b7..0b3c5c0a0172 100644 --- a/chart2/source/model/inc/CartesianCoordinateSystem.hxx +++ b/chart2/source/model/inc/CartesianCoordinateSystem.hxx @@ -29,7 +29,7 @@ class CartesianCoordinateSystem : public BaseCoordinateSystem public: explicit CartesianCoordinateSystem( const css::uno::Reference< css::uno::XComponentContext > & xContext, - sal_Int32 nDimensionCount = 2 ); + sal_Int32 nDimensionCount ); explicit CartesianCoordinateSystem( const CartesianCoordinateSystem & rSource ); virtual ~CartesianCoordinateSystem() override; diff --git a/chart2/source/model/inc/PolarCoordinateSystem.hxx b/chart2/source/model/inc/PolarCoordinateSystem.hxx index f4d86ee18311..2c0017caa8b7 100644 --- a/chart2/source/model/inc/PolarCoordinateSystem.hxx +++ b/chart2/source/model/inc/PolarCoordinateSystem.hxx @@ -29,7 +29,7 @@ class PolarCoordinateSystem : public BaseCoordinateSystem public: explicit PolarCoordinateSystem( const css::uno::Reference< css::uno::XComponentContext > & xContext, - sal_Int32 nDimensionCount = 2 ); + sal_Int32 nDimensionCount ); explicit PolarCoordinateSystem( const PolarCoordinateSystem & rSource ); virtual ~PolarCoordinateSystem() override; diff --git a/chart2/source/model/template/PieChartTypeTemplate.hxx b/chart2/source/model/template/PieChartTypeTemplate.hxx index 3715679eb9da..f11099fdd9f5 100644 --- a/chart2/source/model/template/PieChartTypeTemplate.hxx +++ b/chart2/source/model/template/PieChartTypeTemplate.hxx @@ -39,7 +39,7 @@ public: css::uno::Reference< css::uno::XComponentContext > const & xContext, const OUString & rServiceName, css::chart2::PieChartOffsetMode eMode, - bool bRings = false, + bool bRings, sal_Int32 nDim = 2 ); virtual ~PieChartTypeTemplate() override; diff --git a/chart2/source/view/charttypes/AreaChart.hxx b/chart2/source/view/charttypes/AreaChart.hxx index 0a471426c9aa..119e0a51d5b6 100644 --- a/chart2/source/view/charttypes/AreaChart.hxx +++ b/chart2/source/view/charttypes/AreaChart.hxx @@ -40,7 +40,7 @@ public: virtual ~AreaChart() override; virtual void createShapes() override; - virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override; + virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot ) override; virtual css::drawing::Direction3D getPreferredDiagramAspectRatio() const override; diff --git a/chart2/source/view/charttypes/BarChart.hxx b/chart2/source/view/charttypes/BarChart.hxx index ee028a2cbdb5..c35c7321e8a0 100644 --- a/chart2/source/view/charttypes/BarChart.hxx +++ b/chart2/source/view/charttypes/BarChart.hxx @@ -38,7 +38,7 @@ public: virtual ~BarChart() override; virtual void createShapes() override; - virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override; + virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot ) override; virtual css::drawing::Direction3D getPreferredDiagramAspectRatio() const override; diff --git a/chart2/source/view/charttypes/CandleStickChart.hxx b/chart2/source/view/charttypes/CandleStickChart.hxx index 019864ad7140..af19e2d1e0ba 100644 --- a/chart2/source/view/charttypes/CandleStickChart.hxx +++ b/chart2/source/view/charttypes/CandleStickChart.hxx @@ -38,7 +38,7 @@ public: virtual ~CandleStickChart() override; virtual void createShapes() override; - virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override; + virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot ) override; virtual css::drawing::Direction3D getPreferredDiagramAspectRatio() const override; diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx index c6e1b26d9e16..a7a3f2feae20 100644 --- a/chart2/source/view/charttypes/GL3DBarChart.cxx +++ b/chart2/source/view/charttypes/GL3DBarChart.cxx @@ -159,7 +159,7 @@ class RenderAnimationThread : public RenderThread { public: RenderAnimationThread(GL3DBarChart* pChart, const glm::vec3& rStartPos, const glm::vec3& rEndPos, - const sal_Int32 nSteps = STEPS): + const sal_Int32 nSteps): RenderThread(pChart), maStartPos(rStartPos), maEndPos(rEndPos), diff --git a/chart2/source/view/charttypes/PieChart.hxx b/chart2/source/view/charttypes/PieChart.hxx index 7cae89931c4d..0b97eb1090df 100644 --- a/chart2/source/view/charttypes/PieChart.hxx +++ b/chart2/source/view/charttypes/PieChart.hxx @@ -46,7 +46,7 @@ public: virtual void rearrangeLabelToAvoidOverlapIfRequested( const css::awt::Size& rPageSize ) override; virtual void setScales( const std::vector< ExplicitScaleData >& rScales, bool bSwapXAndYAxis ) override; - virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ) override; + virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot ) override; virtual css::drawing::Direction3D getPreferredDiagramAspectRatio() const override; virtual bool shouldSnapRectToUsedArea() override; diff --git a/chart2/source/view/inc/VDiagram.hxx b/chart2/source/view/inc/VDiagram.hxx index 6dc7fbd1924e..f867a0a2f4b1 100644 --- a/chart2/source/view/inc/VDiagram.hxx +++ b/chart2/source/view/inc/VDiagram.hxx @@ -41,7 +41,7 @@ class VDiagram final public: //methods VDiagram( const css::uno::Reference<css::chart2::XDiagram>& xDiagram, const css::drawing::Direction3D& rPreferredAspectRatio, - sal_Int32 nDimension = 3 ); + sal_Int32 nDimension ); ~VDiagram(); void init( diff --git a/chart2/source/view/inc/VSeriesPlotter.hxx b/chart2/source/view/inc/VSeriesPlotter.hxx index 54f3f7733d63..6702f9833420 100644 --- a/chart2/source/view/inc/VSeriesPlotter.hxx +++ b/chart2/source/view/inc/VSeriesPlotter.hxx @@ -124,7 +124,7 @@ public: virtual ~VSeriesPlotter() override; - /* + /** * A new series can be positioned relative to other series in a chart. * This positioning has two dimensions. First a series can be placed * next to each other on the category axis. This position is indicated by xSlot. @@ -139,7 +139,7 @@ public: * ySlot == already occupied : insert at given y and x position * ySlot > occupied : stack on top at given x position */ - virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot = -1, sal_Int32 xSlot = -1,sal_Int32 ySlot = -1 ); + virtual void addSeries( VDataSeries* pSeries, sal_Int32 zSlot, sal_Int32 xSlot, sal_Int32 ySlot ); /** a value <= 0 for a directions means that this direction can be stretched arbitrary */ |