make some methods final in chart OPropertySet

so that the subclasses use the right overrides to implement custom
behaviour

Change-Id: Ida9d1de51b5595c4d9532a5c98a220bf39d9a208
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149940
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

3 files changed, 16 insertions, 16 deletions

diff --git a/chart2/source/inc/Diagram.hxx b/chart2/source/inc/Diagram.hxx
index eba06976cbbf..65532a9a512d 100644
--- a/chart2/source/inc/Diagram.hxx
+++ b/chart2/source/inc/Diagram.hxx
@@ -106,7 +106,7 @@ public:
         getPropertySetInfo() override;
 
     // ____ XFastPropertySet ____
-    virtual void SAL_CALL setFastPropertyValue( sal_Int32 nHandle, const css::uno::Any& rValue ) override;
+    virtual void SAL_CALL setFastPropertyValue_NoBroadcast( sal_Int32 nHandle, const css::uno::Any& rValue ) override;
 
     /// make original interface function visible again
     using ::com::sun::star::beans::XFastPropertySet::getFastPropertyValue;
diff --git a/chart2/source/inc/OPropertySet.hxx b/chart2/source/inc/OPropertySet.hxx
index 6e7770174c75..aa5d2e7cd4ba 100644
--- a/chart2/source/inc/OPropertySet.hxx
+++ b/chart2/source/inc/OPropertySet.hxx
@@ -105,7 +105,7 @@ protected:
         ( css::uno::Any & rConvertedValue,
           css::uno::Any & rOldValue,
           sal_Int32 nHandle,
-          const css::uno::Any& rValue ) override;
+          const css::uno::Any& rValue ) override final;
 
     /** The same as setFastPropertyValue; nHandle is always valid.
         The changes must not be broadcasted in this method.
@@ -145,7 +145,7 @@ protected:
 
 public:
     /// make original interface function visible again
-    using ::com::sun::star::beans::XFastPropertySet::getFastPropertyValue;
+    using ::cppu::OPropertySetHelper::getFastPropertyValue;
 
     // Interfaces
 
@@ -160,35 +160,35 @@ public:
 
     // ____ XPropertyState ____
     virtual css::beans::PropertyState SAL_CALL
-        getPropertyState( const OUString& PropertyName ) override;
+        getPropertyState( const OUString& PropertyName ) override final;
     virtual css::uno::Sequence< css::beans::PropertyState > SAL_CALL
-        getPropertyStates( const css::uno::Sequence< OUString >& aPropertyName ) override;
+        getPropertyStates( const css::uno::Sequence< OUString >& aPropertyName ) override final;
     virtual void SAL_CALL
-        setPropertyToDefault( const OUString& PropertyName ) override;
+        setPropertyToDefault( const OUString& PropertyName ) override final;
     virtual css::uno::Any SAL_CALL
-        getPropertyDefault( const OUString& aPropertyName ) override;
+        getPropertyDefault( const OUString& aPropertyName ) override final;
 
     // ____ XMultiPropertyStates ____
     // Note: getPropertyStates() is already implemented in XPropertyState with the
     // same signature
     virtual void SAL_CALL
-        setAllPropertiesToDefault() override;
+        setAllPropertiesToDefault() override final;
     virtual void SAL_CALL
-        setPropertiesToDefault( const css::uno::Sequence< OUString >& aPropertyNames ) override;
+        setPropertiesToDefault( const css::uno::Sequence< OUString >& aPropertyNames ) override final;
     virtual css::uno::Sequence< css::uno::Any > SAL_CALL
-        getPropertyDefaults( const css::uno::Sequence< OUString >& aPropertyNames ) override;
+        getPropertyDefaults( const css::uno::Sequence< OUString >& aPropertyNames ) override final;
 
     // ____ XStyleSupplier ____
-    virtual css::uno::Reference< css::style::XStyle > SAL_CALL getStyle() override;
-    virtual void SAL_CALL setStyle( const css::uno::Reference< css::style::XStyle >& xStyle ) override;
+    virtual css::uno::Reference< css::style::XStyle > SAL_CALL getStyle() override final;
+    virtual void SAL_CALL setStyle( const css::uno::Reference< css::style::XStyle >& xStyle ) override final;
 
     // ____ XMultiPropertySet ____
     virtual void SAL_CALL setPropertyValues(
         const css::uno::Sequence< OUString >& PropertyNames,
-        const css::uno::Sequence< css::uno::Any >& Values ) override;
+        const css::uno::Sequence< css::uno::Any >& Values ) override final;
 
     // ____ XFastPropertySet ____
-    virtual void SAL_CALL setFastPropertyValue( sal_Int32 nHandle, const css::uno::Any& rValue ) override;
+    virtual void SAL_CALL setFastPropertyValue( sal_Int32 nHandle, const css::uno::Any& rValue ) override final;
 
     // Note: it is assumed that the base class implements setPropertyValue by
     // using setFastPropertyValue
diff --git a/chart2/source/model/main/Diagram.cxx b/chart2/source/model/main/Diagram.cxx
index 63bead4ef1b2..db7be686b0c9 100644
--- a/chart2/source/model/main/Diagram.cxx
+++ b/chart2/source/model/main/Diagram.cxx
@@ -729,7 +729,7 @@ uno::Reference< beans::XPropertySetInfo > SAL_CALL Diagram::getPropertySetInfo()
 }
 
 // ____ XFastPropertySet ____
-void SAL_CALL Diagram::setFastPropertyValue( sal_Int32 nHandle, const Any& rValue )
+void SAL_CALL Diagram::setFastPropertyValue_NoBroadcast( sal_Int32 nHandle, const Any& rValue )
 {
     //special treatment for some 3D properties
     if( nHandle == PROP_DIAGRAM_PERSPECTIVE )
@@ -754,7 +754,7 @@ void SAL_CALL Diagram::setFastPropertyValue( sal_Int32 nHandle, const Any& rValu
         }
     }
     else
-        ::property::OPropertySet::setFastPropertyValue( nHandle, rValue );
+        ::property::OPropertySet::setFastPropertyValue_NoBroadcast( nHandle, rValue );
 }
 
 void SAL_CALL Diagram::getFastPropertyValue( Any& rValue, sal_Int32 nHandle ) const