diff options
| author | Xisco Fauli <xiscofauli@libreoffice.org> | 2024-11-27 12:51:19 +0100 |
|---|---|---|
| committer | Xisco Fauli <xiscofauli@libreoffice.org> | 2024-11-27 14:13:39 +0100 |
| commit | b54e905ce6d295104af9a6d2a01b38c02abee6e3 (patch) | |
| tree | 3d093fb3bca999b18497da3fa06fb08f601c9d35 /chart2/source | |
| parent | 9da32329f05a862635861adb19f9b0f331912c5b (diff) | |
PVS: V560 A part of conditional expression is always true
Since
commit 9b538afc2995f7d703a77bb4e6d0e1bc97e3ca20
Author: Vladimir Glazounov <vg@openoffice.org>
Date: Tue May 22 17:46:33 2007 +0000
INTEGRATION: CWS chart2mst3 (1.10.4); FILE MERGED
Change-Id: I1ed040165018d38770f7438a7f64436c7aa4873f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177412
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'chart2/source')
| -rw-r--r-- | chart2/source/model/template/ChartTypeTemplate.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chart2/source/model/template/ChartTypeTemplate.cxx b/chart2/source/model/template/ChartTypeTemplate.cxx index 265a5a97058a..46991f23e37a 100644 --- a/chart2/source/model/template/ChartTypeTemplate.cxx +++ b/chart2/source/model/template/ChartTypeTemplate.cxx @@ -317,13 +317,13 @@ bool ChartTypeTemplate::matchesTemplate2( for( std::size_t nCooSysIdx=0; bResult && (nCooSysIdx < aCooSysSeq.size()); ++nCooSysIdx ) { // match dimension - bResult = bResult && (aCooSysSeq[nCooSysIdx]->getDimension() == nDimensionToMatch); + bResult = aCooSysSeq[nCooSysIdx]->getDimension() == nDimensionToMatch; const std::vector< rtl::Reference< ChartType > > & aChartTypeSeq( aCooSysSeq[nCooSysIdx]->getChartTypes2()); for( std::size_t nCTIdx=0; bResult && (nCTIdx < aChartTypeSeq.size()); ++nCTIdx ) { // match chart type - bResult = bResult && aChartTypeSeq[nCTIdx]->getChartType() == aChartTypeToMatch; + bResult = aChartTypeSeq[nCTIdx]->getChartType() == aChartTypeToMatch; bool bFound=false; bool bAmbiguous=false; // match stacking mode @@ -508,7 +508,7 @@ void ChartTypeTemplate::createCoordinateSystems( { bool bOk = true; for( std::size_t i=0; bOk && i<aCoordinateSystems.size(); ++i ) - bOk = bOk && ( xCooSys->getCoordinateSystemType() == aCoordinateSystems[i]->getCoordinateSystemType() && + bOk = ( xCooSys->getCoordinateSystemType() == aCoordinateSystems[i]->getCoordinateSystemType() && (xCooSys->getDimension() == aCoordinateSystems[i]->getDimension()) ); // coordinate systems are ok if( bOk ) |