summaryrefslogtreecommitdiff
path: root/chart2
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2016-04-12 10:50:29 +0200
committerNoel Grandin <noel@peralex.com>2016-04-12 11:25:18 +0200
commit9cfa0810bd4af4c1ebfcedaa62e82db87b3aea08 (patch)
treec97422fd1f780aaf6b7605e41516b5f442f0ffe4 /chart2
parentc473472fc03dc71f237caeb36395ce155121288a (diff)
clang-tidy performance-unnecessary-value-param in chart2
Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b
Diffstat (limited to 'chart2')
-rw-r--r--chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx6
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.hxx6
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.cxx6
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.hxx4
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedScaleProperty.hxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.cxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.hxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedSplineProperties.cxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedSplineProperties.hxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx12
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.hxx4
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedStockProperties.hxx2
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx6
-rw-r--r--chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.hxx4
-rw-r--r--chart2/source/controller/dialogs/tp_RangeChooser.cxx1
-rw-r--r--chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx6
-rw-r--r--chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx6
-rw-r--r--chart2/source/controller/main/ChartController.cxx4
-rw-r--r--chart2/source/controller/main/DragMethod_RotateDiagram.cxx2
-rw-r--r--chart2/source/controller/sidebar/ChartAreaPanel.cxx18
-rw-r--r--chart2/source/controller/sidebar/ChartAxisPanel.cxx18
-rw-r--r--chart2/source/controller/sidebar/ChartColorWrapper.cxx6
-rw-r--r--chart2/source/controller/sidebar/ChartColorWrapper.hxx2
-rw-r--r--chart2/source/controller/sidebar/ChartElementsPanel.cxx22
-rw-r--r--chart2/source/controller/sidebar/ChartErrorBarPanel.cxx20
-rw-r--r--chart2/source/controller/sidebar/ChartLinePanel.cxx6
-rw-r--r--chart2/source/controller/sidebar/ChartSeriesPanel.cxx28
-rw-r--r--chart2/source/inc/chartview/DataPointSymbolSupplier.hxx2
-rw-r--r--chart2/source/model/main/ChartModel_Persistence.cxx3
-rw-r--r--chart2/source/model/template/ChartTypeTemplate.cxx2
-rw-r--r--chart2/source/model/template/ChartTypeTemplate.hxx4
-rw-r--r--chart2/source/view/charttypes/BarChart.cxx5
-rw-r--r--chart2/source/view/charttypes/VSeriesPlotter.cxx6
-rw-r--r--chart2/source/view/inc/AbstractShapeFactory.hxx2
-rw-r--r--chart2/source/view/main/AbstractShapeFactory.cxx2
-rw-r--r--chart2/source/view/main/ChartView.cxx2
-rw-r--r--chart2/source/view/main/DataPointSymbolSupplier.cxx2
-rw-r--r--chart2/source/view/main/ShapeFactory.cxx2
44 files changed, 121 insertions, 122 deletions
diff --git a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
index 00ccc33db846..deb0abe3db87 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
@@ -1134,7 +1134,7 @@ uno::Reference< drawing::XDrawPage > ChartDocumentWrapper::impl_getDrawPage() co
namespace {
-uno::Reference< lang::XMultiServiceFactory > getShapeFactory(uno::Reference<uno::XInterface> xChartView)
+uno::Reference< lang::XMultiServiceFactory > getShapeFactory(const uno::Reference<uno::XInterface>& xChartView)
{
Reference< lang::XUnoTunnel> xUnoTunnel(xChartView,uno::UNO_QUERY);
if(xUnoTunnel.is())
diff --git a/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx b/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
index 60c7f6556342..21eb43fb013f 100644
--- a/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
@@ -501,7 +501,7 @@ bool lcl_isXYChart( const Reference< chart2::XDiagram >& rDiagram )
sal_Int32 lcl_getNewAPIIndexForOldAPIIndex(
sal_Int32 nOldAPIIndex
- , Reference< chart2::XDiagram > xDiagram )
+ , const Reference< chart2::XDiagram >& xDiagram )
{
sal_Int32 nNewAPIIndex = nOldAPIIndex;
diff --git a/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
index 7bb7f824d8fd..0b1bd662a4e9 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
@@ -56,7 +56,7 @@ private: //member
};
void WrappedAxisAndGridExistenceProperties::addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
rList.push_back( new WrappedAxisAndGridExistenceProperty( true, true, 0, spChart2ModelContact ) );//x axis
rList.push_back( new WrappedAxisAndGridExistenceProperty( true, false, 0, spChart2ModelContact ) );//x secondary axis
@@ -221,7 +221,7 @@ private: //member
};
void WrappedAxisTitleExistenceProperties::addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
rList.push_back( new WrappedAxisTitleExistenceProperty( 0, spChart2ModelContact ) );//x axis title
rList.push_back( new WrappedAxisTitleExistenceProperty( 1, spChart2ModelContact ) );//y axis title
@@ -336,7 +336,7 @@ private: //member
};
void WrappedAxisLabelExistenceProperties::addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
rList.push_back( new WrappedAxisLabelExistenceProperty( true, 0, spChart2ModelContact ) );//x axis
rList.push_back( new WrappedAxisLabelExistenceProperty( true, 1, spChart2ModelContact ) );//y axis
diff --git a/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.hxx b/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.hxx
index 1c04139fbbad..cbdf242e2aa8 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.hxx
@@ -35,21 +35,21 @@ class WrappedAxisAndGridExistenceProperties
{
public:
static void addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
class WrappedAxisTitleExistenceProperties
{
public:
static void addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
class WrappedAxisLabelExistenceProperties
{
public:
static void addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
} //namespace wrapper
diff --git a/chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.cxx
index fdc01a8d5d03..d1dd79ee28e5 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.cxx
@@ -88,7 +88,7 @@ chart2::DataPointLabel lcl_CaptionToLabel( sal_Int32 nCaption )
}
void lcl_addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact
, tSeriesOrDiagramPropertyType ePropertyType )
{
//if !spChart2ModelContact.get() is then the created properties do belong to a single series or single datapoint
@@ -110,13 +110,13 @@ void WrappedDataCaptionProperties::addProperties( std::vector< Property > & rOut
}
void WrappedDataCaptionProperties::addWrappedPropertiesForSeries( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
lcl_addWrappedProperties( rList, spChart2ModelContact, DATA_SERIES );
}
void WrappedDataCaptionProperties::addWrappedPropertiesForDiagram( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
lcl_addWrappedProperties( rList, spChart2ModelContact, DIAGRAM );
}
diff --git a/chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.hxx b/chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.hxx
index ad5222f202f2..acd7741c0f76 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.hxx
@@ -35,9 +35,9 @@ class WrappedDataCaptionProperties
public:
static void addProperties( ::std::vector< css::beans::Property > & rOutProperties );
static void addWrappedPropertiesForSeries( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
static void addWrappedPropertiesForDiagram( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
} //namespace wrapper
diff --git a/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx b/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx
index f941f169d393..54ee48c4324a 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.cxx
@@ -104,7 +104,7 @@ WrappedScaleProperty::~WrappedScaleProperty()
}
void WrappedScaleProperty::addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
rList.push_back( new WrappedScaleProperty( SCALE_PROP_MAX, spChart2ModelContact ) );
rList.push_back( new WrappedScaleProperty( SCALE_PROP_MIN, spChart2ModelContact ) );
diff --git a/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.hxx b/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.hxx
index a6c0d890276c..fdab48a17c41 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedScaleProperty.hxx
@@ -57,7 +57,7 @@ public:
WrappedScaleProperty( tScaleProperty eScaleProperty, std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
virtual ~WrappedScaleProperty();
- static void addWrappedProperties( std::vector< WrappedProperty* >& rList, std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ static void addWrappedProperties( std::vector< WrappedProperty* >& rList, const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
virtual void setPropertyValue( const css::uno::Any& rOuterValue, const css::uno::Reference< css::beans::XPropertySet >& xInnerPropertySet ) const
throw (css::beans::UnknownPropertyException, css::beans::PropertyVetoException, css::lang::IllegalArgumentException, css::lang::WrappedTargetException, css::uno::RuntimeException) override;
diff --git a/chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.cxx
index f46191ec1e14..3ad490c98f48 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.cxx
@@ -136,7 +136,7 @@ void WrappedScaleTextProperties::addProperties( ::std::vector< Property > & rOut
}
void WrappedScaleTextProperties::addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
rList.push_back( new WrappedScaleTextProperty( spChart2ModelContact ) );
}
diff --git a/chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.hxx b/chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.hxx
index a74c0f675724..b3e9ee9cd85e 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.hxx
@@ -36,7 +36,7 @@ class WrappedScaleTextProperties
public:
static void addProperties( ::std::vector< css::beans::Property >& rOutProperties );
static void addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
} //namespace wrapper
diff --git a/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx b/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx
index 6173725fac4b..099139a7e1dc 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.cxx
@@ -33,7 +33,7 @@ namespace wrapper
{
void WrappedSceneProperty::addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
rList.push_back( new WrappedD3DTransformMatrixProperty( spChart2ModelContact ) );
}
diff --git a/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx b/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx
index d1a78ffad3cf..e2c9c9bced23 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSceneProperty.hxx
@@ -34,7 +34,7 @@ class WrappedSceneProperty
{
public:
static void addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
class WrappedD3DTransformMatrixProperty : public WrappedProperty
diff --git a/chart2/source/controller/chartapiwrapper/WrappedSplineProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedSplineProperties.cxx
index 9ca9ce93fba5..f8b1dba6cc2d 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSplineProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSplineProperties.cxx
@@ -206,7 +206,7 @@ void WrappedSplineProperties::addProperties( ::std::vector< Property > & rOutPro
}
void WrappedSplineProperties::addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
rList.push_back( new WrappedSplineTypeProperty( spChart2ModelContact ) );
rList.push_back(
diff --git a/chart2/source/controller/chartapiwrapper/WrappedSplineProperties.hxx b/chart2/source/controller/chartapiwrapper/WrappedSplineProperties.hxx
index 0633ff572bf3..01cd3f034327 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSplineProperties.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSplineProperties.hxx
@@ -35,7 +35,7 @@ class WrappedSplineProperties
public:
static void addProperties( ::std::vector< css::beans::Property > & rOutProperties );
static void addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
} //namespace wrapper
diff --git a/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx
index 085ed9fdb6dc..a73533c87986 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx
@@ -121,7 +121,7 @@ sal_Int32 lcl_getErrorBarStyle( const uno::Reference< beans::XPropertySet >& xEr
}
uno::Reference< chart2::data::XDataProvider > lcl_getDataProviderFromContact(
- ::std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ const ::std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
uno::Reference< chart2::data::XDataProvider > xResult;
if( spChart2ModelContact.get())
@@ -136,7 +136,7 @@ uno::Reference< chart2::data::XDataProvider > lcl_getDataProviderFromContact(
void lcl_ConvertRangeFromXML(
OUString & rInOutRange,
- ::std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ const ::std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
if( !rInOutRange.isEmpty())
{
@@ -152,7 +152,7 @@ void lcl_ConvertRangeFromXML(
void lcl_ConvertRangeToXML(
OUString & rInOutRange,
- ::std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ const ::std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
if( !rInOutRange.isEmpty())
{
@@ -965,7 +965,7 @@ enum
series
*/
void lcl_addWrappedProperties( std::vector< WrappedProperty* >& rList
- , ::std::shared_ptr< Chart2ModelContact > spChart2ModelContact
+ , const ::std::shared_ptr< Chart2ModelContact >& spChart2ModelContact
, tSeriesOrDiagramPropertyType ePropertyType )
{
rList.push_back( new WrappedConstantErrorLowProperty( spChart2ModelContact, ePropertyType ) );
@@ -1082,13 +1082,13 @@ void WrappedStatisticProperties::addProperties( ::std::vector< Property > & rOut
}
void WrappedStatisticProperties::addWrappedPropertiesForSeries( std::vector< WrappedProperty* >& rList
- , ::std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const ::std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
lcl_addWrappedProperties( rList, spChart2ModelContact, DATA_SERIES );
}
void WrappedStatisticProperties::addWrappedPropertiesForDiagram( std::vector< WrappedProperty* >& rList
- , ::std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const ::std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
lcl_addWrappedProperties( rList, spChart2ModelContact, DIAGRAM );
}
diff --git a/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.hxx b/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.hxx
index 390677936cdd..2baba22cbbbb 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.hxx
@@ -35,9 +35,9 @@ class WrappedStatisticProperties
public:
static void addProperties( ::std::vector< css::beans::Property > & rOutProperties );
static void addWrappedPropertiesForSeries( std::vector< WrappedProperty* >& rList
- , ::std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const ::std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
static void addWrappedPropertiesForDiagram( std::vector< WrappedProperty* >& rList
- , ::std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const ::std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
} //namespace wrapper
diff --git a/chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx
index f0e94d8b84c5..124c862b364b 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx
@@ -278,7 +278,7 @@ void WrappedStockProperties::addProperties( ::std::vector< Property > & rOutProp
}
void WrappedStockProperties::addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
rList.push_back( new WrappedVolumeProperty( spChart2ModelContact ) );
rList.push_back( new WrappedUpDownProperty( spChart2ModelContact ) );
diff --git a/chart2/source/controller/chartapiwrapper/WrappedStockProperties.hxx b/chart2/source/controller/chartapiwrapper/WrappedStockProperties.hxx
index 9a92d0fc9609..faa1ba5211e0 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedStockProperties.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedStockProperties.hxx
@@ -35,7 +35,7 @@ class WrappedStockProperties
public:
static void addProperties( ::std::vector< css::beans::Property > & rOutProperties );
static void addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
} //namespace wrapper
diff --git a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
index a7bf6af8b262..40f68cebc86e 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
@@ -159,7 +159,7 @@ void lcl_setSymbolTypeToSymbol( sal_Int32 nSymbolType, chart2::Symbol& rSymbol )
}
void lcl_addWrappedProperties( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact
, tSeriesOrDiagramPropertyType ePropertyType )
{
rList.push_back( new WrappedSymbolTypeProperty( spChart2ModelContact, ePropertyType ) );
@@ -202,13 +202,13 @@ void WrappedSymbolProperties::addProperties( ::std::vector< Property > & rOutPro
}
void WrappedSymbolProperties::addWrappedPropertiesForSeries( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
lcl_addWrappedProperties( rList, spChart2ModelContact, DATA_SERIES );
}
void WrappedSymbolProperties::addWrappedPropertiesForDiagram( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact )
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact )
{
lcl_addWrappedProperties( rList, spChart2ModelContact, DIAGRAM );
}
diff --git a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.hxx b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.hxx
index f065e3167282..44356dd348ad 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.hxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.hxx
@@ -35,9 +35,9 @@ class WrappedSymbolProperties
public:
static void addProperties( ::std::vector< css::beans::Property > & rOutProperties );
static void addWrappedPropertiesForSeries( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
static void addWrappedPropertiesForDiagram( std::vector< WrappedProperty* >& rList
- , std::shared_ptr< Chart2ModelContact > spChart2ModelContact );
+ , const std::shared_ptr< Chart2ModelContact >& spChart2ModelContact );
};
} //namespace wrapper
diff --git a/chart2/source/controller/dialogs/tp_RangeChooser.cxx b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
index 5b7ba832f151..dbfdc3873575 100644
--- a/chart2/source/controller/dialogs/tp_RangeChooser.cxx
+++ b/chart2/source/controller/dialogs/tp_RangeChooser.cxx
@@ -386,6 +386,7 @@ void RangeChooserTabPage::listeningFinished( const OUString & rNewRange )
{
//user has selected a new range
+ // rNewRange becomes invalid after removing the listener
OUString aRange( rNewRange );
m_rDialogModel.startControllerLockTimer();
diff --git a/chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx b/chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx
index abd303cc5b6e..ac667072a62a 100644
--- a/chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/RegressionCurveItemConverter.cxx
@@ -41,7 +41,7 @@ using namespace ::com::sun::star;
namespace
{
template <class T, class D>
-bool lclConvertToPropertySet(const SfxItemSet& rItemSet, sal_uInt16 nWhichId, uno::Reference<beans::XPropertySet> xProperties, const OUString& aPropertyID)
+bool lclConvertToPropertySet(const SfxItemSet& rItemSet, sal_uInt16 nWhichId, const uno::Reference<beans::XPropertySet>& xProperties, const OUString& aPropertyID)
{
OSL_ASSERT(xProperties.is());
if( xProperties.is() )
@@ -59,7 +59,7 @@ bool lclConvertToPropertySet(const SfxItemSet& rItemSet, sal_uInt16 nWhichId, un
}
template <class T, class D>
-void lclConvertToItemSet(SfxItemSet& rItemSet, sal_uInt16 nWhichId, uno::Reference<beans::XPropertySet> xProperties, const OUString& aPropertyID)
+void lclConvertToItemSet(SfxItemSet& rItemSet, sal_uInt16 nWhichId, const uno::Reference<beans::XPropertySet>& xProperties, const OUString& aPropertyID)
{
OSL_ASSERT(xProperties.is());
if( xProperties.is() )
@@ -72,7 +72,7 @@ void lclConvertToItemSet(SfxItemSet& rItemSet, sal_uInt16 nWhichId, uno::Referen
}
}
-void lclConvertToItemSetDouble(SfxItemSet& rItemSet, sal_uInt16 nWhichId, uno::Reference<beans::XPropertySet> xProperties, const OUString& aPropertyID)
+void lclConvertToItemSetDouble(SfxItemSet& rItemSet, sal_uInt16 nWhichId, const uno::Reference<beans::XPropertySet>& xProperties, const OUString& aPropertyID)
{
OSL_ASSERT(xProperties.is());
if( xProperties.is() )
diff --git a/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx b/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
index 5f749ea4bf8a..54864931e503 100644
--- a/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
@@ -174,7 +174,7 @@ uno::Reference< beans::XPropertySet > lcl_getCurveProperties(
}
template <class T, class D>
-bool lclConvertToPropertySet(const SfxItemSet& rItemSet, sal_uInt16 nWhichId, uno::Reference<beans::XPropertySet> xProperties, const OUString& aPropertyID)
+bool lclConvertToPropertySet(const SfxItemSet& rItemSet, sal_uInt16 nWhichId, const uno::Reference<beans::XPropertySet>& xProperties, const OUString& aPropertyID)
{
OSL_ASSERT(xProperties.is());
if( xProperties.is() )
@@ -192,7 +192,7 @@ bool lclConvertToPropertySet(const SfxItemSet& rItemSet, sal_uInt16 nWhichId, un
}
template <class T, class D>
-void lclConvertToItemSet(SfxItemSet& rItemSet, sal_uInt16 nWhichId, uno::Reference<beans::XPropertySet> xProperties, const OUString& aPropertyID)
+void lclConvertToItemSet(SfxItemSet& rItemSet, sal_uInt16 nWhichId, const uno::Reference<beans::XPropertySet>& xProperties, const OUString& aPropertyID)
{
OSL_ASSERT(xProperties.is());
if( xProperties.is() )
@@ -205,7 +205,7 @@ void lclConvertToItemSet(SfxItemSet& rItemSet, sal_uInt16 nWhichId, uno::Referen
}
}
-void lclConvertToItemSetDouble(SfxItemSet& rItemSet, sal_uInt16 nWhichId, uno::Reference<beans::XPropertySet> xProperties, const OUString& aPropertyID)
+void lclConvertToItemSetDouble(SfxItemSet& rItemSet, sal_uInt16 nWhichId, const uno::Reference<beans::XPropertySet>& xProperties, const OUString& aPropertyID)
{
OSL_ASSERT(xProperties.is());
if( xProperties.is() )
diff --git a/chart2/source/controller/main/ChartController.cxx b/chart2/source/controller/main/ChartController.cxx
index 9df3c28d8789..000756966574 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -282,7 +282,7 @@ bool ChartController::TheModelRef::is() const
namespace {
css::uno::Reference<css::chart2::XChartType> getChartType(
- css::uno::Reference<css::chart2::XChartDocument> xChartDoc)
+ const css::uno::Reference<css::chart2::XChartDocument>& xChartDoc)
{
Reference <chart2::XDiagram > xDiagram = xChartDoc->getFirstDiagram();
@@ -394,7 +394,7 @@ uno::Sequence< OUString > ChartController::getSupportedServiceNames_Static()
namespace {
-uno::Reference<ui::XSidebar> getSidebarFromModel(uno::Reference<frame::XModel> xModel)
+uno::Reference<ui::XSidebar> getSidebarFromModel(const uno::Reference<frame::XModel>& xModel)
{
uno::Reference<container::XChild> xChild(xModel, uno::UNO_QUERY);
if (!xChild.is())
diff --git a/chart2/source/controller/main/DragMethod_RotateDiagram.cxx b/chart2/source/controller/main/DragMethod_RotateDiagram.cxx
index d07ecfdae0f0..1398ebeb10b8 100644
--- a/chart2/source/controller/main/DragMethod_RotateDiagram.cxx
+++ b/chart2/source/controller/main/DragMethod_RotateDiagram.cxx
@@ -202,7 +202,7 @@ void DragMethod_RotateDiagram::CreateOverlayGeometry(sdr::overlay::OverlayManage
if(m_aWireframePolyPolygon.count() && m_pScene)
{
const sdr::contact::ViewContactOfE3dScene& rVCScene = static_cast< sdr::contact::ViewContactOfE3dScene& >(m_pScene->GetViewContact());
- const drawinglayer::geometry::ViewInformation3D aViewInfo3D(rVCScene.getViewInformation3D());
+ const drawinglayer::geometry::ViewInformation3D& aViewInfo3D(rVCScene.getViewInformation3D());
const basegfx::B3DHomMatrix aWorldToView(aViewInfo3D.getDeviceToView() * aViewInfo3D.getProjection() * aViewInfo3D.getOrientation());
const basegfx::B3DHomMatrix aTransform(aWorldToView * aCurrentTransform);
diff --git a/chart2/source/controller/sidebar/ChartAreaPanel.cxx b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
index 09d0b2c433c1..389120bdc70f 100644
--- a/chart2/source/controller/sidebar/ChartAreaPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
@@ -33,7 +33,7 @@ SvxColorToolBoxControl* getColorToolBoxControl(sfx2::sidebar::SidebarToolBox* pT
return pToolBoxColorControl;
}
-OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
+OUString getCID(const css::uno::Reference<css::frame::XModel>& xModel)
{
css::uno::Reference<css::frame::XController> xController(xModel->getCurrentController());
css::uno::Reference<css::view::XSelectionSupplier> xSelectionSupplier(xController, css::uno::UNO_QUERY);
@@ -51,7 +51,7 @@ OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
}
css::uno::Reference<css::beans::XPropertySet> getPropSet(
- css::uno::Reference<css::frame::XModel> xModel)
+ const css::uno::Reference<css::frame::XModel>& xModel)
{
OUString aCID = getCID(xModel);
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -71,7 +71,7 @@ css::uno::Reference<css::beans::XPropertySet> getPropSet(
return xPropSet;
}
-ChartController* getController(css::uno::Reference<css::frame::XModel> xModel)
+ChartController* getController(const css::uno::Reference<css::frame::XModel>& xModel)
{
css::uno::Reference<css::frame::XController>xController = xModel->getCurrentController();
if (!xController.is())
@@ -84,20 +84,20 @@ ChartController* getController(css::uno::Reference<css::frame::XModel> xModel)
return pController;
}
-ViewElementListProvider getViewElementListProvider( css::uno::Reference<css::frame::XModel> xModel)
+ViewElementListProvider getViewElementListProvider( const css::uno::Reference<css::frame::XModel>& xModel)
{
ChartController* pController = getController(xModel);
ViewElementListProvider aProvider = pController->getViewElementListProvider();
return aProvider;
}
-DrawModelWrapper* getDrawModelWrapper(css::uno::Reference<css::frame::XModel> xModel)
+DrawModelWrapper* getDrawModelWrapper(const css::uno::Reference<css::frame::XModel>& xModel)
{
ChartController* pController = getController(xModel);
return pController->GetDrawModelWrapper();
}
-XGradient getXGradientForName(css::uno::Reference<css::frame::XModel> xModel,
+XGradient getXGradientForName(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rName)
{
try
@@ -123,7 +123,7 @@ XGradient getXGradientForName(css::uno::Reference<css::frame::XModel> xModel,
return XGradient();
}
-XFillFloatTransparenceItem getXTransparencyGradientForName(css::uno::Reference<css::frame::XModel> xModel,
+XFillFloatTransparenceItem getXTransparencyGradientForName(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rName)
{
css::uno::Reference<css::lang::XMultiServiceFactory> xFact(xModel, css::uno::UNO_QUERY);
@@ -145,7 +145,7 @@ XFillFloatTransparenceItem getXTransparencyGradientForName(css::uno::Reference<c
return aItem;
}
-XHatch getXHatchFromName(css::uno::Reference<css::frame::XModel> xModel,
+XHatch getXHatchFromName(const css::uno::Reference<css::frame::XModel>& xModel,
OUString& rName)
{
try
@@ -175,7 +175,7 @@ XHatch getXHatchFromName(css::uno::Reference<css::frame::XModel> xModel,
return XHatch();
}
-GraphicObject getXBitmapFromName(css::uno::Reference<css::frame::XModel> xModel,
+GraphicObject getXBitmapFromName(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rName)
{
try
diff --git a/chart2/source/controller/sidebar/ChartAxisPanel.cxx b/chart2/source/controller/sidebar/ChartAxisPanel.cxx
index 4bcdcb941de2..0adf17331233 100644
--- a/chart2/source/controller/sidebar/ChartAxisPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartAxisPanel.cxx
@@ -44,7 +44,7 @@ namespace chart { namespace sidebar {
namespace {
-bool isLabelShown(css::uno::Reference<css::frame::XModel> xModel,
+bool isLabelShown(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID)
{
css::uno::Reference< css::beans::XPropertySet > xAxis(
@@ -62,7 +62,7 @@ bool isLabelShown(css::uno::Reference<css::frame::XModel> xModel,
return bVisible;
}
-void setLabelShown(css::uno::Reference<css::frame::XModel> xModel,
+void setLabelShown(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, bool bVisible)
{
css::uno::Reference< css::beans::XPropertySet > xAxis(
@@ -87,7 +87,7 @@ AxisLabelPosMap aLabelPosMap[] = {
{ 3, css::chart::ChartAxisLabelPosition_OUTSIDE_END }
};
-sal_Int32 getLabelPosition(css::uno::Reference<css::frame::XModel> xModel,
+sal_Int32 getLabelPosition(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID)
{
css::uno::Reference< css::beans::XPropertySet > xAxis(
@@ -111,7 +111,7 @@ sal_Int32 getLabelPosition(css::uno::Reference<css::frame::XModel> xModel,
return 0;
}
-void setLabelPosition(css::uno::Reference<css::frame::XModel> xModel,
+void setLabelPosition(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, sal_Int32 nPos)
{
css::uno::Reference< css::beans::XPropertySet > xAxis(
@@ -130,7 +130,7 @@ void setLabelPosition(css::uno::Reference<css::frame::XModel> xModel,
xAxis->setPropertyValue("LabelPosition", css::uno::makeAny(ePos));
}
-bool isReverse(css::uno::Reference<css::frame::XModel> xModel,
+bool isReverse(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID)
{
css::uno::Reference< css::chart2::XAxis > xAxis(
@@ -144,7 +144,7 @@ bool isReverse(css::uno::Reference<css::frame::XModel> xModel,
return aData.Orientation == css::chart2::AxisOrientation_REVERSE;
}
-void setReverse(css::uno::Reference<css::frame::XModel> xModel,
+void setReverse(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, bool bReverse)
{
css::uno::Reference< css::chart2::XAxis > xAxis(
@@ -162,7 +162,7 @@ void setReverse(css::uno::Reference<css::frame::XModel> xModel,
xAxis->setScaleData(aData);
}
-OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
+OUString getCID(const css::uno::Reference<css::frame::XModel>& xModel)
{
css::uno::Reference<css::frame::XController> xController(xModel->getCurrentController());
css::uno::Reference<css::view::XSelectionSupplier> xSelectionSupplier(xController, css::uno::UNO_QUERY);
@@ -181,7 +181,7 @@ OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
return aCID;
}
-void setAxisRotation(css::uno::Reference<css::frame::XModel> xModel,
+void setAxisRotation(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, double nVal)
{
css::uno::Reference< css::beans::XPropertySet > xAxis(
@@ -193,7 +193,7 @@ void setAxisRotation(css::uno::Reference<css::frame::XModel> xModel,
xAxis->setPropertyValue("TextRotation", css::uno::makeAny(nVal));
}
-double getAxisRotation(css::uno::Reference<css::frame::XModel> xModel,
+double getAxisRotation(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID)
{
css::uno::Reference< css::beans::XPropertySet > xAxis(
diff --git a/chart2/source/controller/sidebar/ChartColorWrapper.cxx b/chart2/source/controller/sidebar/ChartColorWrapper.cxx
index bd5fd67f0def..6172939bf849 100644
--- a/chart2/source/controller/sidebar/ChartColorWrapper.cxx
+++ b/chart2/source/controller/sidebar/ChartColorWrapper.cxx
@@ -19,7 +19,7 @@ namespace chart { namespace sidebar {
namespace {
-OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
+OUString getCID(const css::uno::Reference<css::frame::XModel>& xModel)
{
css::uno::Reference<css::frame::XController> xController(xModel->getCurrentController());
css::uno::Reference<css::view::XSelectionSupplier> xSelectionSupplier(xController, css::uno::UNO_QUERY);
@@ -37,7 +37,7 @@ OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
}
css::uno::Reference<css::beans::XPropertySet> getPropSet(
- css::uno::Reference<css::frame::XModel> xModel)
+ const css::uno::Reference<css::frame::XModel>& xModel)
{
OUString aCID = getCID(xModel);
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -77,7 +77,7 @@ void ChartColorWrapper::operator()(const OUString& , const Color& rColor)
xPropSet->setPropertyValue(maPropertyName, css::uno::makeAny(rColor.GetColor()));
}
-void ChartColorWrapper::updateModel(css::uno::Reference<css::frame::XModel> xModel)
+void ChartColorWrapper::updateModel(const css::uno::Reference<css::frame::XModel>& xModel)
{
mxModel = xModel;
}
diff --git a/chart2/source/controller/sidebar/ChartColorWrapper.hxx b/chart2/source/controller/sidebar/ChartColorWrapper.hxx
index 045f94783cec..4fcfb7d96a0a 100644
--- a/chart2/source/controller/sidebar/ChartColorWrapper.hxx
+++ b/chart2/source/controller/sidebar/ChartColorWrapper.hxx
@@ -28,7 +28,7 @@ public:
void operator()(const OUString& rCommand, const Color& rColor);
- void updateModel(css::uno::Reference<css::frame::XModel> xModel);
+ void updateModel(const css::uno::Reference<css::frame::XModel>& xModel);
void updateData();
diff --git a/chart2/source/controller/sidebar/ChartElementsPanel.cxx b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
index 3c914ce4cee7..3287fc0b094f 100644
--- a/chart2/source/controller/sidebar/ChartElementsPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
@@ -72,14 +72,14 @@ enum class AxisType
Y_SECOND
};
-ChartModel* getChartModel(css::uno::Reference<css::frame::XModel> xModel)
+ChartModel* getChartModel(const css::uno::Reference<css::frame::XModel>& xModel)
{
ChartModel* pModel = dynamic_cast<ChartModel*>(xModel.get());
return pModel;
}
-bool isLegendVisible(css::uno::Reference<css::frame::XModel> xModel)
+bool isLegendVisible(const css::uno::Reference<css::frame::XModel>& xModel)
{
ChartModel* pModel = getChartModel(xModel);
if (!pModel)
@@ -104,7 +104,7 @@ bool isLegendVisible(css::uno::Reference<css::frame::XModel> xModel)
return false;
}
-void setLegendVisible(css::uno::Reference<css::frame::XModel> xModel, bool bVisible)
+void setLegendVisible(const css::uno::Reference<css::frame::XModel>& xModel, bool bVisible)
{
ChartModel* pModel = getChartModel(xModel);
if (!pModel)
@@ -116,12 +116,12 @@ void setLegendVisible(css::uno::Reference<css::frame::XModel> xModel, bool bVisi
LegendHelper::hideLegend(*pModel);
}
-bool isTitleVisisble(css::uno::Reference<css::frame::XModel> xModel, TitleHelper::eTitleType eTitle)
+bool isTitleVisisble(const css::uno::Reference<css::frame::XModel>& xModel, TitleHelper::eTitleType eTitle)
{
return TitleHelper::getTitle(eTitle, xModel).is();
}
-bool isGridVisible(css::uno::Reference<css::frame::XModel> xModel, GridType eType)
+bool isGridVisible(const css::uno::Reference<css::frame::XModel>& xModel, GridType eType)
{
Reference< chart2::XDiagram > xDiagram(ChartModelHelper::findDiagram(xModel));
if(xDiagram.is())
@@ -139,7 +139,7 @@ bool isGridVisible(css::uno::Reference<css::frame::XModel> xModel, GridType eTyp
return false;
}
-void setGridVisible(css::uno::Reference<css::frame::XModel> xModel, GridType eType, bool bVisible)
+void setGridVisible(const css::uno::Reference<css::frame::XModel>& xModel, GridType eType, bool bVisible)
{
Reference< chart2::XDiagram > xDiagram(ChartModelHelper::findDiagram(xModel));
if(xDiagram.is())
@@ -159,7 +159,7 @@ void setGridVisible(css::uno::Reference<css::frame::XModel> xModel, GridType eTy
}
}
-bool isAxisVisible(css::uno::Reference<css::frame::XModel> xModel, AxisType eType)
+bool isAxisVisible(const css::uno::Reference<css::frame::XModel>& xModel, AxisType eType)
{
Reference< chart2::XDiagram > xDiagram(ChartModelHelper::findDiagram(xModel));
if(xDiagram.is())
@@ -178,7 +178,7 @@ bool isAxisVisible(css::uno::Reference<css::frame::XModel> xModel, AxisType eTyp
return false;
}
-void setAxisVisible(css::uno::Reference<css::frame::XModel> xModel, AxisType eType, bool bVisible)
+void setAxisVisible(const css::uno::Reference<css::frame::XModel>& xModel, AxisType eType, bool bVisible)
{
Reference< chart2::XDiagram > xDiagram(ChartModelHelper::findDiagram(xModel));
if(xDiagram.is())
@@ -198,7 +198,7 @@ void setAxisVisible(css::uno::Reference<css::frame::XModel> xModel, AxisType eTy
}
}
-sal_Int32 getLegendPos(css::uno::Reference<css::frame::XModel> xModel)
+sal_Int32 getLegendPos(const css::uno::Reference<css::frame::XModel>& xModel)
{
ChartModel* pModel = getChartModel(xModel);
if (!pModel)
@@ -225,7 +225,7 @@ sal_Int32 getLegendPos(css::uno::Reference<css::frame::XModel> xModel)
}
}
-void setLegendPos(css::uno::Reference<css::frame::XModel> xModel, sal_Int32 nPos)
+void setLegendPos(const css::uno::Reference<css::frame::XModel>& xModel, sal_Int32 nPos)
{
ChartModel* pModel = getChartModel(xModel);
if (!pModel)
@@ -383,7 +383,7 @@ void ChartElementsPanel::Initialize()
namespace {
-css::uno::Reference<css::chart2::XChartType> getChartType(css::uno::Reference<css::frame::XModel> xModel)
+css::uno::Reference<css::chart2::XChartType> getChartType(const css::uno::Reference<css::frame::XModel>& xModel)
{
css::uno::Reference<css::chart2::XChartDocument> xChartDoc(xModel, css::uno::UNO_QUERY_THROW);
css::uno::Reference<chart2::XDiagram > xDiagram = xChartDoc->getFirstDiagram();
diff --git a/chart2/source/controller/sidebar/ChartErrorBarPanel.cxx b/chart2/source/controller/sidebar/ChartErrorBarPanel.cxx
index 03ed6f969546..e0f69a0b06ea 100644
--- a/chart2/source/controller/sidebar/ChartErrorBarPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartErrorBarPanel.cxx
@@ -52,12 +52,12 @@ enum class ErrorBarDirection
};
css::uno::Reference<css::beans::XPropertySet> getErrorBarPropSet(
- css::uno::Reference<css::frame::XModel> xModel, const OUString& rCID)
+ const css::uno::Reference<css::frame::XModel>& xModel, const OUString& rCID)
{
return ObjectIdentifier::getObjectPropertySet(rCID, xModel);
}
-bool showPositiveError(css::uno::Reference<css::frame::XModel> xModel,
+bool showPositiveError(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID)
{
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -76,7 +76,7 @@ bool showPositiveError(css::uno::Reference<css::frame::XModel> xModel,
return bShow;
}
-bool showNegativeError(css::uno::Reference<css::frame::XModel> xModel,
+bool showNegativeError(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID)
{
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -95,7 +95,7 @@ bool showNegativeError(css::uno::Reference<css::frame::XModel> xModel,
return bShow;
}
-void setShowPositiveError(css::uno::Reference<css::frame::XModel> xModel,
+void setShowPositiveError(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, bool bShow)
{
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -107,7 +107,7 @@ void setShowPositiveError(css::uno::Reference<css::frame::XModel> xModel,
xPropSet->setPropertyValue("ShowPositiveError", css::uno::makeAny(bShow));
}
-void setShowNegativeError(css::uno::Reference<css::frame::XModel> xModel,
+void setShowNegativeError(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, bool bShow)
{
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -135,7 +135,7 @@ ErrorBarTypeMap aErrorBarType[] = {
{ 6, css::chart::ErrorBarStyle::ERROR_MARGIN },
};
-sal_Int32 getTypePos(css::uno::Reference<css::frame::XModel> xModel,
+sal_Int32 getTypePos(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID)
{
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -161,7 +161,7 @@ sal_Int32 getTypePos(css::uno::Reference<css::frame::XModel> xModel,
return 0;
}
-void setTypePos(css::uno::Reference<css::frame::XModel> xModel,
+void setTypePos(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, sal_Int32 nPos)
{
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -180,7 +180,7 @@ void setTypePos(css::uno::Reference<css::frame::XModel> xModel,
xPropSet->setPropertyValue("ErrorBarStyle", css::uno::makeAny(nApi));
}
-double getValue(css::uno::Reference<css::frame::XModel> xModel,
+double getValue(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, ErrorBarDirection eDir)
{
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -204,7 +204,7 @@ double getValue(css::uno::Reference<css::frame::XModel> xModel,
return nVal;
}
-void setValue(css::uno::Reference<css::frame::XModel> xModel,
+void setValue(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, double nVal, ErrorBarDirection eDir)
{
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -220,7 +220,7 @@ void setValue(css::uno::Reference<css::frame::XModel> xModel,
xPropSet->setPropertyValue(aName, css::uno::makeAny(nVal));
}
-OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
+OUString getCID(const css::uno::Reference<css::frame::XModel>& xModel)
{
css::uno::Reference<css::frame::XController> xController(xModel->getCurrentController());
css::uno::Reference<css::view::XSelectionSupplier> xSelectionSupplier(xController, css::uno::UNO_QUERY);
diff --git a/chart2/source/controller/sidebar/ChartLinePanel.cxx b/chart2/source/controller/sidebar/ChartLinePanel.cxx
index 70c817e8f753..6ed486211526 100644
--- a/chart2/source/controller/sidebar/ChartLinePanel.cxx
+++ b/chart2/source/controller/sidebar/ChartLinePanel.cxx
@@ -35,7 +35,7 @@ SvxColorToolBoxControl* getColorToolBoxControl(sfx2::sidebar::SidebarToolBox* pT
return pToolBoxColorControl;
}
-OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
+OUString getCID(const css::uno::Reference<css::frame::XModel>& xModel)
{
css::uno::Reference<css::frame::XController> xController(xModel->getCurrentController());
css::uno::Reference<css::view::XSelectionSupplier> xSelectionSupplier(xController, css::uno::UNO_QUERY);
@@ -53,7 +53,7 @@ OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
}
css::uno::Reference<css::beans::XPropertySet> getPropSet(
- css::uno::Reference<css::frame::XModel> xModel)
+ const css::uno::Reference<css::frame::XModel>& xModel)
{
OUString aCID = getCID(xModel);
css::uno::Reference<css::beans::XPropertySet> xPropSet =
@@ -74,7 +74,7 @@ css::uno::Reference<css::beans::XPropertySet> getPropSet(
}
css::uno::Any getLineDash(
- css::uno::Reference<css::frame::XModel> xModel, const OUString& rDashName)
+ const css::uno::Reference<css::frame::XModel>& xModel, const OUString& rDashName)
{
css::uno::Reference<css::lang::XMultiServiceFactory> xFact(xModel, css::uno::UNO_QUERY);
css::uno::Reference<css::container::XNameAccess> xNameAccess(
diff --git a/chart2/source/controller/sidebar/ChartSeriesPanel.cxx b/chart2/source/controller/sidebar/ChartSeriesPanel.cxx
index e82f71672f22..512a2d3bd198 100644
--- a/chart2/source/controller/sidebar/ChartSeriesPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartSeriesPanel.cxx
@@ -56,7 +56,7 @@ namespace chart { namespace sidebar {
namespace {
-bool isDataLabelVisible(css::uno::Reference<css::frame::XModel> xModel, const OUString& rCID)
+bool isDataLabelVisible(const css::uno::Reference<css::frame::XModel>& xModel, const OUString& rCID)
{
css::uno::Reference< css::chart2::XDataSeries > xSeries(
ObjectIdentifier::getDataSeriesForCID(rCID, xModel), uno::UNO_QUERY );
@@ -67,7 +67,7 @@ bool isDataLabelVisible(css::uno::Reference<css::frame::XModel> xModel, const OU
return DataSeriesHelper::hasDataLabelsAtSeries(xSeries);
}
-void setDataLabelVisible(css::uno::Reference<css::frame::XModel> xModel, const OUString& rCID, bool bVisible)
+void setDataLabelVisible(const css::uno::Reference<css::frame::XModel>& xModel, const OUString& rCID, bool bVisible)
{
css::uno::Reference< css::chart2::XDataSeries > xSeries(
ObjectIdentifier::getDataSeriesForCID(rCID, xModel), uno::UNO_QUERY );
@@ -96,7 +96,7 @@ LabelPlacementMap aLabelPlacementMap[] = {
{ 5, css::chart::DataLabelPlacement::NEAR_ORIGIN }
};
-sal_Int32 getDataLabelPlacement(css::uno::Reference<css::frame::XModel> xModel,
+sal_Int32 getDataLabelPlacement(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID)
{
css::uno::Reference< css::beans::XPropertySet > xSeries(
@@ -121,7 +121,7 @@ sal_Int32 getDataLabelPlacement(css::uno::Reference<css::frame::XModel> xModel,
return 0;
}
-void setDataLabelPlacement(css::uno::Reference<css::frame::XModel> xModel,
+void setDataLabelPlacement(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID, sal_Int32 nPos)
{
css::uno::Reference< css::beans::XPropertySet > xSeries(
@@ -143,7 +143,7 @@ void setDataLabelPlacement(css::uno::Reference<css::frame::XModel> xModel,
xSeries->setPropertyValue("LabelPlacement", css::uno::makeAny(nApi));
}
-bool isTrendlineVisible(css::uno::Reference<css::frame::XModel> xModel,
+bool isTrendlineVisible(const css::uno::Reference<css::frame::XModel>& xModel,
const OUString& rCID)
{
css::uno::Reference< css::chart2::XRegressionCurveContainer > xRegressionCurveContainer(
@@ -155,7 +155,7 @@ bool isTrendlineVisible(css::uno::Reference<css::frame::XModel> xModel,
return xRegressionCurveContainer->getRegressionCurves().getLength() != 0;
}
-void setTrendlineVisible(css::uno::Reference<css::frame::XModel>
+void setTrendlineVisible(const css::uno::Reference<css::frame::XModel>&
xModel, const OUString& rCID, bool bVisible)
{
css::uno::Reference< css::chart2::XRegressionCurveContainer > xRegressionCurveContainer(
@@ -179,8 +179,8 @@ void setTrendlineVisible(css::uno::Reference<css::frame::XModel>
}
-bool isErrorBarVisible(css::uno::Reference<css::frame::XModel>
- xModel, const OUString& rCID, bool bYError)
+bool isErrorBarVisible(const css::uno::Reference<css::frame::XModel>& xModel,
+ const OUString& rCID, bool bYError)
{
css::uno::Reference< css::chart2::XDataSeries > xSeries(
ObjectIdentifier::getDataSeriesForCID(rCID, xModel), uno::UNO_QUERY );
@@ -191,7 +191,7 @@ bool isErrorBarVisible(css::uno::Reference<css::frame::XModel>
return StatisticsHelper::hasErrorBars(xSeries, bYError);
}
-void setErrorBarVisible(css::uno::Reference<css::frame::XModel>
+void setErrorBarVisible(const css::uno::Reference<css::frame::XModel>&
xModel, const OUString& rCID, bool bYError, bool bVisible)
{
css::uno::Reference< css::chart2::XDataSeries > xSeries(
@@ -212,7 +212,7 @@ void setErrorBarVisible(css::uno::Reference<css::frame::XModel>
}
}
-bool isPrimaryAxis(css::uno::Reference<css::frame::XModel>
+bool isPrimaryAxis(const css::uno::Reference<css::frame::XModel>&
xModel, const OUString& rCID)
{
css::uno::Reference< css::chart2::XDataSeries > xSeries(
@@ -224,7 +224,7 @@ bool isPrimaryAxis(css::uno::Reference<css::frame::XModel>
return DataSeriesHelper::getAttachedAxisIndex(xSeries) == 0;
}
-void setAttachedAxisType(css::uno::Reference<css::frame::XModel>
+void setAttachedAxisType(const css::uno::Reference<css::frame::XModel>&
xModel, const OUString& rCID, bool bPrimary)
{
css::uno::Reference< css::beans::XPropertySet > xSeries(
@@ -238,7 +238,7 @@ void setAttachedAxisType(css::uno::Reference<css::frame::XModel>
}
css::uno::Reference<css::chart2::XChartType> getChartType(
- css::uno::Reference<css::frame::XModel> xModel)
+ const css::uno::Reference<css::frame::XModel>& xModel)
{
css::uno::Reference<css::chart2::XChartDocument> xChartDoc (xModel, css::uno::UNO_QUERY);
css::uno::Reference<css::chart2::XDiagram> xDiagram = xChartDoc->getFirstDiagram();
@@ -249,7 +249,7 @@ css::uno::Reference<css::chart2::XChartType> getChartType(
return xChartTypeSequence[0];
}
-OUString getSeriesLabel(css::uno::Reference<css::frame::XModel> xModel, const OUString& rCID)
+OUString getSeriesLabel(const css::uno::Reference<css::frame::XModel>& xModel, const OUString& rCID)
{
css::uno::Reference< css::chart2::XDataSeries > xSeries(
ObjectIdentifier::getDataSeriesForCID(rCID, xModel), uno::UNO_QUERY );
@@ -261,7 +261,7 @@ OUString getSeriesLabel(css::uno::Reference<css::frame::XModel> xModel, const OU
return DataSeriesHelper::getDataSeriesLabel(xSeries, xChartType->getRoleOfSequenceForSeriesLabel());
}
-OUString getCID(css::uno::Reference<css::frame::XModel> xModel)
+OUString getCID(const css::uno::Reference<css::frame::XModel>& xModel)
{
css::uno::Reference<css::frame::XController> xController(xModel->getCurrentController());
css::uno::Reference<css::view::XSelectionSupplier> xSelectionSupplier(xController, css::uno::UNO_QUERY);
diff --git a/chart2/source/inc/chartview/DataPointSymbolSupplier.hxx b/chart2/source/inc/chartview/DataPointSymbolSupplier.hxx
index 33127431092e..742e3634d37c 100644
--- a/chart2/source/inc/chartview/DataPointSymbolSupplier.hxx
+++ b/chart2/source/inc/chartview/DataPointSymbolSupplier.hxx
@@ -35,7 +35,7 @@ class OOO_DLLPUBLIC_CHARTVIEW DataPointSymbolSupplier
{
public:
static css::uno::Reference< css::drawing::XShapes >
- create2DSymbolList( css::uno::Reference< css::lang::XMultiServiceFactory > xShapeFactory
+ create2DSymbolList( const css::uno::Reference< css::lang::XMultiServiceFactory >& xShapeFactory
, const css::uno::Reference< css::drawing::XShapes >& xTarget
, const css::drawing::Direction3D& rSize );
};
diff --git a/chart2/source/model/main/ChartModel_Persistence.cxx b/chart2/source/model/main/ChartModel_Persistence.cxx
index a5c1035d55d9..e1e00477eb1c 100644
--- a/chart2/source/model/main/ChartModel_Persistence.cxx
+++ b/chart2/source/model/main/ChartModel_Persistence.cxx
@@ -83,10 +83,9 @@ T lcl_getProperty(
T aResult;
if( rMediaDescriptor.getLength())
{
- OUString aPropName( rPropName );
const beans::PropertyValue * pIt = rMediaDescriptor.getConstArray();
const beans::PropertyValue * pEndIt = pIt + + rMediaDescriptor.getLength();
- pIt = ::std::find_if( pIt, pEndIt, lcl_PropNameEquals( aPropName ));
+ pIt = ::std::find_if( pIt, pEndIt, lcl_PropNameEquals( rPropName ));
if( pIt != pEndIt )
(*pIt).Value >>= aResult;
}
diff --git a/chart2/source/model/template/ChartTypeTemplate.cxx b/chart2/source/model/template/ChartTypeTemplate.cxx
index 87c70a28b6d8..2c0a7e8ca4c1 100644
--- a/chart2/source/model/template/ChartTypeTemplate.cxx
+++ b/chart2/source/model/template/ChartTypeTemplate.cxx
@@ -775,7 +775,7 @@ sal_Int32 ChartTypeTemplate::getAxisCountByDimension( sal_Int32 nDimension )
void ChartTypeTemplate::FillDiagram(
const Reference< XDiagram >& xDiagram,
const Sequence< Sequence< Reference< XDataSeries > > >& aSeriesSeq,
- Reference< data::XLabeledDataSequence > xCategories,
+ const Reference< data::XLabeledDataSequence >& xCategories,
const Sequence< Reference< XChartType > >& aOldChartTypesSeq,
bool /* bCreate */ )
{
diff --git a/chart2/source/model/template/ChartTypeTemplate.hxx b/chart2/source/model/template/ChartTypeTemplate.hxx
index 1606b360e736..19ac4873ca08 100644
--- a/chart2/source/model/template/ChartTypeTemplate.hxx
+++ b/chart2/source/model/template/ChartTypeTemplate.hxx
@@ -253,8 +253,8 @@ private:
css::uno::Sequence<
css::uno::Reference<
css::chart2::XDataSeries > > > & aSeriesSeq,
- css::uno::Reference<
- css::chart2::data::XLabeledDataSequence > xCategories,
+ const css::uno::Reference<
+ css::chart2::data::XLabeledDataSequence >& xCategories,
const css::uno::Sequence<
css::uno::Reference<
css::chart2::XChartType > > & aOldChartTypesSeq,
diff --git a/chart2/source/view/charttypes/BarChart.cxx b/chart2/source/view/charttypes/BarChart.cxx
index e04971368138..411fb4ccb2f1 100644
--- a/chart2/source/view/charttypes/BarChart.cxx
+++ b/chart2/source/view/charttypes/BarChart.cxx
@@ -631,7 +631,6 @@ void BarChart::createShapes()
// uno::Reference<drawing::XShape> xPointGroupShape_Shape =
// uno::Reference<drawing::XShape>( xPointGroupShape_Shapes, uno::UNO_QUERY );
//as long as we do not iterate we do not need to create an additional group for each point
- uno::Reference< drawing::XShapes > xPointGroupShape_Shapes = xSeriesGroupShape_Shapes;
uno::Reference< beans::XPropertySet > xDataPointProperties( (*aSeriesIter)->getPropertiesOfPoint( nPointIndex ) );
sal_Int32 nGeometry3D = DataPointGeometry3D::CUBOID;
if(m_nDimension==3) try
@@ -775,7 +774,7 @@ void BarChart::createShapes()
fTopHeight *= -1.0;
xShape = createDataPoint3D_Bar(
- xPointGroupShape_Shapes, aTransformedBottom, aSize, fTopHeight, nRotateZAngleHundredthDegree
+ xSeriesGroupShape_Shapes, aTransformedBottom, aSize, fTopHeight, nRotateZAngleHundredthDegree
, xDataPointProperties, nGeometry3D );
}
else //m_nDimension!=3
@@ -795,7 +794,7 @@ void BarChart::createShapes()
AddPointToPoly( aPoly, aLeftUpperPoint );
AddPointToPoly( aPoly, drawing::Position3D( fLogicX-fLogicBarWidth/2.0,fLowerYValue,fLogicZ) );
pPosHelper->transformScaledLogicToScene( aPoly );
- xShape = m_pShapeFactory->createArea2D( xPointGroupShape_Shapes, aPoly );
+ xShape = m_pShapeFactory->createArea2D( xSeriesGroupShape_Shapes, aPoly );
setMappedProperties( xShape, xDataPointProperties, PropertyMapper::getPropertyNameMapForFilledSeriesProperties() );
}
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index b9537e9d6f6d..d50ace033647 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -417,7 +417,7 @@ OUString VSeriesPlotter::getLabelTextForValue( VDataSeries& rDataSeries
{
const LocaleDataWrapper& rLocaleDataWrapper = Application::GetSettings().GetLocaleDataWrapper();
- OUString aNumDecimalSep = rLocaleDataWrapper.getNumDecimalSep();
+ const OUString& aNumDecimalSep = rLocaleDataWrapper.getNumDecimalSep();
assert(aNumDecimalSep.getLength() > 0);
sal_Unicode cDecSeparator = aNumDecimalSep.getStr()[0];
aNumber = ::rtl::math::doubleToUString( fValue, rtl_math_StringFormat_G /*rtl_math_StringFormat*/
@@ -719,7 +719,7 @@ namespace
{
double lcl_getErrorBarLogicLength(
const uno::Sequence< double > & rData,
- uno::Reference< beans::XPropertySet > xProp,
+ const uno::Reference< beans::XPropertySet >& xProp,
sal_Int32 nErrorBarStyle,
sal_Int32 nIndex,
bool bPositive,
@@ -1275,7 +1275,7 @@ void VSeriesPlotter::createRegressionCurveEquationShapes(
else
{
const LocaleDataWrapper& rLocaleDataWrapper = Application::GetSettings().GetLocaleDataWrapper();
- OUString aNumDecimalSep = rLocaleDataWrapper.getNumDecimalSep();
+ const OUString& aNumDecimalSep = rLocaleDataWrapper.getNumDecimalSep();
assert(aNumDecimalSep.getLength() > 0);
sal_Unicode aDecimalSep = aNumDecimalSep.getStr()[0];
aFormula.append( ::rtl::math::doubleToUString(
diff --git a/chart2/source/view/inc/AbstractShapeFactory.hxx b/chart2/source/view/inc/AbstractShapeFactory.hxx
index 5715f0a461ca..c1a402c8955f 100644
--- a/chart2/source/view/inc/AbstractShapeFactory.hxx
+++ b/chart2/source/view/inc/AbstractShapeFactory.hxx
@@ -67,7 +67,7 @@ public:
void setShapeFactory(css::uno::Reference< css::lang::XMultiServiceFactory> xFactory)
{ m_xShapeFactory = xFactory; }
- static AbstractShapeFactory* getOrCreateShapeFactory(css::uno::Reference< css::lang::XMultiServiceFactory> xFactory);
+ static AbstractShapeFactory* getOrCreateShapeFactory(const css::uno::Reference< css::lang::XMultiServiceFactory>& xFactory);
virtual ~AbstractShapeFactory() {};
diff --git a/chart2/source/view/main/AbstractShapeFactory.cxx b/chart2/source/view/main/AbstractShapeFactory.cxx
index 333f4a8c86ae..777bdd454c75 100644
--- a/chart2/source/view/main/AbstractShapeFactory.cxx
+++ b/chart2/source/view/main/AbstractShapeFactory.cxx
@@ -79,7 +79,7 @@ osl::Module* getOpenGLModule()
extern "C" opengl::OpenglShapeFactory* getOpenglShapeFactory();
#endif
-AbstractShapeFactory* AbstractShapeFactory::getOrCreateShapeFactory(uno::Reference< lang::XMultiServiceFactory> xFactory)
+AbstractShapeFactory* AbstractShapeFactory::getOrCreateShapeFactory(const uno::Reference< lang::XMultiServiceFactory>& xFactory)
{
static AbstractShapeFactory* pShapeFactory = nullptr;
diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx
index c9aba8d841be..6251dadd43f5 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -1437,7 +1437,7 @@ bool lcl_IsPieOrDonut( const uno::Reference< XDiagram >& xDiagram )
return DiagramHelper::isPieOrDonutChart( xDiagram );
}
-void lcl_setDefaultWritingMode( std::shared_ptr< DrawModelWrapper > pDrawModelWrapper, ChartModel& rModel)
+void lcl_setDefaultWritingMode( const std::shared_ptr< DrawModelWrapper >& pDrawModelWrapper, ChartModel& rModel)
{
//get writing mode from parent document:
if( SvtLanguageOptions().IsCTLFontEnabled() )
diff --git a/chart2/source/view/main/DataPointSymbolSupplier.cxx b/chart2/source/view/main/DataPointSymbolSupplier.cxx
index 96190d14b1b5..986f8d7f2fd2 100644
--- a/chart2/source/view/main/DataPointSymbolSupplier.cxx
+++ b/chart2/source/view/main/DataPointSymbolSupplier.cxx
@@ -26,7 +26,7 @@ namespace chart
using namespace ::com::sun::star;
uno::Reference< drawing::XShapes > DataPointSymbolSupplier::create2DSymbolList(
- uno::Reference< lang::XMultiServiceFactory > xShapeFactory
+ const uno::Reference< lang::XMultiServiceFactory >& xShapeFactory
, const uno::Reference< drawing::XShapes >& xTarget
, const drawing::Direction3D& rSize )
{
diff --git a/chart2/source/view/main/ShapeFactory.cxx b/chart2/source/view/main/ShapeFactory.cxx
index 821d77422ec9..a590b57f4321 100644
--- a/chart2/source/view/main/ShapeFactory.cxx
+++ b/chart2/source/view/main/ShapeFactory.cxx
@@ -824,7 +824,7 @@ drawing::PolyPolygonBezierCoords getRingBezierCoords(
double fUnitCircleInnerRadius
, double fUnitCircleOuterRadius
, double fStartAngleRadian, double fWidthAngleRadian
- , ::basegfx::B2DHomMatrix aTransformationFromUnitCircle
+ , const ::basegfx::B2DHomMatrix& aTransformationFromUnitCircle
, const double fAngleSubdivisionRadian )
{
drawing::PolyPolygonBezierCoords aReturn = drawing::PolyPolygonBezierCoords();