diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-29 14:15:54 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-29 18:19:37 +0100 |
| commit | 4b030651a0ad5e0eedd6d08b6cd1459ca514d818 (patch) | |
| tree | 5a02580a42d8593c3afc9f39816128562a9cfc6b /chart2 | |
| parent | d460842616d467dfaf7b51ac2db94adb1ff5cbb0 (diff) | |
loplugin:passstuffbyref improved return in various
Change-Id: I0a8282d8e0d9575b055243073fc89a7d6b67b560
Reviewed-on: https://gerrit.libreoffice.org/47173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2')
| -rw-r--r-- | chart2/source/controller/inc/SelectionHelper.hxx | 4 | ||||
| -rw-r--r-- | chart2/source/controller/main/SelectionHelper.cxx | 4 | ||||
| -rw-r--r-- | chart2/source/inc/PopupRequest.hxx | 2 | ||||
| -rw-r--r-- | chart2/source/view/main/VButton.hxx | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/chart2/source/controller/inc/SelectionHelper.hxx b/chart2/source/controller/inc/SelectionHelper.hxx index b40d8fe8592c..a3002dda8a7f 100644 --- a/chart2/source/controller/inc/SelectionHelper.hxx +++ b/chart2/source/controller/inc/SelectionHelper.hxx @@ -36,8 +36,8 @@ class Selection public: //methods bool hasSelection(); - OUString getSelectedCID(); - css::uno::Reference< css::drawing::XShape > getSelectedAdditionalShape(); + OUString const & getSelectedCID(); + css::uno::Reference< css::drawing::XShape > const & getSelectedAdditionalShape(); const ObjectIdentifier& getSelectedOID() const { return m_aSelectedOID;} bool isResizeableObjectSelected(); diff --git a/chart2/source/controller/main/SelectionHelper.cxx b/chart2/source/controller/main/SelectionHelper.cxx index cf6ebddf102e..44171c6bd966 100644 --- a/chart2/source/controller/main/SelectionHelper.cxx +++ b/chart2/source/controller/main/SelectionHelper.cxx @@ -65,12 +65,12 @@ bool Selection::hasSelection() return m_aSelectedOID.isValid(); } -OUString Selection::getSelectedCID() +OUString const & Selection::getSelectedCID() { return m_aSelectedOID.getObjectCID(); } -uno::Reference< drawing::XShape > Selection::getSelectedAdditionalShape() +uno::Reference< drawing::XShape > const & Selection::getSelectedAdditionalShape() { return m_aSelectedOID.getAdditionalShape(); } diff --git a/chart2/source/inc/PopupRequest.hxx b/chart2/source/inc/PopupRequest.hxx index fb98d3d9b19d..006a58003ffc 100644 --- a/chart2/source/inc/PopupRequest.hxx +++ b/chart2/source/inc/PopupRequest.hxx @@ -31,7 +31,7 @@ public: explicit PopupRequest(); virtual ~PopupRequest() override; - css::uno::Reference<css::awt::XCallback> getCallback() + css::uno::Reference<css::awt::XCallback> const & getCallback() { return m_xCallback; } diff --git a/chart2/source/view/main/VButton.hxx b/chart2/source/view/main/VButton.hxx index 9af9318cb1f6..adb53282b85a 100644 --- a/chart2/source/view/main/VButton.hxx +++ b/chart2/source/view/main/VButton.hxx @@ -66,7 +66,7 @@ public: { m_aPosition = rPosition; } - css::awt::Size getSize() + css::awt::Size const & getSize() { return m_aSize; } |