diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2022-04-22 16:17:09 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2022-06-05 07:34:07 +0200 |
| commit | f66b5c4bdf7d285d8eae6231b9dc906eca065072 (patch) | |
| tree | 1cb89c6933123de819c7d061cd4404e8f2fba1ca /chart2 | |
| parent | 2493e90ef3b955a06c80ecb5e5f6b4173b5b71ef (diff) | |
Drop a bit more special-casing for Chart's sidebar property deck
Introduced in commit 2d01ed9e8be543460e41e009fa992103a7c8d4c0
Author Muhammet Kara <muhammet.kara@collabora.com>
Date Mon Nov 25 21:55:31 2019 +0300
tdf#94288: Show chart props sidebar on activation
The problem was that ChartController::attachFrame, that called
SelectionChangeHandler::selectionChanged notification, did that
*prior* to setting its m_xFrame - and the notification failed
in ContextChangeEventMultiplexer::NotifyContextChange, that
checks the frame first. That prevented the proper context (with
correct application and context names) to arrive to listeners,
and the sidebar didn't update properly.
Changing the order of the calls should fix the original problem.
Change-Id: I9da8465af2ee4ed1f8eabed1c65d1c318f81a3f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133326
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135396
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Diffstat (limited to 'chart2')
| -rw-r--r-- | chart2/source/controller/main/ChartController.cxx | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/chart2/source/controller/main/ChartController.cxx b/chart2/source/controller/main/ChartController.cxx index 19c314da2635..f50fab660acf 100644 --- a/chart2/source/controller/main/ChartController.cxx +++ b/chart2/source/controller/main/ChartController.cxx @@ -385,6 +385,17 @@ void SAL_CALL ChartController::attachFrame( if( impl_isDisposedOrSuspended() ) //@todo? allow attaching the frame while suspended? return; //behave passive if already disposed or suspended + if(m_xFrame.is()) //what happens, if we do have a Frame already?? + { + //@todo? throw exception? + OSL_FAIL( "there is already a frame attached to the controller" ); + return; + } + + //--attach frame + m_xFrame = xFrame; //the frameloader is responsible to call xFrame->setComponent + + // Only notify after setting the frame, otherwise notification will fail mpSelectionChangeHandler->Connect(); uno::Reference<ui::XSidebar> xSidebar = getSidebarFromModel(getModel()); @@ -398,16 +409,6 @@ void SAL_CALL ChartController::attachFrame( mpSelectionChangeHandler->selectionChanged(aEvent); } - if(m_xFrame.is()) //what happens, if we do have a Frame already?? - { - //@todo? throw exception? - OSL_FAIL( "there is already a frame attached to the controller" ); - return; - } - - //--attach frame - m_xFrame = xFrame; //the frameloader is responsible to call xFrame->setComponent - //add as disposelistener to the frame (due to persistent reference) ??...: //the frame is considered to be owner of this controller and will live longer than we do |