summaryrefslogtreecommitdiff
path: root/chart2
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-09-26 13:52:09 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-09-28 17:56:49 +0200
commitef98596d62304d64d89b04de04c2bebff76286a0 (patch)
tree3b9c7e07e77273bf998955021002c2ef24faf7c1 /chart2
parent66e45a1ae861d50edf65fed9e39c9c9d5b15e0ac (diff)
loplugin:virtualdead in chart2
Change-Id: Ia24e5072cf4d16e8a437323fa7fd5ab5207e71d2 Reviewed-on: https://gerrit.libreoffice.org/79645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2')
-rw-r--r--chart2/source/controller/dialogs/ChartTypeDialogController.cxx8
-rw-r--r--chart2/source/controller/dialogs/ChartTypeDialogController.hxx2
-rw-r--r--chart2/source/controller/dialogs/tp_ChartType.cxx2
-rw-r--r--chart2/source/controller/sidebar/ChartAreaPanel.cxx4
-rw-r--r--chart2/source/controller/sidebar/ChartAreaPanel.hxx1
-rw-r--r--chart2/source/controller/sidebar/ChartAxisPanel.cxx4
-rw-r--r--chart2/source/controller/sidebar/ChartAxisPanel.hxx1
-rw-r--r--chart2/source/controller/sidebar/ChartLinePanel.cxx4
-rw-r--r--chart2/source/controller/sidebar/ChartLinePanel.hxx1
-rw-r--r--chart2/source/controller/sidebar/ChartSeriesPanel.cxx4
-rw-r--r--chart2/source/controller/sidebar/ChartSeriesPanel.hxx1
-rw-r--r--chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx1
-rw-r--r--chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx2
13 files changed, 1 insertions, 34 deletions
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
index 2b6a98c61d02..eeebd989e5ed 100644
--- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
+++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
@@ -339,10 +339,6 @@ bool ChartTypeDialogController::shouldShow_StackingControl() const
{
return false;
}
-bool ChartTypeDialogController::shouldShow_DeepStackingControl() const
-{
- return false;
-}
bool ChartTypeDialogController::shouldShow_SplineControl() const
{
return false;
@@ -714,10 +710,6 @@ bool LineChartDialogController::shouldShow_StackingControl() const
{
return true;
}
-bool LineChartDialogController::shouldShow_DeepStackingControl() const
-{
- return false;
-}
bool LineChartDialogController::shouldShow_SplineControl() const
{
return true;
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx b/chart2/source/controller/dialogs/ChartTypeDialogController.hxx
index 2985d31b10db..e655394c1da3 100644
--- a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx
+++ b/chart2/source/controller/dialogs/ChartTypeDialogController.hxx
@@ -96,7 +96,6 @@ public:
virtual bool shouldShow_3DLookControl() const;
virtual bool shouldShow_StackingControl() const;
- virtual bool shouldShow_DeepStackingControl() const;
virtual bool shouldShow_SplineControl() const;
virtual bool shouldShow_GeometryControl() const;
virtual bool shouldShow_SortByXValuesResourceGroup() const;
@@ -192,7 +191,6 @@ public:
virtual void adjustParameterToMainType( ChartTypeParameter& rParameter ) override;
virtual bool shouldShow_StackingControl() const override;
- virtual bool shouldShow_DeepStackingControl() const override;
virtual bool shouldShow_SplineControl() const override;
};
diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx b/chart2/source/controller/dialogs/tp_ChartType.cxx
index 1391230ad55f..f2d9e1e22b31 100644
--- a/chart2/source/controller/dialogs/tp_ChartType.cxx
+++ b/chart2/source/controller/dialogs/tp_ChartType.cxx
@@ -830,7 +830,7 @@ void ChartTypeTabPage::showAllControls( ChartTypeDialogController& rTypeControll
bool bShow = rTypeController.shouldShow_3DLookControl();
m_pDim3DLookResourceGroup->showControls( bShow );
bShow = rTypeController.shouldShow_StackingControl();
- m_pStackingResourceGroup->showControls( bShow, rTypeController.shouldShow_DeepStackingControl() );
+ m_pStackingResourceGroup->showControls( bShow, false );
bShow = rTypeController.shouldShow_SplineControl();
m_pSplineResourceGroup->showControls( bShow );
bShow = rTypeController.shouldShow_GeometryControl();
diff --git a/chart2/source/controller/sidebar/ChartAreaPanel.cxx b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
index 843c4e720e0d..61e72318043c 100644
--- a/chart2/source/controller/sidebar/ChartAreaPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartAreaPanel.cxx
@@ -503,10 +503,6 @@ void ChartAreaPanel::selectionChanged(bool bCorrectType)
updateData();
}
-void ChartAreaPanel::SelectionInvalid()
-{
-}
-
void ChartAreaPanel::updateModel(
css::uno::Reference<css::frame::XModel> xModel)
{
diff --git a/chart2/source/controller/sidebar/ChartAreaPanel.hxx b/chart2/source/controller/sidebar/ChartAreaPanel.hxx
index 454c99a86851..5c0e0b23bbc4 100644
--- a/chart2/source/controller/sidebar/ChartAreaPanel.hxx
+++ b/chart2/source/controller/sidebar/ChartAreaPanel.hxx
@@ -63,7 +63,6 @@ public:
virtual void modelInvalid() override;
virtual void selectionChanged(bool bCorrectType) override;
- virtual void SelectionInvalid() override;
virtual void dispose() override;
diff --git a/chart2/source/controller/sidebar/ChartAxisPanel.cxx b/chart2/source/controller/sidebar/ChartAxisPanel.cxx
index 20a848fe4792..384980e94645 100644
--- a/chart2/source/controller/sidebar/ChartAxisPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartAxisPanel.cxx
@@ -348,10 +348,6 @@ void ChartAxisPanel::selectionChanged(bool bCorrectType)
updateData();
}
-void ChartAxisPanel::SelectionInvalid()
-{
-}
-
IMPL_LINK(ChartAxisPanel, CheckBoxHdl, Button*, pButton, void)
{
CheckBox* pCheckbox = static_cast<CheckBox*>(pButton);
diff --git a/chart2/source/controller/sidebar/ChartAxisPanel.hxx b/chart2/source/controller/sidebar/ChartAxisPanel.hxx
index 70f0d7583868..f72b12152a7e 100644
--- a/chart2/source/controller/sidebar/ChartAxisPanel.hxx
+++ b/chart2/source/controller/sidebar/ChartAxisPanel.hxx
@@ -70,7 +70,6 @@ public:
virtual void modelInvalid() override;
virtual void selectionChanged(bool bCorrectType) override;
- virtual void SelectionInvalid() override;
virtual void updateModel(css::uno::Reference<css::frame::XModel> xModel) override;
diff --git a/chart2/source/controller/sidebar/ChartLinePanel.cxx b/chart2/source/controller/sidebar/ChartLinePanel.cxx
index 8310a7a44707..356bd229fa24 100644
--- a/chart2/source/controller/sidebar/ChartLinePanel.cxx
+++ b/chart2/source/controller/sidebar/ChartLinePanel.cxx
@@ -223,10 +223,6 @@ void ChartLinePanel::selectionChanged(bool bCorrectType)
updateData();
}
-void ChartLinePanel::SelectionInvalid()
-{
-}
-
void ChartLinePanel::updateModel(
css::uno::Reference<css::frame::XModel> xModel)
{
diff --git a/chart2/source/controller/sidebar/ChartLinePanel.hxx b/chart2/source/controller/sidebar/ChartLinePanel.hxx
index c0b3d19fd579..c2e5d1fee7e1 100644
--- a/chart2/source/controller/sidebar/ChartLinePanel.hxx
+++ b/chart2/source/controller/sidebar/ChartLinePanel.hxx
@@ -55,7 +55,6 @@ public:
virtual void modelInvalid() override;
virtual void selectionChanged(bool bCorrectType) override;
- virtual void SelectionInvalid() override;
virtual void dispose() override;
diff --git a/chart2/source/controller/sidebar/ChartSeriesPanel.cxx b/chart2/source/controller/sidebar/ChartSeriesPanel.cxx
index 3eddfb58c2dd..e0d28fa3e7bc 100644
--- a/chart2/source/controller/sidebar/ChartSeriesPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartSeriesPanel.cxx
@@ -442,10 +442,6 @@ void ChartSeriesPanel::selectionChanged(bool bCorrectType)
updateData();
}
-void ChartSeriesPanel::SelectionInvalid()
-{
-}
-
IMPL_LINK(ChartSeriesPanel, CheckBoxHdl, Button*, pButton, void)
{
CheckBox* pCheckBox = static_cast<CheckBox*>(pButton);
diff --git a/chart2/source/controller/sidebar/ChartSeriesPanel.hxx b/chart2/source/controller/sidebar/ChartSeriesPanel.hxx
index ba5d55a6b210..e33fec10cf3f 100644
--- a/chart2/source/controller/sidebar/ChartSeriesPanel.hxx
+++ b/chart2/source/controller/sidebar/ChartSeriesPanel.hxx
@@ -76,7 +76,6 @@ public:
virtual void modelInvalid() override;
virtual void selectionChanged(bool bCorrectType) override;
- virtual void SelectionInvalid() override;
virtual void updateModel(css::uno::Reference<css::frame::XModel> xModel) override;
diff --git a/chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx b/chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx
index 19f4335e0b49..e037fc39aa5f 100644
--- a/chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx
+++ b/chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx
@@ -66,7 +66,6 @@ void ChartSidebarSelectionListener::selectionChanged(const css::lang::EventObjec
void ChartSidebarSelectionListener::disposing(const css::lang::EventObject& /*rEvent*/)
{
- mpParent->SelectionInvalid();
}
void ChartSidebarSelectionListener::setAcceptedTypes(const std::vector<ObjectType>& aTypes)
diff --git a/chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx b/chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx
index b0e0c36b981e..84efd0323fc5 100644
--- a/chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx
+++ b/chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx
@@ -26,8 +26,6 @@ public:
virtual ~ChartSidebarSelectionListenerParent();
virtual void selectionChanged(bool bSelected) = 0;
-
- virtual void SelectionInvalid() = 0;
};
class ChartSidebarSelectionListener : public cppu::WeakImplHelper<css::view::XSelectionChangeListener>