diff options
| author | Moaz <moaz.eldefrawy@gmail.com> | 2021-02-21 20:22:40 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-02-25 07:50:29 +0100 |
| commit | a9a350c13d8fb454c3f1db7ca6a7f10c1e7a19bb (patch) | |
| tree | c3115fa9b7018eb6629cdaf607ef4a49adb147dc /chart2 | |
| parent | befc0c2b0e0b3bf293a2446d71e38717ed53985b (diff) | |
tdf#139734 Remove redundant asserts after MacrosTest::loadFromDesktop
MacrosTest::loadFromDesktop itself asserts on its return value.
Thus, the additional checks in unit tests are redundant, and only create
noise unrelated to the tested functionality.
Change-Id: If616001b296afdde38f5a23ececee3d44b4a395d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111290
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'chart2')
| -rw-r--r-- | chart2/qa/extras/charttest.hxx | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx index eeebd0ea237a..8dcdcf98bc50 100644 --- a/chart2/qa/extras/charttest.hxx +++ b/chart2/qa/extras/charttest.hxx @@ -120,7 +120,6 @@ void ChartTest::load( std::u16string_view aDir, const OUString& aName ) if (mxComponent.is()) mxComponent->dispose(); mxComponent = loadFromDesktop(m_directories.getURLFromSrc(aDir) + aName, maServiceName); - CPPUNIT_ASSERT(mxComponent.is()); } std::shared_ptr<utl::TempFile> ChartTest::save(const OUString& rFilterName) @@ -160,7 +159,6 @@ std::shared_ptr<utl::TempFile> ChartTest::reload(const OUString& rFilterName) if(!mbSkipValidation) validate(pTempFile->GetFileName(), test::MSBINARY); } - CPPUNIT_ASSERT(mxComponent.is()); return pTempFile; } |