diff options
author | Michael Stahl <michael.stahl@allotropia.de> | 2023-05-24 20:16:49 +0200 |
---|---|---|
committer | Michael Stahl <michael.stahl@allotropia.de> | 2023-05-24 22:29:15 +0200 |
commit | b0e2b60fa45f236f6a993cc1295a7afddabb5098 (patch) | |
tree | 18ff6911f47a90dc548c7cfc9f8e0d1f0c094111 /chart2 | |
parent | 35f7f1ad9c2aba1644a46dfb4da0a86f72c6a224 (diff) |
tdf#148897 tdf#143239 sw: move flys off the page in SwTextFrame::Format()
The bugfix regresses testTdf143239, so we add some scary additional hacks:
* testTdf143239: turns out that this was already moving back and forth
many times but then ran into some loop control - now with the fix for
tdf#148897 this still happens, but the result is now bad, where
previously it was good (by accident?).
Move the flys off the page also in SwTextFrame::Format() - there is
already code there to detect that footnotes have been moved off by
Format_() - this is similar, the formatting should be redone immediately
if there is a fly that created SwFlyPortions in the current frame, but
the fly was actually moved to the next page by the very same
Format_() splitting the frame.
* testKeepWithNextPlusFlyFollowTextFlow: here the problem was that the
para with the fly didn't move back to page 1; need to clear the
SwLayouter when toggling FieldNames.
* testKeepwithnextFullheight: this test document will loop creating
infinite pages if the newly add move code is run during
SwObjectFormatterTextFrame - the latter must move the flys if it is
active, not SwTextFrame::Format().
This is all a bit experimental but i failed to have a better idea...
(regression from previous commit)
Change-Id: Icfcbd270137116198128d549b34e7f49a47b6911
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152246
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Diffstat (limited to 'chart2')
0 files changed, 0 insertions, 0 deletions