diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-08-15 11:05:55 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-08-15 11:59:02 +0200 |
| commit | fe00a724a918606e5c8c2c32b155bc50b33d56bd (patch) | |
| tree | c638ef9b9ca8d354a911feb82d6905f10861f0bc /chart2 | |
| parent | 5827e30109b683cb74efa21d154e5219fe9e2a0c (diff) | |
loplugin:sequenceloop in basic..cui
Change-Id: I15d825de3201808d188b461415f78a4d81b64127
Reviewed-on: https://gerrit.libreoffice.org/77494
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2')
| -rw-r--r-- | chart2/qa/extras/chart2dump/chart2dump.cxx | 2 | ||||
| -rw-r--r-- | chart2/source/view/main/ChartView.cxx | 6 | ||||
| -rw-r--r-- | chart2/source/view/main/VLegend.cxx | 3 |
3 files changed, 7 insertions, 4 deletions
diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx b/chart2/qa/extras/chart2dump/chart2dump.cxx index 5a467dbd448f..b640a46f9010 100644 --- a/chart2/qa/extras/chart2dump/chart2dump.cxx +++ b/chart2/qa/extras/chart2dump/chart2dump.cxx @@ -224,7 +224,7 @@ protected: std::abs(aExpectedTransform.Line3.Column3 - rTransform.Line3.Column3) < fEPS); } - OUString sequenceToOneLineString(uno::Sequence<OUString>& rSeq) + OUString sequenceToOneLineString(const uno::Sequence<OUString>& rSeq) { OUStringBuffer aBufer; for (const OUString& seqItem : rSeq) diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx index 3c4d4eb5828b..897d1276c095 100644 --- a/chart2/source/view/main/ChartView.cxx +++ b/chart2/source/view/main/ChartView.cxx @@ -2304,7 +2304,8 @@ void lcl_createButtons(const uno::Reference<drawing::XShapes>& xPageShapes, { x = 0; - for (css::chart2::data::PivotTableFieldEntry const & rPageFieldEntry : xPivotTableDataProvider->getPageFields()) + const css::uno::Sequence<chart2::data::PivotTableFieldEntry> aPivotFieldEntries = xPivotTableDataProvider->getPageFields(); + for (css::chart2::data::PivotTableFieldEntry const & rPageFieldEntry : aPivotFieldEntries) { std::unique_ptr<VButton> pButton(new VButton); pButton->init(xPageShapes, xShapeFactory); @@ -2330,7 +2331,8 @@ void lcl_createButtons(const uno::Reference<drawing::XShapes>& xPageShapes, if (xPivotTableDataProvider->getRowFields().hasElements()) { x = 200; - for (css::chart2::data::PivotTableFieldEntry const & rRowFieldEntry : xPivotTableDataProvider->getRowFields()) + const css::uno::Sequence<chart2::data::PivotTableFieldEntry> aPivotFieldEntries = xPivotTableDataProvider->getRowFields(); + for (css::chart2::data::PivotTableFieldEntry const & rRowFieldEntry : aPivotFieldEntries) { std::unique_ptr<VButton> pButton(new VButton); diff --git a/chart2/source/view/main/VLegend.cxx b/chart2/source/view/main/VLegend.cxx index 43f103db7ca1..cc7ff9a2d567 100644 --- a/chart2/source/view/main/VLegend.cxx +++ b/chart2/source/view/main/VLegend.cxx @@ -793,7 +793,8 @@ std::vector<std::shared_ptr<VButton>> lcl_createButtons( int x = 100; int y = 100; - for (chart2::data::PivotTableFieldEntry const & sColumnFieldEntry : xPivotTableDataProvider->getColumnFields()) + const css::uno::Sequence<chart2::data::PivotTableFieldEntry> aPivotFieldEntries = xPivotTableDataProvider->getColumnFields(); + for (chart2::data::PivotTableFieldEntry const & sColumnFieldEntry : aPivotFieldEntries) { std::shared_ptr<VButton> pButton(new VButton); aButtons.push_back(pButton); |